MIME-Version: 1.0
References: 
 <CADkLM=coCVy92QkVUUTLdo5eO2bMDtwMrzRn_8miAhX+uPaqXg@mail.gmail.com>
 <CAA5RZ0vY5jHXQEOyUdjW7tPrXb9TY_bdr8ZpCRuALj1zU5DD_w@mail.gmail.com>
 <CADkLM=d8vuFzQSrV+8MfviK3-TyG8r45yEbnOUd6VJGEoyNmHA@mail.gmail.com>
In-Reply-To: 
 <CADkLM=d8vuFzQSrV+8MfviK3-TyG8r45yEbnOUd6VJGEoyNmHA@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Wed, 4 Mar 2026 16:54:21 -0600
Message-ID: 
 <CAA5RZ0tSYjO4Frt-SkpV1kmXn4jYTdVP-1XEMtFF2yJ9B4scDg@mail.gmail.com>
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
To: Corey Huinker <corey.huinker@gmail.com>
Cc: nathandbossart@gmail.com, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0tSYjO4Frt-SkpV1kmXn4jYTdVP-1XEMtFF2yJ9B4scDg%40mail.gmail.com>
Precedence: bulk

>> I dislike the existing "pg_stats.tablename", since this can also be an
>> expression index.
>> "pg_stats.relation" with a description of "Name of table or index" is
>> more appropriate.
>> It is a change that we can possibly make in a major version. Looked
>> through the archives,
>> and did not see this being reported/discussed.
>
>
> I don't see it changing in any version, minor or major.

This could be a separate discussion as it's not the fault of this patch,
but clearly "tablename" is not correct here.

>> I noticed in other pg_fatal messages, we include OIDs
>>
>>             pg_fatal("could not find function definition for function
>> with OID %u",
>>                      cast->castfunc);
>>
>> Should we do the same here?
>
>
> If I had the oid, I wouldn't have the error. :)

oops, you're right.


I noticed that you changed the tests to selecting individual columns. I am
not clear as to why this is better?

-SELECT *
+SELECT schemaname, tablename, attname, attnum, inherited, null_frac, avg_width,
+    n_distinct, most_common_vals, most_common_freqs, histogram_bounds,
+    correlation, most_common_elems, most_common_elem_freqs,
+    elem_count_histogram, range_length_histogram, range_empty_frac,
+    range_bounds_histogram

Otherwise v2 LGTM.

--
Sami Imseih
Amazon Web Services (AWS)