MIME-Version: 1.0
References: <20260324151133.7940a5c1f2ebd594d54da481@sraoss.co.jp>
 <CAA5RZ0snnePNW1NKGKh+NyJ1CY26T5F_6-tTq+BHWM2kj1fN1g@mail.gmail.com>
 <20260325012847.e026ba1860c07288efe3e97d@sraoss.co.jp>
 <20260326192203.e6dbb8d80f8d27dc15ceee59@sraoss.co.jp>
 <acW8MW-Gb8Aj_TH2@paquier.xyz>
 <20260327163549.b5df519c0099970ddbb3412d@sraoss.co.jp>
 <CAA5RZ0tNh03LLgJVMA=PXSdY8YVoui4_GyfbfTrYK5cka3Q9Rw@mail.gmail.com>
 <20260328161802.f35b5a3e739566ffd7c1053b@sraoss.co.jp>
 <20260413170551.5ec43ba5a2c848f0d46c6a0b@sraoss.co.jp>
In-Reply-To: <20260413170551.5ec43ba5a2c848f0d46c6a0b@sraoss.co.jp>
From: Sami Imseih <samimseih@gmail.com>
Date: Wed, 22 Apr 2026 07:49:55 -0500
Message-ID: 
 <CAA5RZ0tUHU-r=Tc47P2DZyytF7x5h5OwBiRABe_dZt+zWNqe9g@mail.gmail.com>
Subject: Re: Track skipped tables during autovacuum and autoanalyze
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Michael Paquier <michael@paquier.xyz>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0tUHU-r%3DTc47P2DZyytF7x5h5OwBiRABe_dZt%2BzWNqe9g%40mail.gmail.com>
Precedence: bulk

Thanks for the updated patch!

> I've attached a patch reflecting your comments on items 1, 2, and 5.
> As for items 3, 4, and 6, I am waiting for your comments, so the patch
> is left unchanged for now.

A few more comments:

1/

+            relid = RangeVarGetRelid(vrel->relation, NoLock, false);

Should this be called with "true" as the 3rd (missing_ok) argument, otherwise
we end up with an error instead of a "--- relation no longer exists" log. right?

2/

Can the isolation tests
src/test/isolation/specs/vacuum-skip-locked.spec be updated
to check pg_stat_user_tables as well?

3/ comment fix:

This:
* Relation could not be opened hence generate if possible a log

Should be:
* Relation could not be opened, hence generate if possible a log

--
Sami Imseih
Amazon Web Services (AWS)