MIME-Version: 1.0
References: <adEhRzu4YM7ztLXr@nathan>
 <CAA5RZ0vxby2osMMaCuZ=680tmt583cF9n4rOzTGdsiS-1PJknA@mail.gmail.com>
 <adE9RbcA7lhH_w2d@nathan>
 <CAA5RZ0tYzPDeXbqz9uKacRV2xjD055qrg=s3w2PEQPK8EruuSg@mail.gmail.com>
 <adFiCgN22xJ7Z-oR@nathan>
 <CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com>
 <adQsdvPPNviWMCXb@nathan> <5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com>
 <3077290.1775668665@sss.pgh.pa.us> <adaWuTR7oCKodH7k@nathan>
 <adacEjlRZco26f0h@nathan>
In-Reply-To: <adacEjlRZco26f0h@nathan>
From: Sami Imseih <samimseih@gmail.com>
Date: Wed, 8 Apr 2026 13:28:06 -0500
Message-ID: 
 <CAA5RZ0tUq7SEHvAPkYpCw7Y4XOoWLPpsfxO2ZQ5AzQRcQMMAgg@mail.gmail.com>
Subject: Re: Add pg_stat_autovacuum_priority
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Lakhin <exclusion@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Robert Treat <rob@xzilla.net>,
	satyanarlapuram@gmail.com, pgsql-hackers <pgsql-hackers@postgresql.org>,
	tndrwang@gmail.com
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0tUq7SEHvAPkYpCw7Y4XOoWLPpsfxO2ZQ5AzQRcQMMAgg%40mail.gmail.com>
Precedence: bulk

> diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
> index bd626a16363..6d4a34257fb 100644
> --- a/src/backend/postmaster/autovacuum.c
> +++ b/src/backend/postmaster/autovacuum.c
> @@ -3327,7 +3327,15 @@ relation_needs_vacanalyze(Oid relid,
>               anltuples, anlthresh, scores->anl,
>               scores->xid, scores->mxid);
>
> -    pfree(tabentry);
> +    /*
> +     * Avoid leaking pgstat entries until the end of autovacuum.  Elsewhere,
> +     * we let the commit/abort machinery take care of freeing it.  While
> +     * autovacuum workers set stats_fetch_consistency to "none", it might be
> +     * set to a different value in other processes, so we can't safely free it
> +     * here for them.
> +     */
> +    if (AmAutoVacuumWorkerProcess())
> +        pfree(tabentry);
>  }

This works too, but v1-0001 is more generalized and we don't have to
care about who the caller is when deciding to free or not.

--
Sami