MIME-Version: 1.0
References: <2250061.1774104346@sss.pgh.pa.us>
 <3341199.1774221191@sss.pgh.pa.us>
 <3424809.1774234940@sss.pgh.pa.us> <acIA8KKBTv-T53YG@paquier.xyz>
 <x2tknjejjouleunkqrvpnwn2tuulunybinycidefm3wmnsyhht@pw5uo3wrqx43>
 <CA+hUKGL2dppjO4o28ZY7n_LTWviKLAi-7KZ=tx5w2HGevCEYPA@mail.gmail.com>
 <1624716.1774736283@sss.pgh.pa.us> <1626907.1774737417@sss.pgh.pa.us>
 <97a382c0-1f19-4ea0-951f-e37e6abc34a3@vondra.me>
 <1630755.1774739531@sss.pgh.pa.us>
 <c3a2b730-9d90-4a66-ae5e-50f6d77922d6@vondra.me>
 <CA+hUKGJyvdyWMC-RW1njqevD-q_gTbFq+DyDiFpUJVaG+DY20w@mail.gmail.com>
 <1873141.1774823011@sss.pgh.pa.us>
 <CA+hUKG+Pqz5=YQG_=8ho0YsTfn2HWOsJQWqS4j0q8QQWweJP9w@mail.gmail.com>
 <3049460.1775067940@sss.pgh.pa.us> <3118179.1775092964@sss.pgh.pa.us>
 <CA+hUKG+-pn14s_tjEBO6YKHmc=uRhGVn=w2oM91KKnEUc7pH0Q@mail.gmail.com>
 <3565835.1775147392@sss.pgh.pa.us> <3579709.1775151816@sss.pgh.pa.us>
 <63de1553-829a-488d-8ee0-976afb8dd32c@vondra.me>
 <3586483.1775155672@sss.pgh.pa.us>
 <CAN55FZ026+y8nJYR5w8miiaQ4Mw8F1xtBdTdR52cDZ4fn2pQ8g@mail.gmail.com>
 <CA+hUKG+LekzSbmxbG4u5wDxQ9jHnzxN-wfdZ1pQSZquELmGtVA@mail.gmail.com>
In-Reply-To: 
 <CA+hUKG+LekzSbmxbG4u5wDxQ9jHnzxN-wfdZ1pQSZquELmGtVA@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Fri, 3 Apr 2026 09:59:19 -0500
Message-ID: 
 <CAA5RZ0tXWJdL5mTJ8p9RrnThPoja-2LDykUykcbJt5iSjmWe6Q@mail.gmail.com>
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Tomas Vondra <tomas@vondra.me>, Andres Freund <andres@anarazel.de>,
	Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>,
 Amul Sul <sulamul@gmail.com>,
	Zsolt Parragi <zsolt.parragi@percona.com>,
 Robert Haas <robertmhaas@gmail.com>,
	Chao Li <li.evan.chao@gmail.com>,
	Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
 Fujii Masao <masao.fujii@gmail.com>,
	Jakub Wartak <jakub.wartak@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000088ef91064e8f90b7"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0tXWJdL5mTJ8p9RrnThPoja-2LDykUykcbJt5iSjmWe6Q%40mail.gmail.com>
Precedence: bulk

--00000000000088ef91064e8f90b7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On Sat, Apr 4, 2026 at 12:38=E2=80=AFAM Nazir Bilal Yavuz <byavuz81@gmail=
.com> wrote:
> > I also tried Thomas'
> > "v2-0001-Improve-tar-portability-logic-from-ebba64c0" [3] but it
> > didn't fix the problem on OpenBSD [4].
>
> Apparently it wants -F ustar, like this.  Funny that it passed on the
> build farm animals though.  Oh, it looks like they changed the default
> fairly recently.

LGTM with just a correction of my earlier comment.

< +    # ustar format supports UIDs only up to 2^21 (2097151).  Override
---
> +    # ustar format supports UIDs only up to 2^21 - 1 (2097151).  Overrid=
e

--
Sami

--00000000000088ef91064e8f90b7
Content-Type: application/octet-stream;
	name="v4-0001-Improve-tar-portability-logic-from-ebba64c0.patch"
Content-Disposition: attachment;
	filename="v4-0001-Improve-tar-portability-logic-from-ebba64c0.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnj137pq0>
X-Attachment-Id: f_mnj137pq0

RnJvbSBmZTUzY2M2ZDkzMTE0YTY3MDBkYzAwYTU3Nzk1ZTUzYTBmYTBhNGVlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgTXVucm8gPHRob21hcy5tdW5yb0BnbWFpbC5jb20+
CkRhdGU6IEZyaSwgMyBBcHIgMjAyNiAxMjowMzo1NiArMTMwMApTdWJqZWN0OiBbUEFUQ0ggdjQg
MS8xXSBJbXByb3ZlIHRhciBwb3J0YWJpbGl0eSBsb2dpYyBmcm9tIGViYmE2NGMwLgoKKiBHTlUg
YW5kIEJTRCB0YXIgYm90aCB1bmRlcnN0YW5kIC0tZm9ybWF0PXVzdGFyLgoqIFdpbmRvd3MgbGFj
a3MgL2Rldi9udWxsLCBidXQgcGVybCBrbm93cyBpdHMgbG9jYWwgbmFtZS4KKiB1c3RhciBmb3Jt
YXQgZG9lc24ndCBsaWtlIGxhcmdlIFVJRC9HSUQgdmFsdWVzLCBzbyBzZXQgdGhlbSB0byAwLgoq
IE9wZW5CU0QgaGFzIGl0cyBvd24gdGFyIHdoaWNoIHVuZGVyc3RhbmRzIC1GIHVzdGFyLgoKQmFj
a3BhdGNoLXRocm91Z2g6IDE4CkNvLWF1dGhvcmVkLWJ5OiBUaG9tYXMgTXVucm8gPHRob21hcy5t
dW5yb0BnbWFpbC5jb20+CkNvLWF1dGhvcmVkLWJ5OiBTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdt
YWlsLmNvbT4KUmV2aWV3ZWQtYnk6IFRvbSBMYW5lIDx0Z2xAc3NzLnBnaC5wYS51cz4KUmV2aWV3
ZWQtYnk6IE5hemlyIEJpbGFsIFlhdnV6IDxieWF2dXo4MUBnbWFpbC5jb20+CkRpc2N1c3Npb246
IGh0dHBzOi8vcG9zdGdyLmVzL20vMzY3NjIyOS4xNzc1MTcwMjUwJTQwc3NzLnBnaC5wYS51cwpE
aXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL0NBQTVSWjB0dDg5TWdOaTQtMEY0b25IJTJC
LVRGU3N5c0ZqTU0tdEJjNmFYYnVRdjV4Qlh3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdGVz
dC9wZXJsL1Bvc3RncmVTUUwvVGVzdC9VdGlscy5wbSB8IDIxICsrKysrKysrKysrKy0tLS0tLS0t
LQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZm
IC0tZ2l0IGEvc3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvVXRpbHMucG0gYi9zcmMvdGVz
dC9wZXJsL1Bvc3RncmVTUUwvVGVzdC9VdGlscy5wbQppbmRleCAxMjA5OTlmNmFjOS4uMDUwMDM3
ZjBkOTMgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L1V0aWxzLnBt
CisrKyBiL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L1V0aWxzLnBtCkBAIC0xMzI4LDIx
ICsxMzI4LDI0IEBAIHN1YiB0YXJfcG9ydGFiaWxpdHlfb3B0aW9ucwogCiAJIyBHTlUgdGFyIHR5
cGljYWxseSBwcm9kdWNlcyBnbnUtZm9ybWF0IGFyY2hpdmVzLCB3aGljaCB3ZSBjYW4gcmVhZCBm
aW5lLgogCSMgQnV0IHNvbWUgcGxhdGZvcm1zIGNvbmZpZ3VyZSBpdCB0byBkZWZhdWx0IHRvIHBv
c2l4L3BheCBmb3JtYXQsIGFuZAotCSMgYXBwYXJlbnRseSB0aGV5IGVuYWJsZSAtLXNwYXJzZSB0
b28uICBPdmVycmlkZSB0aGF0LgotCWlmIChzeXN0ZW0oIiR0YXIgLS1mb3JtYXQ9dXN0YXIgLWMg
LU8gL2Rldi9udWxsID4vZGV2L251bGwgMj4vZGV2L251bGwiKQorCSMgYXBwYXJlbnRseSB0aGV5
IGVuYWJsZSAtLXNwYXJzZSB0b28uICBCU0QgdGFyIChsaWJhcmNoaXZlKSBkb2VzIHNvbWV0aGlu
ZworCSMgc2ltaWxhci4KKwkjCisJIyB1c3RhciBmb3JtYXQgc3VwcG9ydHMgVUlEcyBvbmx5IHVw
IHRvIDJeMjEgLSAxICgyMDk3MTUxKS4gIE92ZXJyaWRlCisJIyBvd25lci9ncm91cCB0byBhdm9p
ZCBmYWlsdXJlcyBvbiBzeXN0ZW1zIHdoZXJlIHRoZSBydW5uaW5nIHVzZXIncyBVSUQvR0lECisJ
IyBleGNlZWRzIHRoYXQgbGltaXQuCisJbXkgJGRldm51bGwgPSBGaWxlOjpTcGVjLT5kZXZudWxs
KCk7CisJaWYgKHN5c3RlbSgiJHRhciAtLWZvcm1hdD11c3RhciAtLW93bmVyPTAgLS1ncm91cD0w
IC1jICRkZXZudWxsID4kZGV2bnVsbCAyPiRkZXZudWxsIikKIAkJPT0gMCkKIAl7Ci0JCXB1c2go
QHRhcl9wX2ZsYWdzLCAiLS1mb3JtYXQ9dXN0YXIiKTsKKwkJcHVzaChAdGFyX3BfZmxhZ3MsICIt
LWZvcm1hdD11c3RhciIsICItLW93bmVyPTAiLCAiLS1ncm91cD0wIik7CiAJfQogCi0JIyBic2R0
YXIgYWxzbyBhcmNoaXZlcyBzcGFyc2UgZmlsZXMgYnkgZGVmYXVsdCwgYnV0IGl0IHNwZWxscyB0
aGUgc3dpdGNoCi0JIyB0byBkaXNhYmxlIHRoYXQgZGlmZmVyZW50bHkuCi0JaWYgKHN5c3RlbSgi
JHRhciAtLW5vLXJlYWQtc3BhcnNlIC1jIC0gL2Rldi9udWxsID4vZGV2L251bGwgMj4vZGV2L251
bGwiKQotCQk9PSAwKQorCSMgT3BlbkJTRCdzIHRhciBhbHNvIGRlZmF1bHRzIHRvIHBheCwgYnV0
IHNwZWxscyB0aGUgc3dpdGNoIGRpZmZlcmVudGx5LgorCWlmIChzeXN0ZW0oIiR0YXIgLUYgdXN0
YXIgLWMgJGRldm51bGwgPiRkZXZudWxsIDI+JGRldm51bGwiKSkKIAl7Ci0JCXB1c2goQHRhcl9w
X2ZsYWdzLCAiLS1uby1yZWFkLXNwYXJzZSIpOworCQlwdXNoKEB0YXJfcF9mbGFncywgIi1GIiwg
InVzdGFyIik7CiAJfQotCiAJcmV0dXJuIEB0YXJfcF9mbGFnczsKIH0KIAotLSAKMi41MC4xCgo=
--00000000000088ef91064e8f90b7--