MIME-Version: 1.0
From: Sami Imseih <samimseih@gmail.com>
Date: Thu, 26 Mar 2026 13:34:38 -0500
Message-ID: 
 <CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr=kfK3O9FMLrEy1zPOkg@mail.gmail.com>
Subject: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000c70f5b064df1a303"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr%3DkfK3O9FMLrEy1zPOkg%40mail.gmail.com>
Precedence: bulk

--000000000000c70f5b064df1a303
Content-Type: text/plain; charset="UTF-8"

Hi,

While looking at something nearby, I noticed a naming inconsistency
for the parameter
name in LWLockNewTrancheId(). It should be tranche_name, similar to
RequestNamedLWLockTranche(), and in other places it's referenced in
the docs/comments.

CC'ng Nathan who committed 38b602b0289fe1d where this was introduced.

--
Sami Imseih
Amazon Web Services (AWS)

--000000000000c70f5b064df1a303
Content-Type: application/octet-stream;
	name="v1-0001-Rename-LWLockNewTrancheId-parameter-from-name-to-.patch"
Content-Disposition: attachment;
	filename="v1-0001-Rename-LWLockNewTrancheId-parameter-from-name-to-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn7t7w5n0>
X-Attachment-Id: f_mn7t7w5n0

RnJvbSAzMjNkODU2MTBkY2JjY2YwMDAyOGI5NjU0ZDRjYmE5MGYzYWU2OWEzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdtYWlsLmNvbT4KRGF0
ZTogVGh1LCAyNiBNYXIgMjAyNiAxODoyNzo1MCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjEgMS8x
XSBSZW5hbWUgTFdMb2NrTmV3VHJhbmNoZUlkKCkgcGFyYW1ldGVyIGZyb20gIm5hbWUiIHRvCiAi
dHJhbmNoZV9uYW1lIgoKVGhpcyBtYWtlcyB0aGUgcGFyYW1ldGVyIG5hbWluZyBjb25zaXN0ZW50
IHdpdGggR2V0TmFtZWRMV0xvY2tUcmFuY2hlKCksCndoaWNoIGFscmVhZHkgdXNlcyAidHJhbmNo
ZV9uYW1lIi4gIFVwZGF0ZSB0aGUgZnVuY3Rpb24gc2lnbmF0dXJlIGluIHRoZQpoZWFkZXIsIHRo
ZSBpbXBsZW1lbnRhdGlvbiBpbiBsd2xvY2suYywgYW5kIHRoZSBkb2N1bWVudGF0aW9uIGluCnhm
dW5jLnNnbWwgdG8gbWF0Y2guCi0tLQogZG9jL3NyYy9zZ21sL3hmdW5jLnNnbWwgICAgICAgICAg
IHwgMiArLQogc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2x3bG9jay5jIHwgOCArKysrLS0tLQog
c3JjL2luY2x1ZGUvc3RvcmFnZS9sd2xvY2suaCAgICAgIHwgMiArLQogMyBmaWxlcyBjaGFuZ2Vk
LCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9z
Z21sL3hmdW5jLnNnbWwgYi9kb2Mvc3JjL3NnbWwveGZ1bmMuc2dtbAppbmRleCA3MGU4MTViOGEy
Yy4uNmQ0NjRkNGQ3Y2YgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC94ZnVuYy5zZ21sCisrKyBi
L2RvYy9zcmMvc2dtbC94ZnVuYy5zZ21sCkBAIC0zNzY1LDcgKzM3NjUsNyBAQCBMV0xvY2tQYWRk
ZWQgKkdldE5hbWVkTFdMb2NrVHJhbmNoZShjb25zdCBjaGFyICp0cmFuY2hlX25hbWUpCiAgICAg
ICA8bGl0ZXJhbD5zaG1lbV9yZXF1ZXN0X2hvb2s8L2xpdGVyYWw+LiAgVG8gZG8gc28sIGZpcnN0
IGFsbG9jYXRlIGEKICAgICAgIDxsaXRlcmFsPnRyYW5jaGVfaWQ8L2xpdGVyYWw+IGJ5IGNhbGxp
bmc6CiA8cHJvZ3JhbWxpc3Rpbmc+Ci1pbnQgTFdMb2NrTmV3VHJhbmNoZUlkKGNvbnN0IGNoYXIg
Km5hbWUpCitpbnQgTFdMb2NrTmV3VHJhbmNoZUlkKGNvbnN0IGNoYXIgKnRyYW5jaGVfbmFtZSkK
IDwvcHJvZ3JhbWxpc3Rpbmc+CiAgICAgICBOZXh0LCBpbml0aWFsaXplIGVhY2ggTFdMb2NrLCBw
YXNzaW5nIHRoZSBuZXcKICAgICAgIDxsaXRlcmFsPnRyYW5jaGVfaWQ8L2xpdGVyYWw+IGFzIGFu
IGFyZ3VtZW50OgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2x3bG9jay5j
IGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2x3bG9jay5jCmluZGV4IDQ5MzgyZGU4OGZjLi5k
OTM0ZmY0MGY3MSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2x3bG9jay5j
CisrKyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9sd2xvY2suYwpAQCAtNTk0LDE2ICs1OTQs
MTYgQEAgR2V0TmFtZWRMV0xvY2tUcmFuY2hlKGNvbnN0IGNoYXIgKnRyYW5jaGVfbmFtZSkKICAq
IEFsbG9jYXRlIGEgbmV3IHRyYW5jaGUgSUQgd2l0aCB0aGUgcHJvdmlkZWQgbmFtZS4KICAqLwog
aW50Ci1MV0xvY2tOZXdUcmFuY2hlSWQoY29uc3QgY2hhciAqbmFtZSkKK0xXTG9ja05ld1RyYW5j
aGVJZChjb25zdCBjaGFyICp0cmFuY2hlX25hbWUpCiB7CiAJaW50CQkJcmVzdWx0OwogCi0JaWYg
KCFuYW1lKQorCWlmICghdHJhbmNoZV9uYW1lKQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJj
b2RlKEVSUkNPREVfSU5WQUxJRF9OQU1FKSwKIAkJCQkgZXJybXNnKCJ0cmFuY2hlIG5hbWUgY2Fu
bm90IGJlIE5VTEwiKSkpOwogCi0JaWYgKHN0cmxlbihuYW1lKSA+PSBOQU1FREFUQUxFTikKKwlp
ZiAoc3RybGVuKHRyYW5jaGVfbmFtZSkgPj0gTkFNRURBVEFMRU4pCiAJCWVyZXBvcnQoRVJST1Is
CiAJCQkJKGVycmNvZGUoRVJSQ09ERV9OQU1FX1RPT19MT05HKSwKIAkJCQkgZXJybXNnKCJ0cmFu
Y2hlIG5hbWUgdG9vIGxvbmciKSwKQEAgLTYyNyw3ICs2MjcsNyBAQCBMV0xvY2tOZXdUcmFuY2hl
SWQoY29uc3QgY2hhciAqbmFtZSkKIAogCXJlc3VsdCA9ICgqTFdMb2NrQ291bnRlcikrKzsKIAlM
b2NhbExXTG9ja0NvdW50ZXIgPSAqTFdMb2NrQ291bnRlcjsKLQlzdHJsY3B5KExXTG9ja1RyYW5j
aGVOYW1lc1tyZXN1bHQgLSBMV1RSQU5DSEVfRklSU1RfVVNFUl9ERUZJTkVEXSwgbmFtZSwgTkFN
RURBVEFMRU4pOworCXN0cmxjcHkoTFdMb2NrVHJhbmNoZU5hbWVzW3Jlc3VsdCAtIExXVFJBTkNI
RV9GSVJTVF9VU0VSX0RFRklORURdLCB0cmFuY2hlX25hbWUsIE5BTUVEQVRBTEVOKTsKIAogCVNw
aW5Mb2NrUmVsZWFzZShTaG1lbUxvY2spOwogCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9zdG9y
YWdlL2x3bG9jay5oIGIvc3JjL2luY2x1ZGUvc3RvcmFnZS9sd2xvY2suaAppbmRleCA5YTAyOTAz
OTFkMC4uZGQ1MTQyYzEwZDAgMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL3N0b3JhZ2UvbHdsb2Nr
LmgKKysrIGIvc3JjL2luY2x1ZGUvc3RvcmFnZS9sd2xvY2suaApAQCAtMTU1LDcgKzE1NSw3IEBA
IGV4dGVybiBMV0xvY2tQYWRkZWQgKkdldE5hbWVkTFdMb2NrVHJhbmNoZShjb25zdCBjaGFyICp0
cmFuY2hlX25hbWUpOwogICogY291bnRlci4gIFNlY29uZCwgTFdMb2NrSW5pdGlhbGl6ZSBzaG91
bGQgYmUgY2FsbGVkIGp1c3Qgb25jZSBwZXIgbHdsb2NrLAogICogcGFzc2luZyB0aGUgdHJhbmNo
ZSBJRCBhcyBhbiBhcmd1bWVudC4KICAqLwotZXh0ZXJuIGludAlMV0xvY2tOZXdUcmFuY2hlSWQo
Y29uc3QgY2hhciAqbmFtZSk7CitleHRlcm4gaW50CUxXTG9ja05ld1RyYW5jaGVJZChjb25zdCBj
aGFyICp0cmFuY2hlX25hbWUpOwogZXh0ZXJuIHZvaWQgTFdMb2NrSW5pdGlhbGl6ZShMV0xvY2sg
KmxvY2ssIGludCB0cmFuY2hlX2lkKTsKIAogLyoKLS0gCjIuNDcuMwoK
--000000000000c70f5b064df1a303--