Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vUbKS-000Lxa-0F for pgsql-hackers@arkaria.postgresql.org; Sun, 14 Dec 2025 01:55:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vUbKR-00C43e-01 for pgsql-hackers@arkaria.postgresql.org; Sun, 14 Dec 2025 01:55:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vUbKQ-00C43V-2K for pgsql-hackers@lists.postgresql.org; Sun, 14 Dec 2025 01:55:19 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vUbKP-000YOq-2Y for pgsql-hackers@lists.postgresql.org; Sun, 14 Dec 2025 01:55:18 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-6495c4577adso3344224a12.3 for ; Sat, 13 Dec 2025 17:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765677316; x=1766282116; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=j5vwUZD3vtcpo56XYkabUgRCyxzGGtvunDvltxWdenQ=; b=kB1F77OpwqnWI22aIUlTCBcRctpxJJr9mdQiMv2U60RTUekMPVNUxLtlayA1mZqg81 epyOx+J6qFBSuXZZhjrYQxstfd18lDRtdRGpmnrUtZlilLIgHBZVTB13uFndGdnAriSW NVv2mCz6V/5SzuFh6NJUaKbs7EQUAs8ygVzIfbJxgmwn5VsKAlk46oybcWliMOrP8CWA FLXRwf6ChOgpNpdE0+uhlP+rvFUSgtuxh4i4BPAs5g0mv6krknfTHGllYOMyye20JRwr VvmgBoWu/ir2h7Seocz0Z7MxAb7KqOhFls6B8TUVZcOPlqpffUO4fZYS0k20Gj7vITRC 3qbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765677316; x=1766282116; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j5vwUZD3vtcpo56XYkabUgRCyxzGGtvunDvltxWdenQ=; b=MYC92ZoLi4kYJCYaPr5psqs9qpJip44xiEpD7PoV8iBQjFrSmHEM4xC7iJ+ZwfGtDs RlzJXQiuPTMVOcslNDlceiREZHn9g+E8M66vIHMK6HEP7XQOAhb0r8xHqfzUz1OAlavU q+8bvQRjO/aSwm1/zFaFej0hG9z1SPf0rdysspSko4Q5c39yT6J/XNR+/yQsav9lkAUg yC0npSAc6WPFnuDJiPlZ39a9GKOtXN42Gv7FaAmWMI8vym43FLAnB+tyFsNV80VGJjKV eYQ46jDvpAwDmwBsy2fRvD55G3ZIfdvsM3RFBxShIeBPo39YdhyZ2dIB9RqENOtlQoQ6 TmOA== X-Forwarded-Encrypted: i=1; AJvYcCWpJG7nVXisqxGj0QyC+uiLAWyVZ2kJAjj9BLtdf0mybQJPFZx7IwpcFXm54+4M3U6S7asIwVEPKI/2eJLQ@lists.postgresql.org X-Gm-Message-State: AOJu0Yzt55sUr7dyDl70eFtQsrpDNLttzHB+E4n2s41SJFwYp43YHgxT c8m60jNv1c18HcY4QERPVeUq9+CQlnmhQxanJTYIYfPrstNL3/nxdhPgabsyt9OBOhi1RCSwm1c vwfETYzAaF4DkmS64M7/e8Qercn33Wrk= X-Gm-Gg: AY/fxX7R4DYtIh2HaBpoDgOsONd9ecjj5zsvzBuUhRx6gS5oJkzjnv5sNO5/kPFdLTu AuIO4G2drCPBztmguCDb/UJ2XjiZnlZrNmqGzjoSQuh8owToGES3E9dPNQtz+1rtYxe2eDWbaMm HGgWE/WNLq6TuGd66jzY40cvPFjfPaEiWvxJIxXhxBwULMam+R1YN5GT1TQ7LNKOJjD2lW5loq+ gYzE6MeMSf0QcMAKdeaa97hLFLMgOewvKigpDMB82ig+NExZfnAwnWNz4TgCiAXzkaIHQ== X-Google-Smtp-Source: AGHT+IGBoI4nG2bRFkH1djhiKLVyhoaXRE+myzgFpOUTiGny7evftUA+ze/ZdJ8jxjktZ1jN6xBWrzofIC/tS1DwlEw= X-Received: by 2002:a17:907:9496:b0:b71:854:4e49 with SMTP id a640c23a62f3a-b7d23d042e7mr796253766b.56.1765677315822; Sat, 13 Dec 2025 17:55:15 -0800 (PST) MIME-Version: 1.0 References: <9252DA7C-C611-4A93-A484-E6CD42557C15@gmail.com> <4E61FDC4-CFBB-4116-980F-75ADD245A1F6@gmail.com> In-Reply-To: From: Sami Imseih Date: Sat, 13 Dec 2025 19:55:04 -0600 X-Gm-Features: AQt7F2revWVC9MC08_4N4dvyeknUq4Ai25bWT9ntxrP_5udRL_SJY5iQJFYeH_c Message-ID: Subject: Re: [Proposal] Adding callback support for custom statistics kinds To: Michael Paquier Cc: Chao Li , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > I just remembered that we should document the new callbacks in [0] with a > brief explanation of their purpose and a reference to test_custom_stats > as an example of usage. What do you think? oh, and I also realized that the documentation was updated incorrectly when test_custom_stats was originally committed. Thought it was better to fix this in a separate thread [0]. [0] https://www.postgresql.org/message-id/CAA5RZ0s4heX926+ZNh63u12gLd9jgauU6yiirKc7xGo1G01PXQ@mail.gmail.com -- Sami Imseih Amazon Web Services (AWS)