Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5qT2-003gem-27 for pgsql-hackers@arkaria.postgresql.org; Thu, 26 Mar 2026 19:34:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w5qT1-005201-0d for pgsql-hackers@arkaria.postgresql.org; Thu, 26 Mar 2026 19:34:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5qT0-0051zs-2u for pgsql-hackers@lists.postgresql.org; Thu, 26 Mar 2026 19:34:07 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w5qSy-00000001LGc-3mWI for pgsql-hackers@postgresql.org; Thu, 26 Mar 2026 19:34:07 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-66a82351490so2407963a12.0 for ; Thu, 26 Mar 2026 12:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774553644; cv=none; d=google.com; s=arc-20240605; b=XDvyuiOxoHrgwg5vzAx+qXcn7H1lMJoD7L+Mcytzae8JnpfGLtiI//7qcoSMOdtk4d ivEMWzpLvsiT+XedS5J8e+kxPSTEurWVeOACdVRPYNeeAOrjS+u9qq4cq36PCi0dx5Fv RWnVEABia1vG70jxNQDoMoWV3aAhNy1fo/cRsolGmNVWJ0h3HlhVxQHQrdGcbTZ9rMo9 9jNYnMbTjzn10zP2n1O/elS0AqHBIPxVROPLpUBbGjSq4SCzWeztZmir3i7OeMZCRY9m hH+JLRQH2zCf41kSvbW1L6Im3azGtmi/4X6y2Oq2BAVe5oFvav8nMK6EvkBEv/L7VLSv VPTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=pm/GNFEw04ev5VNh7WVG9osmAuz/lA6d7UD77hwyM1U=; fh=ReW5NhSMRBwYC5E2yHyYz7axav+wsgzfI/JdtfPZtWk=; b=bZWBOzkLXjtYGMzAvh3J5yNv5b5HIEN4JPEPai34yJBcYt69GMc35rKeZ5Akfates7 ra9z2zqbVymR9x4fRTKPYxkzR0Gc46YgF+EY7lVx94FAkTFKfLfcAmPI/sGRILuuH12n z/iF/bvHi8LrfZTemhwk90Ad2vIp1bg5Yue6kU2uGkbTW+zcEWzBMb2ZRqY0NpIT2wt9 z4StbpwUstFrgk8mcLl1LCj7VN4GuMNTHdpW+ioMWKYR/M3Po6G0wydx2+kSHpkvmTVY clWnQEg2YhnQEFuSemAaHNeoGu8la2bxHUe/eA7rAmdokVEHZvyIsbw6gptyvifZe16z 83cg==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774553644; x=1775158444; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pm/GNFEw04ev5VNh7WVG9osmAuz/lA6d7UD77hwyM1U=; b=U+JTBuBwJuiYBBzJAFzHgHP4+Y1qygYRZ3FLFMGjdX2xd2HiSdFI8+/SZ5oACY15dY Xdbc0A0bYOB55O1WbDQ5MtOjnR0jQFpg0UOR1aOySuLipbgsRV7FFqPpuwgVMTeh1I3A VU+qQvtDJe9L97cLce8wgvuDm6e37hTc9++u3X3n2psIBAM6B7N3EpK+6P/VvPlceVqD Fz+xiLmV0Uw1+ThowvxOuXxfDf6L0K/qa12O0020MkBSRLJncn2Blf9KXtJ53XrtMYf6 M0Zvgi7Grv8oqiUMR9b2TbIRVGY1og+FoN7K9ZKbOKp/V7onYYIQjO8U0G+8VoMbCXH5 D0yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774553644; x=1775158444; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pm/GNFEw04ev5VNh7WVG9osmAuz/lA6d7UD77hwyM1U=; b=FuVxxckriz7zD5AifRG7ZWIJ2CZZsNVuvUgz4ochXKuiWC2/+/ib2idRXOLbMooqSh fJw1pDhgFZ6hBGp1owTAFHFzuT2AeA3rTVFUmRTDab0fKFK712xavw5xJVDwvxXA0L59 BwipY603Ybok51CkLQ8bwz9iPuGVYEn4EUK90SPs9hmp1OPAyKCPDcASDmM39ODF5pZN i4tHq1e363nYceiC8OHyqGwd+xSN2qqUP+QheKPoIVmVFg+hmd7vEbHlgnpKN6GB6uGV MlGptGkFxvpowjXtKB24n4YSd79dPi2J9DWIWtTbMc6rcD6Oy1qRvM0cmKwSOCe4QP6M S6+g== X-Gm-Message-State: AOJu0Yy7mTPP4mytMfSR2A1fqZGfRHnq8ecDqHt+id3EAbGWvNAI8/XN 6zXgtwjaZljV1vWGFFElRx2d7DggDu59rdhgeJe3xHdWxfczFptk0TNkkTulPvGVrdSILC9k0zo 5W9UalgHEBBNe/V+UynTqtTyXATswThE= X-Gm-Gg: ATEYQzwP0R1+29CyVMbc/X4zIwi3DKrBZwJJEntsZUG5gadYZpbLU+xZ6N9B/3ZsTm6 bUh9Vc8y8XCAOARIvvu5CaiGLLXwcsYJdGVYlvHvteIcpSsko0L29nXMoFY7TBnor8o5hAjRkDw XCYF7T1Jv8f3P2UdbNZHvJJXec7K/8l7QbS0m6aus53LcT5EJs33VoxiNXnsX4CrvA4DCkbXL6I UkT8lXkFcCg3zphj9q5MvCMtZLfopHTLye0P1O4+w7mT54qqTNweXJkgxXmn9KPW0QPEeAuyoy2 4c773A== X-Received: by 2002:a05:6402:1451:b0:665:2676:7ec4 with SMTP id 4fb4d7f45d1cf-66b07ed98dcmr1967410a12.9.1774553643540; Thu, 26 Mar 2026 12:34:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sami Imseih Date: Thu, 26 Mar 2026 14:33:52 -0500 X-Gm-Features: AQROBzA_45aidPP9wuUq8__PfoiRoeIoZVSxfjt9EEkqTuc_rnQh0waHI41cgps Message-ID: Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name" To: Nathan Bossart Cc: pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > > While looking at something nearby, I noticed a naming inconsistency for > > the parameter name in LWLockNewTrancheId(). It should be tranche_name, > > similar to RequestNamedLWLockTranche(), and in other places it's > > referenced in the docs/comments. > > I don't mind changing it, but I don't find "tranche_name" to be > substantially better than "name" in this case. It's just a matter of consistency and it's more descriptive to the caller, IMO. -- Sami Imseih Amazon Web Services (AWS)