MIME-Version: 1.0
References: 
 <CAA5RZ0vxby2osMMaCuZ=680tmt583cF9n4rOzTGdsiS-1PJknA@mail.gmail.com>
 <adE9RbcA7lhH_w2d@nathan>
 <CAA5RZ0tYzPDeXbqz9uKacRV2xjD055qrg=s3w2PEQPK8EruuSg@mail.gmail.com>
 <adFiCgN22xJ7Z-oR@nathan>
 <CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com>
 <adQsdvPPNviWMCXb@nathan> <5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com>
 <3077290.1775668665@sss.pgh.pa.us> <adaWuTR7oCKodH7k@nathan>
 <3097984.1775674400@sss.pgh.pa.us> <adan_E0o69p81lIj@nathan>
 <3101163.1775676098@sss.pgh.pa.us>
In-Reply-To: <3101163.1775676098@sss.pgh.pa.us>
From: Sami Imseih <samimseih@gmail.com>
Date: Wed, 8 Apr 2026 14:35:29 -0500
Message-ID: 
 <CAA5RZ0uOENy8Y+UNXpcGvFFHhT_oxYPqa-o0Jv1rOriC6w8VSg@mail.gmail.com>
Subject: Re: Add pg_stat_autovacuum_priority
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Alexander Lakhin <exclusion@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Robert Treat <rob@xzilla.net>,
	satyanarlapuram@gmail.com, pgsql-hackers <pgsql-hackers@postgresql.org>,
	tndrwang@gmail.com
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0uOENy8Y%2BUNXpcGvFFHhT_oxYPqa-o0Jv1rOriC6w8VSg%40mail.gmail.com>
Precedence: bulk

> > This sounds most similar to the "bool *may_free" idea that Andres just
> > posted.  IIUC the idea is that callers can free the result if they want,
> > but they aren't required to do so.
>
> Hmm, yeah I suppose a caller that doesn't care about leakage could
> skip the pfree.  But are there really any of those?  The complaint
> that prompted 02502c1bc concerned databases with many many thousands
> of relations.
>
> I now realize that what you said upthread about caching the results
> might be a bigger problem, ie if the pgstats code does retain all
> these values then we'd have a memory bloat problem there.  Maybe
> we need a more aggressive API change that includes a way to specify
> "don't cache this result".

hmm, do you mean an API to override the pgstat_fetch_consistency GUC?

--
Sami