MIME-Version: 1.0
References: 
 <CAA5RZ0s+kZZRMSF4HW7tZ9W2jS1o4B+Fg8dr5a-T6mANX+mdQA@mail.gmail.com>
 <525d0f48-93f7-493f-a988-f39b460a79bc@gmail.com>
 <CAD21AoCj=OSxoh3RBw0VWJ7Y7c9EipRhpatcZaHuXKGLWyKgdQ@mail.gmail.com>
 <CAA5RZ0uqvjxv5HPzz36UEq-LUf8F+kae61k0imaGw0C0XGa7nw@mail.gmail.com>
 <CAD21AoBte7CSVRpnOvXibYPsqOE9aswsp7jrQW+8fhwxRZFWpg@mail.gmail.com>
In-Reply-To: 
 <CAD21AoBte7CSVRpnOvXibYPsqOE9aswsp7jrQW+8fhwxRZFWpg@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Thu, 9 Apr 2026 15:14:15 -0500
Message-ID: 
 <CAA5RZ0uOSnAKX4xF0PBSZqYCxUMTnheAKkcsiQDNYTZg20ognQ@mail.gmail.com>
Subject: Re: test_autovacuum/001_parallel_autovacuum is broken
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
	Daniil Davydov <3danissimo@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000d82c6a064f0ca987"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0uOSnAKX4xF0PBSZqYCxUMTnheAKkcsiQDNYTZg20ognQ%40mail.gmail.com>
Precedence: bulk

--000000000000d82c6a064f0ca987
Content-Type: text/plain; charset="UTF-8"

> Optionally, we can change the comment above to something like this:
> # Wait until the parallel autovacuum on the table completes and reports the
> # number of launched workers, which must correspond to the value specified in
> # the reloption.

Made the comment less verbose but in the same spirit as the above.


> > > One way to fix the test is to replace log_contains() with
> > > wait_for_log(). We can also remove wait_for_autovacuum_complete()
> > > logic altogether.
> >
> > +1. I was going to reply with exactly this. Attached is the fix.
>
> Thank you for the patch! I agree with the overall idea. Since we
> enable autovacuum log only the test_autovac table, just checking
> autovacuum log works as expected.
>
> I think we can simplify the test further by removing the logic around
> the av_count variable.

removed av_count and pg_stat_user_tables query, but hardened the
regexp a bit to ensure that the parallel logging is for the test_autovac
table. It gives the same assurance as counting pg_stat_user_tables
and will be better if we add another parallel test table in the future.

--
Sami

--000000000000d82c6a064f0ca987
Content-Type: application/octet-stream;
	name="v2-0001-Fix-unstable-log_contains-in-parallel-autovacuum-.patch"
Content-Disposition: attachment;
	filename="v2-0001-Fix-unstable-log_contains-in-parallel-autovacuum-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnrx0rc90>
X-Attachment-Id: f_mnrx0rc90

RnJvbSBkZmQwMTFiNDVhODg4MDEwNDM3MmQ3ZjI0ZjRlODVhMjcyNTJlZDE3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdtYWlsLmNvbT4KRGF0
ZTogVGh1LCA5IEFwciAyMDI2IDIwOjA2OjAwICswMDAwClN1YmplY3Q6IFtQQVRDSCB2MiAxLzFd
IEZpeCB1bnN0YWJsZSBsb2dfY29udGFpbnMgaW4gcGFyYWxsZWwgYXV0b3ZhY3V1bSB0ZXN0cwoK
UmVwbGFjZSBsb2dfY29udGFpbnMgd2l0aCB3YWl0X2Zvcl9sb2cgaW4gdGhlIHBhcmFsbGVsIGF1
dG92YWN1dW0KdGVzdCB0byBlbnN1cmUgd2Ugd2FpdCBmb3IgdGhlIGxvZyBjb250YWluaW5nIHBh
cmFsbGVsIHZhY3V1bSBpbmZvLgpSZW1vdmUgd2FpdF9mb3JfYXV0b3ZhY3V1bV9jb21wbGV0ZSBh
cyB0aGUgbG9nIHdhaXQgaXMgc3VmZmljaWVudAp0byBkZXRlcm1pbmUgdmFjdXVtIGNvbXBsZXRp
b24uIFRoZSBxdWVyeSB0byBwZ19zdGF0X3VzZXJfdGFibGVzCmZvciB2YWN1dW0gY291bnQgaXMg
YWxzbyBubyBsb25nZXIgbmVlZGVkIHNpbmNlIHdlIG5vdyBlbnN1cmUgdGhlCnBhcmFsbGVsIGxv
Z2dpbmcgaXMgYXNzb2NpYXRlZCB3aXRoIHRoZSB0ZXN0IHRhYmxlLgotLS0KIC4uLi90LzAwMV9w
YXJhbGxlbF9hdXRvdmFjdXVtLnBsICAgICAgICAgICAgICB8IDMzICsrKystLS0tLS0tLS0tLS0t
LS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9hdXRvdmFjdXVtL3QvMDAxX3BhcmFsbGVs
X2F1dG92YWN1dW0ucGwgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfYXV0b3ZhY3V1bS90LzAwMV9w
YXJhbGxlbF9hdXRvdmFjdXVtLnBsCmluZGV4IGZjNGRkMjJmNWViLi4yMDZjOTVmOTE1NyAxMDA2
NDQKLS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X2F1dG92YWN1dW0vdC8wMDFfcGFyYWxsZWxf
YXV0b3ZhY3V1bS5wbAorKysgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfYXV0b3ZhY3V1bS90LzAw
MV9wYXJhbGxlbF9hdXRvdmFjdXVtLnBsCkBAIC0xNSw4ICsxNSw3IEBAIGlmICgkRU5We2VuYWJs
ZV9pbmplY3Rpb25fcG9pbnRzfSBuZSAneWVzJykKIH0KIAogIyBCZWZvcmUgZWFjaCB0ZXN0IHdl
IHNob3VsZCBkaXNhYmxlIGF1dG92YWN1dW0gZm9yICd0ZXN0X2F1dG92YWMnIHRhYmxlIGFuZAot
IyBnZW5lcmF0ZSBzb21lIGRlYWQgdHVwbGVzIGluIGl0LiBSZXR1cm5zIHRoZSBjdXJyZW50IGF1
dG92YWN1dW1fY291bnQgb2YKLSMgdGhlIHRhYmxlIHRlc3RfYXV0b3ZhYy4KKyMgZ2VuZXJhdGUg
c29tZSBkZWFkIHR1cGxlcyBpbiBpdC4KIHN1YiBwcmVwYXJlX2Zvcl9uZXh0X3Rlc3QKIHsKIAlt
eSAoJG5vZGUsICR0ZXN0X251bWJlcikgPSBAXzsKQEAgLTI2LDI0ICsyNSw2IEBAIHN1YiBwcmVw
YXJlX2Zvcl9uZXh0X3Rlc3QKIAkJQUxURVIgVEFCTEUgdGVzdF9hdXRvdmFjIFNFVCAoYXV0b3Zh
Y3V1bV9lbmFibGVkID0gZmFsc2UpOwogCQlVUERBVEUgdGVzdF9hdXRvdmFjIFNFVCBjb2xfMSA9
ICR0ZXN0X251bWJlcjsKIAl9KTsKLQotCW15ICRjb3VudCA9ICRub2RlLT5zYWZlX3BzcWwoCi0J
CSdwb3N0Z3JlcycsIHFxewotCQlTRUxFQ1QgYXV0b3ZhY3V1bV9jb3VudCBGUk9NIHBnX3N0YXRf
dXNlcl90YWJsZXMgV0hFUkUgcmVsbmFtZSA9ICd0ZXN0X2F1dG92YWMnCi0JfSk7Ci0KLQlyZXR1
cm4gJGNvdW50OwotfQotCi0jIFdhaXQgZm9yIHRoZSB0YWJsZSB0byBiZSB2YWN1dW1lZCBieSBh
biBhdXRvdmFjdXVtIHdvcmtlci4KLXN1YiB3YWl0X2Zvcl9hdXRvdmFjdXVtX2NvbXBsZXRlCi17
Ci0JbXkgKCRub2RlLCAkb2xkX2NvdW50KSA9IEBfOwotCi0JJG5vZGUtPnBvbGxfcXVlcnlfdW50
aWwoCi0JCSdwb3N0Z3JlcycsIHFxewotCQlTRUxFQ1QgYXV0b3ZhY3V1bV9jb3VudCA+ICRvbGRf
Y291bnQgRlJPTSBwZ19zdGF0X3VzZXJfdGFibGVzIFdIRVJFIHJlbG5hbWUgPSAndGVzdF9hdXRv
dmFjJwotCX0pOwogfQogCiBteSAkbm9kZSA9IFBvc3RncmVTUUw6OlRlc3Q6OkNsdXN0ZXItPm5l
dygnbWFpbicpOwpAQCAtMTE5LDcgKzEwMCw3IEBAICRub2RlLT5zYWZlX3BzcWwoCiAjIE91ciB0
YWJsZSBoYXMgZW5vdWdoIGluZGV4ZXMgYW5kIGFwcHJvcHJpYXRlIHJlbG9wdGlvbnMsIHNvIGF1
dG92YWN1dW0gbXVzdAogIyBiZSBhYmxlIHRvIHByb2Nlc3MgaXQgaW4gcGFyYWxsZWwgbW9kZS4g
SnVzdCBjaGVjayBpZiBpdCBjYW4gZG8gaXQuCiAKLW15ICRhdl9jb3VudCA9IHByZXBhcmVfZm9y
X25leHRfdGVzdCgkbm9kZSwgMSk7CitwcmVwYXJlX2Zvcl9uZXh0X3Rlc3QoJG5vZGUsIDEpOwog
bXkgJGxvZ19vZmZzZXQgPSAtcyAkbm9kZS0+bG9nZmlsZTsKIAogJG5vZGUtPnNhZmVfcHNxbCgK
QEAgLTEyNywxOCArMTA4LDE2IEBAICRub2RlLT5zYWZlX3BzcWwoCiAJQUxURVIgVEFCTEUgdGVz
dF9hdXRvdmFjIFNFVCAoYXV0b3ZhY3V1bV9lbmFibGVkID0gdHJ1ZSk7CiB9KTsKIAotIyBXYWl0
IHVudGlsIHRoZSBwYXJhbGxlbCBhdXRvdmFjdXVtIG9uIHRhYmxlIGlzIGNvbXBsZXRlZC4gQXQg
dGhlIHNhbWUgdGltZSwKLSMgd2UgY2hlY2sgdGhhdCB0aGUgcmVxdWlyZWQgbnVtYmVyIG9mIHBh
cmFsbGVsIHdvcmtlcnMgaGFzIGJlZW4gc3RhcnRlZC4KLXdhaXRfZm9yX2F1dG92YWN1dW1fY29t
cGxldGUoJG5vZGUsICRhdl9jb3VudCk7Ci1vayggJG5vZGUtPmxvZ19jb250YWlucygKLQkJcXIv
cGFyYWxsZWwgd29ya2VyczogaW5kZXggdmFjdXVtOiAyIHBsYW5uZWQsIDIgbGF1bmNoZWQgaW4g
dG90YWwvLAorIyBXYWl0IGZvciBwYXJhbGxlbCBhdXRvdmFjdXVtIHRvIGNvbXBsZXRlOyBjaGVj
ayB3b3JrZXIgY291bnQgbWF0Y2hlcyByZWxvcHRpb25zLgorb2soICRub2RlLT53YWl0X2Zvcl9s
b2coCisJCXFyL2F1dG9tYXRpYyB2YWN1dW0gb2YgdGFibGUgIi4qP1wuLio/XC50ZXN0X2F1dG92
YWMiOi4qP3BhcmFsbGVsIHdvcmtlcnM6IGluZGV4IHZhY3V1bTogMiBwbGFubmVkLCAyIGxhdW5j
aGVkIGluIHRvdGFsL3MsCiAJCSRsb2dfb2Zmc2V0KSk7CiAKICMgVGVzdCAyOgogIyBDaGVjayB3
aGV0aGVyIHBhcmFsbGVsIGF1dG92YWN1dW0gbGVhZGVyIGNhbiBwcm9wYWdhdGUgY29zdC1iYXNl
ZCBwYXJhbWV0ZXJzCiAjIHRvIHRoZSBwYXJhbGxlbCB3b3JrZXJzLgogCi0kYXZfY291bnQgPSBw
cmVwYXJlX2Zvcl9uZXh0X3Rlc3QoJG5vZGUsIDIpOworcHJlcGFyZV9mb3JfbmV4dF90ZXN0KCRu
b2RlLCAyKTsKICRsb2dfb2Zmc2V0ID0gLXMgJG5vZGUtPmxvZ2ZpbGU7CiAKICRub2RlLT5zYWZl
X3BzcWwoCi0tIAoyLjUwLjEKCg==
--000000000000d82c6a064f0ca987--