MIME-Version: 1.0
References: 
 <CAA5RZ0s4xjMrB-VAnLccC7kY8d0-4806-Lsac-czJsdA1LXtAw@mail.gmail.com>
 <202603301508.up22nvhgnnoj@alvherre.pgsql>
In-Reply-To: <202603301508.up22nvhgnnoj@alvherre.pgsql>
From: Sami Imseih <samimseih@gmail.com>
Date: Mon, 30 Mar 2026 10:32:41 -0500
Message-ID: 
 <CAA5RZ0uqVoixpgBRrge0GZY1Ofeitk3q-Rd4GrJ29W0XpVX2TQ@mail.gmail.com>
Subject: Re: Add pg_stat_autovacuum_priority
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0uqVoixpgBRrge0GZY1Ofeitk3q-Rd4GrJ29W0XpVX2TQ%40mail.gmail.com>
Precedence: bulk

> > 0002 introduces the view with documentation and testing in
> > vacuum.c (xid age and mxid age scores are not tested as
> > they require xid_wraparound to consume enough XIDs to
> > trigger a score, which will cost too much time for a
> > regression test).
>
> After this patch, there are three copies of the combined call to
> pgstat_fetch_stat_tabentry_ext() and relation_needs_vacanalyze().  Can
> we avoid that, ideally reducing to only one such?  Or, at least, it
> looks like recheck_relation_needs_vacanalyze() may no longer need to
> exist at all.

recheck_relation_needs_vacanalyze() can be removed and replace
with compute_autovac_score(). I was trying to minimize refactoring,
but this seems worthwhile to do.

--
Sami