MIME-Version: 1.0
References: 
 <CAA5RZ0s+kZZRMSF4HW7tZ9W2jS1o4B+Fg8dr5a-T6mANX+mdQA@mail.gmail.com>
 <525d0f48-93f7-493f-a988-f39b460a79bc@gmail.com>
 <CAD21AoCj=OSxoh3RBw0VWJ7Y7c9EipRhpatcZaHuXKGLWyKgdQ@mail.gmail.com>
In-Reply-To: 
 <CAD21AoCj=OSxoh3RBw0VWJ7Y7c9EipRhpatcZaHuXKGLWyKgdQ@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Thu, 9 Apr 2026 13:32:33 -0500
Message-ID: 
 <CAA5RZ0uqvjxv5HPzz36UEq-LUf8F+kae61k0imaGw0C0XGa7nw@mail.gmail.com>
Subject: Re: test_autovacuum/001_parallel_autovacuum is broken
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
	Daniil Davydov <3danissimo@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000334111064f0b3e08"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0uqvjxv5HPzz36UEq-LUf8F%2Bkae61k0imaGw0C0XGa7nw%40mail.gmail.com>
Precedence: bulk

--000000000000334111064f0b3e08
Content-Type: text/plain; charset="UTF-8"

> The root cause seems to me that it's not guaranteed that we can see
> the autovacuum logs after checking the statistics (i.e.,
> pg_stat_user_tables) as we update the statistics and then write the
> log.
>
> One way to fix the test is to replace log_contains() with
> wait_for_log(). We can also remove wait_for_autovacuum_complete()
> logic altogether.

+1. I was going to reply with exactly this. Attached is the fix.

--
Sami

--000000000000334111064f0b3e08
Content-Type: application/octet-stream;
	name="v1-0001-Fix-unstable-log_contains-in-parallel-autovacuum-.patch"
Content-Disposition: attachment;
	filename="v1-0001-Fix-unstable-log_contains-in-parallel-autovacuum-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnrtdnwp0>
X-Attachment-Id: f_mnrtdnwp0

RnJvbSBiYjlhOWZmNDY3OGEzYjA0ZDA0MDcyOWZiMTllNjU3M2FhOGVkYzViIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdtYWlsLmNvbT4KRGF0
ZTogVGh1LCA5IEFwciAyMDI2IDE4OjI5OjA1ICswMDAwClN1YmplY3Q6IFtQQVRDSCB2MSAxLzFd
IEZpeCB1bnN0YWJsZSBsb2dfY29udGFpbnMgaW4gcGFyYWxsZWwgYXV0b3ZhY3V1bSB0ZXN0cwoK
UmVwbGFjZSBjaGVja19mb3JfbG9nIHdpdGggd2FpdF9mb3JfbG9nIGluIHRoZSBwYXJhbGxlbAph
dXRvdmFjdXVtIHRlc3QgdG8gZm9yY2UgaXQgdG8gd2FpdCBmb3IgdGhlIGxvZyBjb250YWluaW5n
CnRoZSBwYXJhbGxlbCB2YWN1dW0gaW5mby4gQWxzbyByZW1vdmUgd2FpdF9mb3JfYXV0b3ZhY3V1
bV9jb21wbGV0ZQphcyB0aGUgd2FpdCBmb3IgbG9nIGlzIHN1ZmZpY2llbnQgdG8gZGV0ZXJtaW5l
IGlmIHRoZQp2YWN1dW0gY29tcGxldGVkLgotLS0KIC4uLi90ZXN0X2F1dG92YWN1dW0vdC8wMDFf
cGFyYWxsZWxfYXV0b3ZhY3V1bS5wbCAgIHwgMTQgKy0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFu
Z2VkLCAxIGluc2VydGlvbigrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rl
c3QvbW9kdWxlcy90ZXN0X2F1dG92YWN1dW0vdC8wMDFfcGFyYWxsZWxfYXV0b3ZhY3V1bS5wbCBi
L3NyYy90ZXN0L21vZHVsZXMvdGVzdF9hdXRvdmFjdXVtL3QvMDAxX3BhcmFsbGVsX2F1dG92YWN1
dW0ucGwKaW5kZXggZmM0ZGQyMmY1ZWIuLjU2ZWYxYWY3ZDA4IDEwMDY0NAotLS0gYS9zcmMvdGVz
dC9tb2R1bGVzL3Rlc3RfYXV0b3ZhY3V1bS90LzAwMV9wYXJhbGxlbF9hdXRvdmFjdXVtLnBsCisr
KyBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9hdXRvdmFjdXVtL3QvMDAxX3BhcmFsbGVsX2F1dG92
YWN1dW0ucGwKQEAgLTM1LDE3ICszNSw2IEBAIHN1YiBwcmVwYXJlX2Zvcl9uZXh0X3Rlc3QKIAly
ZXR1cm4gJGNvdW50OwogfQogCi0jIFdhaXQgZm9yIHRoZSB0YWJsZSB0byBiZSB2YWN1dW1lZCBi
eSBhbiBhdXRvdmFjdXVtIHdvcmtlci4KLXN1YiB3YWl0X2Zvcl9hdXRvdmFjdXVtX2NvbXBsZXRl
Ci17Ci0JbXkgKCRub2RlLCAkb2xkX2NvdW50KSA9IEBfOwotCi0JJG5vZGUtPnBvbGxfcXVlcnlf
dW50aWwoCi0JCSdwb3N0Z3JlcycsIHFxewotCQlTRUxFQ1QgYXV0b3ZhY3V1bV9jb3VudCA+ICRv
bGRfY291bnQgRlJPTSBwZ19zdGF0X3VzZXJfdGFibGVzIFdIRVJFIHJlbG5hbWUgPSAndGVzdF9h
dXRvdmFjJwotCX0pOwotfQotCiBteSAkbm9kZSA9IFBvc3RncmVTUUw6OlRlc3Q6OkNsdXN0ZXIt
Pm5ldygnbWFpbicpOwogJG5vZGUtPmluaXQ7CiAKQEAgLTEyOSw4ICsxMTgsNyBAQCAkbm9kZS0+
c2FmZV9wc3FsKAogCiAjIFdhaXQgdW50aWwgdGhlIHBhcmFsbGVsIGF1dG92YWN1dW0gb24gdGFi
bGUgaXMgY29tcGxldGVkLiBBdCB0aGUgc2FtZSB0aW1lLAogIyB3ZSBjaGVjayB0aGF0IHRoZSBy
ZXF1aXJlZCBudW1iZXIgb2YgcGFyYWxsZWwgd29ya2VycyBoYXMgYmVlbiBzdGFydGVkLgotd2Fp
dF9mb3JfYXV0b3ZhY3V1bV9jb21wbGV0ZSgkbm9kZSwgJGF2X2NvdW50KTsKLW9rKCAkbm9kZS0+
bG9nX2NvbnRhaW5zKAorb2soICRub2RlLT53YWl0X2Zvcl9sb2coCiAJCXFyL3BhcmFsbGVsIHdv
cmtlcnM6IGluZGV4IHZhY3V1bTogMiBwbGFubmVkLCAyIGxhdW5jaGVkIGluIHRvdGFsLywKIAkJ
JGxvZ19vZmZzZXQpKTsKIAotLSAKMi41MC4xCgo=
--000000000000334111064f0b3e08--