Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tY704-003sTf-Sb for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 17:16:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tY703-00ESBv-JM for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 17:16:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tY703-00ESBn-9P for pgsql-hackers@lists.postgresql.org; Wed, 15 Jan 2025 17:16:15 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tY701-000aIH-1i for pgsql-hackers@postgresql.org; Wed, 15 Jan 2025 17:16:15 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-306007227d3so421141fa.0 for ; Wed, 15 Jan 2025 09:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736961372; x=1737566172; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2hvfU9YkwU7qiTDXNL8IA+iHbTe1rOGsENnLzTjK5i8=; b=m0sg5ZXkHFk4aDyqAlWZ68orjf9Hbz7FUeyr1UkhGSErjxptkc8x8/t0ku8hJspiwO KnnehnmSPjBqPnO47qPrEboMNfzfGSy/4cWka+TGEoTzCINfTpJl2HOFaNWbYcfGHpl+ kMcBYZdAK1WMm4XTXX3aI9WeAy6NsFeHTUft9WvU4sP39qD1O3imCkMy/h6YHsKk9kbZ C6UpZYxZ1AvATngIqdTcqgFhNxPxmtWcKWgxmo7mXw4BlTUPXuuhYZgmp0xNOTLY34aU jie+NemSyiZypdqpy6nyY9Nu0WCquNqjTZEnoJez2cdI2wa6lx7XywfEDHtEsl8h2cv7 +1Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736961372; x=1737566172; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2hvfU9YkwU7qiTDXNL8IA+iHbTe1rOGsENnLzTjK5i8=; b=DOzPk42icTlXGxCP/ob3ZqWRVnq1sF3KB95hPEYRAZ/aquD+IuaqNop82X13adgIme 9BBJpRGYjDXZ1WcYMUi1r/2bzm3/9jmC2fqdsjOCpYleV4sJ7M5cnpPE+TaxEOJkShGz Jp34Oce/IdeLjXJhndSwBPvuCGz+wTFMghIY/ApBb18QDSTDr3bbNyMYrJ2cmuPmgh/3 Utp7jGhxgdBPfzmHMmtZ75h1WWrSs9DLcw6T/ZnvN4DfU/L+LGDKFDoW5Yw6ZykvNe1T mi8hYQQ1/nrAxf5SeOkPop2OMB4b64wUGsVFibJJIsumjLGfBGW1ZfDLshnL+g+33hS4 PDLQ== X-Forwarded-Encrypted: i=1; AJvYcCVv959cHIpAcP6kEbMzaAj/vei8Tr3cduiD9anYVODiV7OoUP2OdiuImssKsWwKC6lPqQfhSXicc0uHlGbx@postgresql.org X-Gm-Message-State: AOJu0Yzkw/b/B80x4JyhGNu+Sr7L29I8NiinJDJcACm5yMulSXzY9IIQ EfE4/CKJXYGP7I09mQ0qzcn4EchppLuIoHKt3/Yefqs10KObE7oJXl1f8Il3apx0UgvtCxXwjFr sDuR6USa0fMkqEtL0v/nhvdMw/h8= X-Gm-Gg: ASbGncux27Vg3DUwR/emnYiTDewYqYTyz93Evah6dr0kcgemkFY3AecDoE57L25W3i8 Z0aTcX4Rro8ns7zaW97QW8FH31H3IUrnxIJygHA== X-Google-Smtp-Source: AGHT+IHsULtMvw2NywDxCyTy5eRqWRxxqDX3GTH+q9l15CdkmVf2Pk6+L9kw9cqsOa0ZgidBdoUz/gq5LiknKZcN6MQ= X-Received: by 2002:a05:651c:1595:b0:306:f7b:20b with SMTP id 38308e7fff4ca-3060f7b02b1mr73362631fa.24.1736961372216; Wed, 15 Jan 2025 09:16:12 -0800 (PST) MIME-Version: 1.0 References: <320a31e6-4c91-438b-ab17-8a1d72384727@tantorlabs.com> <52e5e3aa-066a-4daf-8d65-77c34a2f0d98@tantorlabs.com> <6482A576-4465-4E46-A42C-F1767E8DDE30@yandex-team.ru> <20994d10-ab44-4c6b-91bc-c4675cd2e58e@tantorlabs.com> <9D8A5BC8-A3A5-4DA9-9382-F30D343247D1@yandex-team.ru> <6cf6270b-e8fa-4d99-b74a-17e781cdf309@tantorlabs.com> <3a27c830-b81f-4560-9774-a87d9b922fbd@tantorlabs.com> In-Reply-To: From: Sami Imseih Date: Wed, 15 Jan 2025 11:16:01 -0600 X-Gm-Features: AbW1kvY5vFyhOL_U_P7MBRqyCh0LF7bd0-eJpAu-l8b5oQAwRWV-m6Q8HvxHI4s Message-ID: Subject: Re: Sample rate added to pg_stat_statements To: Ilia Evdokimov Cc: "Andrey M. Borodin" , Alena Rybakina , Alexander Korotkov , Michael Paquier , Greg Sabino Mullane , pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > Probably, but first I suggest benchmarking with sampling applied to all queries. If the results are good, we can later filter certain queries based on different characteristics. Absolutely. The benchmark numbers to justify this feature are the next step. Thanks for your work on this! Regards, Sami