MIME-Version: 1.0
References: 
 <CAA5RZ0ui6JSDPQDs2RW7eBDvrH_t_xg8bhUM8FaxawU8wDoMFg@mail.gmail.com>
 <8437F4D0-9DFB-4045-9318-CC3C5BA2E267@paquier.xyz>
 <CAP53Pkwb2f288Ji2s9ZZTL0_PEyYCZpQjBtD63X_s+yUB3YORA@mail.gmail.com>
 <CAA5RZ0vrXNndS6rGx43q+h9JNtxnUzZnxgP_zWSc9LHXS36bXg@mail.gmail.com>
 <acsMzhxJ6lGbbel5@paquier.xyz>
 <CAA5RZ0ufGxCCoPBHKV2mLo9CzHe83w1L-mhx5XHU4axXkMHirw@mail.gmail.com>
 <CAP53Pkx2s7O_fbmLoReKMeOXwp9Z=9e3uW4Tp9RMw99z_dSaiQ@mail.gmail.com>
 <adJP5aQ3TE5ay1J5@paquier.xyz>
In-Reply-To: <adJP5aQ3TE5ay1J5@paquier.xyz>
From: Sami Imseih <samimseih@gmail.com>
Date: Sun, 5 Apr 2026 17:13:40 -0500
Message-ID: 
 <CAA5RZ0vbBDPePBRD6Venpb8aW97nb37rCeT_n7htuE8L0+EjKw@mail.gmail.com>
Subject: Re: Refactor query normalization into core query jumbling
To: Michael Paquier <michael@paquier.xyz>
Cc: Lukas Fittl <lukas@fittl.com>, zengman <zengman@halodbtech.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
 Julien Rouhaud <rjuju123@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0vbBDPePBRD6Venpb8aW97nb37rCeT_n7htuE8L0%2BEjKw%40mail.gmail.com>
Precedence: bulk

> >> > I'm +-0 regarding this routine, but I can also see your point about how it's
> >> > useful to give at least the option to extensions to have a
> >> > recomputation of the Const lengths, the same way as PGSS.  What are
> >> > the extensions that would use that?
> >>
> >> https://github.com/search?q=fill_in_constant_lengths&type=code
> >>
> >> A few well-known extensions/tools out there based on a Github search.
>
> FWIW, this search points to a lot of forks
>
> > See attached a v9 that extracts ComputeConstantLengths from Sami's v7
> > for easier discussion.
> >
> > I've done an updated test with pg_stat_monitor [0] and pg_tracing [1]
> > with that, and that has both extensions passing regressions tests.
> > I've also looked but not tested a third extension (sql_firewall) and
> > that looks like it should just work as well.
>
> Still I can see the gains here, so I guess that this version works
> here.  I'm happy enough to see the const with JumbleState.

I took a look at v9 and it LGTM.

--
Sami