Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tkpU6-0079lB-9A
	for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Feb 2025 19:11:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tkpU4-00CVlA-Rf
	for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Feb 2025 19:11:49 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <samimseih@gmail.com>)
	id 1tkpU4-00CVks-HD
	for pgsql-hackers@lists.postgresql.org; Wed, 19 Feb 2025 19:11:48 +0000
Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <samimseih@gmail.com>)
	id 1tkpTq-001oXB-0o
	for pgsql-hackers@postgresql.org;
	Wed, 19 Feb 2025 19:11:48 +0000
Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-30738a717ffso971911fa.0
        for <pgsql-hackers@postgresql.org>; Wed, 19 Feb 2025 11:11:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1739992292; x=1740597092; darn=postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=k2tmmz0ZmvZYuBo9NZvwjQ4S0vvTVhAC15O+SCwc2cQ=;
        b=MsCr7JcFIT62a3Lal2Yn47R4cyH+hFi6VxTNH7skNtwtf+aNOUfQN8ZvidHroefC5t
         JNsp6qgTlp9yQW4OMKwkkMvHxFkLWwBOtOi/08AO6VO1esHZc0N2NE9Gvrfajsoondz9
         6I5Dq6lE9f00Eq5LOFNrl1F7cB9xJhZ2QvXYZOxx3r3JVsW8KWwz0LEX0No2O/145n1+
         bK3img0BnTlU5LGPTft++kx3948rA3KUUDxwOjzeHu5E87TBQohG1uohG1AkHUas64cE
         DdsWdnQSruaVI3lhqy0QiChBpVGnm0h0IgIeomrkAkFLDOxXSulJPSXSXmQyJU0moFeY
         gGTA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1739992292; x=1740597092;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=k2tmmz0ZmvZYuBo9NZvwjQ4S0vvTVhAC15O+SCwc2cQ=;
        b=XDEwUZxN69cNd2If0YDAgaV+1R5E9qCuO7GJT03RSp5gpTThH33iCVN3o4MQA+ygrs
         PvzXy+RfuZHxiZvksNcVoMVJ9uapEOsCiq7cyyTocvKjIWjUnQ0AtBudkDgIfWJ6VQNL
         sfWXinhV3TY+9XWzFAG6ri3x4JrZbqEmRX28d4mVefYcRm4hOrRf9gP5YCiu+K4aXn9C
         xGmqV17ri0WBhByvFqu1UJVPCZX7W4Fg7aretaAwQYXEr1rxgl89BvPE4YZJDM/j11VM
         A8Kx/UpCoUQZQ3vf5QYSVc9d1PT83tn+qwNXvfz/MQwtzdqGaar7IsPRaYjUr1PAzH1y
         is+g==
X-Forwarded-Encrypted: i=1; AJvYcCUnUPdcH/1yiTMWYFUcARTx/UGKNYaK+cNVFcuWdaWL8uCACwRtL2i9nLT3eDOVcNe1RZJF4GGaotbkPSnp@postgresql.org
X-Gm-Message-State: AOJu0Yxr1CndpBKK7PMOFmbN3nqhl1wxYL2NeEn0k4TYbKttjQYkGT/q
	KfKTe7E6qfFuys8xT8ZXoAjEwcJbrAhZDw+uK+IDzN0IEKkyiY1EPUcl9SR3yI9gBU+wUYvcf0D
	nhwsUIWlpmwKNSx4E+x4mfUwQfX4=
X-Gm-Gg: ASbGncvHBlTRtLXDmEAVsA717Ag2RqeKz98tOdu93+8H/yjgmPb7RaUcaPE6imKhuWJ
	ZpSRw7mU/erED63AR/8BUx+b9vuLL1caLGgjYyvEYVCW+SZVdHrbzsNhLvQfROcYaNnKCrhQ=
X-Google-Smtp-Source: AGHT+IErYfObHNqrsErCZzisx45DhX/chAU4pvwhyC4DWODTkoUt9R3vW1vHih7c+Pu+Cv3i++e6sGybbgiqWN9Uyh4=
X-Received: by 2002:a2e:9802:0:b0:308:e476:3b9c with SMTP id
 38308e7fff4ca-30927a64f4dmr55838211fa.19.1739992292219; Wed, 19 Feb 2025
 11:11:32 -0800 (PST)
MIME-Version: 1.0
References: <fe99e0ca-e564-480e-b865-5f0cee30bc60@tantorlabs.com>
 <b40b76c3-fc54-4f11-a50f-e63cd6434560@postgrespro.ru> <3a27c830-b81f-4560-9774-a87d9b922fbd@tantorlabs.com>
 <CAA5RZ0vYu+dm3KKd5iaQ=LY0J2sjfxJG+-VCfkeVtWFuhSb-4A@mail.gmail.com>
 <cebfee9c-a894-46f1-b6bc-5bf4a0753b41@tantorlabs.com> <7AD765EF-14DE-4B3E-8282-E82A9B44DBAA@yandex-team.ru>
 <e738eac5-ad4d-454c-a079-38766e32ce52@tantorlabs.com> <CAA5RZ0s+khQ_u84qS_cAHzxVQQHK_UmWXxRBWTTex7zW1250tQ@mail.gmail.com>
 <0c7770bd-9750-4200-a472-bdb262583c2f@tantorlabs.com> <CAA5RZ0vxn_UiUkUK5SdngObLZzw40RhafB7SHydxzBw2_xjjiA@mail.gmail.com>
 <cc1beb52-3e4e-4866-8c32-a5967b98c977@tantorlabs.com> <18631d46-1741-4edc-b116-8d9631cdf919@tantorlabs.com>
 <4f98ec33-c627-4eb4-84f3-9994a0982277@tantorlabs.com> <CAA5RZ0tJjrX6YiQVDZCOA_BDMuhO-po_T8a3PmjxEEH_iL-qMg@mail.gmail.com>
 <623db69f-b40a-4d50-b1bd-bb073fcc4336@tantorlabs.com> <3546e2a7-5831-4c0a-996b-358d4ec483a6@tantorlabs.com>
 <6bf3059f-7ebe-4640-8870-1220f83b88ed@tantorlabs.com> <7b9df88f-3015-464b-881e-4c6a7b3a5c03@tantorlabs.com>
In-Reply-To: <7b9df88f-3015-464b-881e-4c6a7b3a5c03@tantorlabs.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Wed, 19 Feb 2025 13:11:20 -0600
X-Gm-Features: AWEUYZmI2_weso4_HSi3SA_nQZ8Oz6ix63jvCxnRwvVrNh8PU_PQ7gRUoNG2X5I
Message-ID: <CAA5RZ0vz+Abyck0dn0fHJ5nTfJU7wdLRxfUj481Ga-BGNY0Txg@mail.gmail.com>
Subject: Re: Sample rate added to pg_stat_statements
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Michael Paquier <michael@paquier.xyz>, 
	Greg Sabino Mullane <htamfids@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, 
	Alena Rybakina <a.rybakina@postgrespro.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAA5RZ0vz%2BAbyck0dn0fHJ5nTfJU7wdLRxfUj481Ga-BGNY0Txg%40mail.gmail.com>
Precedence: bulk

I don't see v18 attached.

But, I think it's wrong that you changed the design of this patch
(sample rate to duration based ) after it was ready for committer.

This CF [0] should go back to "Needs Review" if this is the case.

--

Sami

[0] https://commitfest.postgresql.org/patch/5390/