MIME-Version: 1.0
References: <CAAAe_zAzOgB2KR9ACDD2o3QNP_gaCKnUd2bRGgbhcD=og50XXA@mail.gmail.com>
 <20260214.092310.1353606038244245395.ishii@postgresql.org>
 <CAAAe_zB+W+xBJpYNzRLzh6BH9HrFycTjoPUnVvnU1BT_7RR8Bw@mail.gmail.com> <20260215.180652.676783304925959084.ishii@postgresql.org>
In-Reply-To: <20260215.180652.676783304925959084.ishii@postgresql.org>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Tue, 17 Feb 2026 00:09:04 +0900
Message-ID: <CAAAe_zA7FjgFGgVHXKUP2pXzctdioELseTKA8wgMJOS1gv_+8g@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com, 
	david.g.johnston@gmail.com, peter@eisentraut.org, 
	pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="000000000000af6616064af2569f"
Archived-At: <https://www.postgresql.org/message-id/CAAAe_zA7FjgFGgVHXKUP2pXzctdioELseTKA8wgMJOS1gv_%2B8g%40mail.gmail.com>
Precedence: bulk

--000000000000af6616064af2569f
Content-Type: multipart/alternative; boundary="000000000000af6615064af2569d"

--000000000000af6615064af2569d
Content-Type: text/plain; charset="UTF-8"

Hi Tatsuo,

Thanks for rebasing to v43!

I noticed the Cirrus CI 32-bit build (test_world_32) failed on three
tests, all due to the same root cause in rpr_explain.out:

  Sort Method: quicksort  Memory: 27kB  (expected, 64-bit)
  Sort Method: quicksort  Memory: 22kB  (actual, 32-bit)

The rpr_explain_filter() function was already normalizing the RPR
Storage memory values, but missed the Sort node's "Memory: NNkB"
which also varies between 32-bit and 64-bit due to pointer/struct
size differences.

The attached incremental patch adds Sort Method memory normalization
to rpr_explain_filter(), using the same approach as the existing
Storage and Maximum Storage filters.

> The node serialization functions (141 lines, 0% coverage) are the
> > largest untested area.  I'm not sure how to trigger these paths
> > in the regression test framework.  Any suggestions?
>
> I think we can leave it as it is, until reluctant quantifier is
> implemented.
>

Agreed.


> > I'll send a separate email within a few days listing the FIXME
> > issues and other unresolved items from the mailing list discussion
> > for your review.
>
> Looking forward to reading your email.


Best regards,
Henson

--000000000000af6615064af2569d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Tatsuo,<br><br>Thanks for rebasing to =
v43!<br><br>I noticed the Cirrus CI 32-bit build (test_world_32) failed on =
three<br>tests, all due to the same root cause in rpr_explain.out:<br><br>=
=C2=A0 Sort Method: quicksort =C2=A0Memory: 27kB =C2=A0(expected, 64-bit)<b=
r>=C2=A0 Sort Method: quicksort =C2=A0Memory: 22kB =C2=A0(actual, 32-bit)<b=
r><br>The rpr_explain_filter() function was already normalizing the RPR<br>=
Storage memory values, but missed the Sort node&#39;s &quot;Memory: NNkB&qu=
ot;<br>which also varies between 32-bit and 64-bit due to pointer/struct<br=
>size differences.<br><br>The attached incremental patch adds Sort Method m=
emory normalization<br>to rpr_explain_filter(), using the same approach as =
the existing<br>Storage and Maximum Storage filters.</div><div dir=3D"ltr">=
<br></div><div class=3D"gmail_quote gmail_quote_container"><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;b=
order-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"=
>
&gt; The node serialization functions (141 lines, 0% coverage) are the<br>
&gt; largest untested area.=C2=A0 I&#39;m not sure how to trigger these pat=
hs<br>
&gt; in the regression test framework.=C2=A0 Any suggestions?<br>
<br>
I think we can leave it as it is, until reluctant quantifier is<br>
implemented.<br></blockquote><div><br></div><div>Agreed.<br>=C2=A0<br></div=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);=
padding-left:1ex">
&gt; I&#39;ll send a separate email within a few days listing the FIXME<br>
&gt; issues and other unresolved items from the mailing list discussion<br>
&gt; for your review.<br>
<br>
Looking forward to reading your email.</blockquote><div><br></div>Best rega=
rds,<br>Henson</div></div>

--000000000000af6615064af2569d--
--000000000000af6616064af2569f
Content-Type: text/plain; charset="US-ASCII"; name="v43-fix-rpr-explain-32bit.txt"
Content-Disposition: attachment; filename="v43-fix-rpr-explain-32bit.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mlpb72u50>
X-Attachment-Id: f_mlpb72u50

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnByX2V4cGxhaW4ub3V0IGIv
c3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ycHJfZXhwbGFpbi5vdXQKaW5kZXggZjIzZDA2ZjZk
NTkuLmJmZTRlZTJiYTdkIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3Jw
cl9leHBsYWluLm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3Jwcl9leHBsYWlu
Lm91dApAQCAtMzMsNyArMzMsNyBAQAogLS0gICBERUZJTkUgRXhwcmVzc2lvbiBWYXJpYXRpb25z
CiAtLSAgIExhcmdlIFNjYWxlIFN0YXRpc3RpY3MgVmVyaWZpY2F0aW9uCiAtLSA9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEZp
bHRlciBmdW5jdGlvbiB0byBub3JtYWxpemUgU3RvcmFnZSBtZW1vcnkgdmFsdWVzIG9ubHkgKG5v
dCBORkEgc3RhdGlzdGljcykuCistLSBGaWx0ZXIgZnVuY3Rpb24gdG8gbm9ybWFsaXplIHBsYXRm
b3JtLWRlcGVuZGVudCBtZW1vcnkgdmFsdWVzIChub3QgTkZBIHN0YXRpc3RpY3MpLgogLS0gTkZB
IHN0YXRpc3RpY3Mgc2hvdWxkIG5vdCBjaGFuZ2UgYmV0d2VlbiBwbGF0Zm9ybXM7IGlmIHRoZXkg
ZG8sIGl0IGNvdWxkCiAtLSBpbmRpY2F0ZSBpc3N1ZXMgc3VjaCBhcyB1bmluaXRpYWxpemVkIG1l
bW9yeSBhY2Nlc3MuCiAtLSBXb3JrcyBmb3IgdGV4dCwgSlNPTiwgYW5kIFhNTCBmb3JtYXRzLgpA
QCAtNDUsNyArNDUsNyBAQCBkZWNsYXJlCiBiZWdpbgogICAgIGZvciBsbiBpbiBleGVjdXRlICQx
CiAgICAgbG9vcAotICAgICAgICAtLSBOb3JtYWxpemUgbWVtb3J5IHNpemUgaW4gU3RvcmFnZSBs
aW5lIG9ubHkgKHBsYXRmb3JtLWRlcGVuZGVudCkKKyAgICAgICAgLS0gTm9ybWFsaXplIHBsYXRm
b3JtLWRlcGVuZGVudCBtZW1vcnkgdmFsdWVzCiAgICAgICAgIC0tIEtlZXAgTkZBIHN0YXRpc3Rp
Y3MgbnVtYmVycyB1bmNoYW5nZWQgKHRoZXkgYXJlIHRlc3QgYXNzZXJ0aW9ucykKIAogICAgICAg
ICAtLSBUZXh0IGZvcm1hdDogIlN0b3JhZ2U6IE1lbW9yeSAgTWF4aW11bSBTdG9yYWdlOiAxOGtC
IgpAQCAtNjMsNiArNjMsMTEgQEAgYmVnaW4KICAgICAgICAgICAgIGxuIDo9IHJlZ2V4cF9yZXBs
YWNlKGxuLCAnPE1heGltdW0tU3RvcmFnZT5cZCs8L01heGltdW0tU3RvcmFnZT4nLCAnPE1heGlt
dW0tU3RvcmFnZT4wPC9NYXhpbXVtLVN0b3JhZ2U+JywgJ2cnKTsKICAgICAgICAgZW5kIGlmOwog
CisgICAgICAgIC0tIFNvcnQgTWV0aG9kIG1lbW9yeSBpcyBwbGF0Zm9ybS1kZXBlbmRlbnQgKDMy
LWJpdCB2cyA2NC1iaXQpCisgICAgICAgIGlmIGxuIH4gJ1NvcnQgTWV0aG9kOi4qTWVtb3J5Oicg
dGhlbgorICAgICAgICAgICAgbG4gOj0gcmVnZXhwX3JlcGxhY2UobG4sICdNZW1vcnk6IFxkK2tC
JywgJ01lbW9yeTogTmtCJyk7CisgICAgICAgIGVuZCBpZjsKKwogICAgICAgICByZXR1cm4gbmV4
dCBsbjsKICAgICBlbmQgbG9vcDsKIGVuZDsKQEAgLTE2MjUsNyArMTYzMCw3IEBAIFdJTkRPVyB3
IEFTICgKICAgIE5GQTogNTQgYWJzb3JiZWQgKGxlbiAxLzEvMS4wKSwgMTggc2tpcHBlZCAobGVu
IDEvMS8xLjApCiAgICAtPiAgU29ydCAoYWN0dWFsIHJvd3M9OTAuMDAgbG9vcHM9MSkKICAgICAg
ICAgIFNvcnQgS2V5OiBwLnAKLSAgICAgICAgIFNvcnQgTWV0aG9kOiBxdWlja3NvcnQgIE1lbW9y
eTogMjdrQgorICAgICAgICAgU29ydCBNZXRob2Q6IHF1aWNrc29ydCAgTWVtb3J5OiBOa0IKICAg
ICAgICAgIC0+ICBOZXN0ZWQgTG9vcCAoYWN0dWFsIHJvd3M9OTAuMDAgbG9vcHM9MSkKICAgICAg
ICAgICAgICAgIC0+ICBGdW5jdGlvbiBTY2FuIG9uIGdlbmVyYXRlX3NlcmllcyBwIChhY3R1YWwg
cm93cz0zLjAwIGxvb3BzPTEpCiAgICAgICAgICAgICAgICAtPiAgRnVuY3Rpb24gU2NhbiBvbiBn
ZW5lcmF0ZV9zZXJpZXMgdiAoYWN0dWFsIHJvd3M9MzAuMDAgbG9vcHM9MykKQEAgLTE2ODIsNyAr
MTY4Nyw3IEBAIFdJTkRPVyB3IEFTICgKICAgIE5GQTogMTkgYWJzb3JiZWQgKGxlbiAxLzEvMS4w
KSwgNSBza2lwcGVkIChsZW4gMS8xLzEuMCkKICAgIC0+ICBTb3J0IChhY3R1YWwgcm93cz01MC4w
MCBsb29wcz0xKQogICAgICAgICAgU29ydCBLZXk6IChDQVNFIFdIRU4gKHYudiA8PSAyNSkgVEhF
TiAxIEVMU0UgMiBFTkQpCi0gICAgICAgICBTb3J0IE1ldGhvZDogcXVpY2tzb3J0ICBNZW1vcnk6
IDI2a0IKKyAgICAgICAgIFNvcnQgTWV0aG9kOiBxdWlja3NvcnQgIE1lbW9yeTogTmtCCiAgICAg
ICAgICAtPiAgRnVuY3Rpb24gU2NhbiBvbiBnZW5lcmF0ZV9zZXJpZXMgdiAoYWN0dWFsIHJvd3M9
NTAuMDAgbG9vcHM9MSkKICgxMiByb3dzKQogCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNz
L3NxbC9ycHJfZXhwbGFpbi5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9ycHJfZXhwbGFpbi5z
cWwKaW5kZXggZjhjOGY2MmU1OTQuLmVhOGMzOWI5OTFlIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9y
ZWdyZXNzL3NxbC9ycHJfZXhwbGFpbi5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvcnBy
X2V4cGxhaW4uc3FsCkBAIC0zNCw3ICszNCw3IEBACiAtLSAgIExhcmdlIFNjYWxlIFN0YXRpc3Rp
Y3MgVmVyaWZpY2F0aW9uCiAtLSA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KIAotLS0gRmlsdGVyIGZ1bmN0aW9uIHRvIG5vcm1hbGl6
ZSBTdG9yYWdlIG1lbW9yeSB2YWx1ZXMgb25seSAobm90IE5GQSBzdGF0aXN0aWNzKS4KKy0tIEZp
bHRlciBmdW5jdGlvbiB0byBub3JtYWxpemUgcGxhdGZvcm0tZGVwZW5kZW50IG1lbW9yeSB2YWx1
ZXMgKG5vdCBORkEgc3RhdGlzdGljcykuCiAtLSBORkEgc3RhdGlzdGljcyBzaG91bGQgbm90IGNo
YW5nZSBiZXR3ZWVuIHBsYXRmb3JtczsgaWYgdGhleSBkbywgaXQgY291bGQKIC0tIGluZGljYXRl
IGlzc3VlcyBzdWNoIGFzIHVuaW5pdGlhbGl6ZWQgbWVtb3J5IGFjY2Vzcy4KIC0tIFdvcmtzIGZv
ciB0ZXh0LCBKU09OLCBhbmQgWE1MIGZvcm1hdHMuCkBAIC00Niw3ICs0Niw3IEBAIGRlY2xhcmUK
IGJlZ2luCiAgICAgZm9yIGxuIGluIGV4ZWN1dGUgJDEKICAgICBsb29wCi0gICAgICAgIC0tIE5v
cm1hbGl6ZSBtZW1vcnkgc2l6ZSBpbiBTdG9yYWdlIGxpbmUgb25seSAocGxhdGZvcm0tZGVwZW5k
ZW50KQorICAgICAgICAtLSBOb3JtYWxpemUgcGxhdGZvcm0tZGVwZW5kZW50IG1lbW9yeSB2YWx1
ZXMKICAgICAgICAgLS0gS2VlcCBORkEgc3RhdGlzdGljcyBudW1iZXJzIHVuY2hhbmdlZCAodGhl
eSBhcmUgdGVzdCBhc3NlcnRpb25zKQogCiAgICAgICAgIC0tIFRleHQgZm9ybWF0OiAiU3RvcmFn
ZTogTWVtb3J5ICBNYXhpbXVtIFN0b3JhZ2U6IDE4a0IiCkBAIC02NCw2ICs2NCwxMSBAQCBiZWdp
bgogICAgICAgICAgICAgbG4gOj0gcmVnZXhwX3JlcGxhY2UobG4sICc8TWF4aW11bS1TdG9yYWdl
PlxkKzwvTWF4aW11bS1TdG9yYWdlPicsICc8TWF4aW11bS1TdG9yYWdlPjA8L01heGltdW0tU3Rv
cmFnZT4nLCAnZycpOwogICAgICAgICBlbmQgaWY7CiAKKyAgICAgICAgLS0gU29ydCBNZXRob2Qg
bWVtb3J5IGlzIHBsYXRmb3JtLWRlcGVuZGVudCAoMzItYml0IHZzIDY0LWJpdCkKKyAgICAgICAg
aWYgbG4gfiAnU29ydCBNZXRob2Q6LipNZW1vcnk6JyB0aGVuCisgICAgICAgICAgICBsbiA6PSBy
ZWdleHBfcmVwbGFjZShsbiwgJ01lbW9yeTogXGQra0InLCAnTWVtb3J5OiBOa0InKTsKKyAgICAg
ICAgZW5kIGlmOworCiAgICAgICAgIHJldHVybiBuZXh0IGxuOwogICAgIGVuZCBsb29wOwogZW5k
Owo=
--000000000000af6616064af2569f--