MIME-Version: 1.0
References: <CAAAe_zDtstKUcKsH3FJuKeZ=ykXFWKO1Lz80JXEn9y8BeQeYNQ@mail.gmail.com>
 <20260204.090451.1095005750732720998.ishii@postgresql.org>
 <CAAAe_zC95wT9EdBu_nBn6mWVB7-xNNuJ4N8wPr0LrWJBdwmxiQ@mail.gmail.com> <20260204.192222.892684621512920290.ishii@postgresql.org>
In-Reply-To: <20260204.192222.892684621512920290.ishii@postgresql.org>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Thu, 5 Feb 2026 09:46:06 +0900
Message-ID: <CAAAe_zA=BDm=e04aNFYe3Az0CzPipK+HHzu1KGHiLOg+r_z8XQ@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, 
	vik@postgresfriends.org, er@xs4all.nl, peter@eisentraut.org, 
	pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="000000000000343b34064a0900e2"
Archived-At: <https://www.postgresql.org/message-id/CAAAe_zA%3DBDm%3De04aNFYe3Az0CzPipK%2BHHzu1KGHiLOg%2Br_z8XQ%40mail.gmail.com>
Precedence: bulk

--000000000000343b34064a0900e2
Content-Type: multipart/alternative; boundary="000000000000343b33064a0900e0"

--000000000000343b33064a0900e0
Content-Type: text/plain; charset="UTF-8"

Hi Tatsuo,

> Therefore, I believe it only makes sense to add explicit initialization
> > for nfaStatesActive and nfaContextsActive, since these are the only two
> > that release_partition() also explicitly resets.
>
> That makes sense.
>

Thank you for confirming.

> ## Proposal for consistency
> >
> >   /* Initialize NFA free lists for row pattern matching */
> >   winstate->nfaContext = NULL;
> >   winstate->nfaContextTail = NULL;
> >   winstate->nfaContextFree = NULL;
> >   winstate->nfaStateFree = NULL;
> >   winstate->nfaLastProcessedRow = -1;
> >   winstate->nfaStatesActive = 0;        // Add this
> >   winstate->nfaContextsActive = 0;      // Add this
> >
> > Would you like me to include this change in the next patch?
>
> Yes, please.
>


Done. Please see the attached patch.

Best regards,
Henson

--000000000000343b33064a0900e0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Tatsuo,</div><div dir=3D"ltr"><br></di=
v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-le=
ft-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">&gt; Th=
erefore, I believe it only makes sense to add explicit initialization<br>
&gt; for nfaStatesActive and nfaContextsActive, since these are the only tw=
o<br>
&gt; that release_partition() also explicitly resets.<br>
<br>
That makes sense.<br></blockquote><div><br></div><div>Thank you for confirm=
ing.<br></div><div><br></div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-=
left-color:rgb(204,204,204);padding-left:1ex">&gt; ## Proposal for consiste=
ncy<br>
&gt; <br>&gt;=C2=A0 =C2=A0/* Initialize NFA free lists for row pattern matc=
hing */<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaContext =3D NULL;<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaContextTail =3D NULL;<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaContextFree =3D NULL;<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaStateFree =3D NULL;<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaLastProcessedRow =3D -1;<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaStatesActive =3D 0;=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 // Add this<br>
&gt;=C2=A0 =C2=A0winstate-&gt;nfaContextsActive =3D 0;=C2=A0 =C2=A0 =C2=A0 =
// Add this<br>&gt; <br>
&gt; Would you like me to include this change in the next patch?<br>
<br>
Yes, please.<br></blockquote><div><br></div><br>Done. Please see the attach=
ed patch.<br><br>Best regards,<br>Henson<br><div>=C2=A0</div></div></div>

--000000000000343b33064a0900e0--
--000000000000343b34064a0900e2
Content-Type: text/plain; charset="US-ASCII"; name="nfa_init_consistency.txt"
Content-Disposition: attachment; filename="nfa_init_consistency.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_ml8qjrz90>
X-Attachment-Id: f_ml8qjrz90

RnJvbSBkMDY1MjVkYjc4MWMzNDMyZDQ4ODcwNjc1OWM2NTNkMDBhNWUxOTgwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5zb24gQ2hvaSA8YXNzYW0yNThAZ21haWwuY29tPgpEYXRl
OiBUaHUsIDUgRmViIDIwMjYgMDk6NDE6MDMgKzA5MDAKU3ViamVjdDogW1BBVENIXSBJbml0aWFs
aXplIE5GQSBwZXItcGFydGl0aW9uIGNvdW50ZXJzIGluIEV4ZWNJbml0V2luZG93QWdnCgotLS0K
IHNyYy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVXaW5kb3dBZ2cuYyB8IDIgKysKIDEgZmlsZSBjaGFu
Z2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9leGVjdXRvci9u
b2RlV2luZG93QWdnLmMgYi9zcmMvYmFja2VuZC9leGVjdXRvci9ub2RlV2luZG93QWdnLmMKaW5k
ZXggMTE3NmRmMDRiMmMuLjFlMDg4NjE1ZDE5IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9leGVj
dXRvci9ub2RlV2luZG93QWdnLmMKKysrIGIvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZVdpbmRv
d0FnZy5jCkBAIC0zMDU0LDYgKzMwNTQsOCBAQCBFeGVjSW5pdFdpbmRvd0FnZyhXaW5kb3dBZ2cg
Km5vZGUsIEVTdGF0ZSAqZXN0YXRlLCBpbnQgZWZsYWdzKQogCXdpbnN0YXRlLT5uZmFDb250ZXh0
RnJlZSA9IE5VTEw7CiAJd2luc3RhdGUtPm5mYVN0YXRlRnJlZSA9IE5VTEw7CiAJd2luc3RhdGUt
Pm5mYUxhc3RQcm9jZXNzZWRSb3cgPSAtMTsKKwl3aW5zdGF0ZS0+bmZhU3RhdGVzQWN0aXZlID0g
MDsKKwl3aW5zdGF0ZS0+bmZhQ29udGV4dHNBY3RpdmUgPSAwOwogCiAJLyoKIAkgKiBBbGxvY2F0
ZSB2YXJNYXRjaGVkIGFycmF5IGZvciBORkEgZXZhbHVhdGlvbi4gV2l0aCB0aGUgbmV3IHZhck5h
bWVzCi0tIAoyLjUwLjEgKEFwcGxlIEdpdC0xNTUpCgo=
--000000000000343b34064a0900e2--