MIME-Version: 1.0
References: 
 <CAAAe_zBdtRuAfyEX6eqtprY8ejGXqo6ndrpy0LPEHSzGWDvpxw@mail.gmail.com>
 <20260302.094632.1950837561737687899.ishii@postgresql.org>
 <CAAAe_zCkpYn7qh=chxVLo4-HG8D57RwxhUq-c9zrYvZVtdDgeA@mail.gmail.com>
 <20260302.141823.129040280886273031.ishii@postgresql.org>
 <CAN4CZFOEpz6vXitAkcCGixzAzp4uRRahyScWixKQZU=K4tngtQ@mail.gmail.com>
In-Reply-To: 
 <CAN4CZFOEpz6vXitAkcCGixzAzp4uRRahyScWixKQZU=K4tngtQ@mail.gmail.com>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Thu, 12 Mar 2026 08:52:08 +0900
Message-ID: 
 <CAAAe_zAFv0E_EhFxZueJ1n9pZpPaTVChMhDmndzugzovgz0o2Q@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Zsolt Parragi <zsolt.parragi@percona.com>,
 Tatsuo Ishii <ishii@postgresql.org>
Cc: vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com,
	david.g.johnston@gmail.com, peter@eisentraut.org,
	pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="000000000000a8858c064cc85392"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAAe_zAFv0E_EhFxZueJ1n9pZpPaTVChMhDmndzugzovgz0o2Q%40mail.gmail.com>
Precedence: bulk

--000000000000a8858c064cc85392
Content-Type: multipart/alternative; boundary="000000000000a8858b064cc85390"

--000000000000a8858b064cc85390
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Zsolt, Tatsuo,

+ foreach_ptr(TargetEntry, te, defineClause)
> + (void) coerce_to_boolean(pstate, (Node *) te->expr, "DEFINE");
>
> Isn't this incorrect? I think it should update te->expr, as currently
> it is possible to construct queries where this produces unexpected
> results.


Good catch, Zsolt. You're right =E2=80=94 the return value of
coerce_to_boolean() must be assigned back to te->expr, otherwise
any implicit cast (e.g., a user-defined type with an assignment
cast to boolean) is silently discarded.

The fix is straightforward:

    foreach_ptr(TargetEntry, te, defineClause)
        te->expr =3D (Expr *) coerce_to_boolean(pstate, (Node *) te->expr,
"DEFINE");

I've confirmed that your example query produces incorrect results
without the fix (the truthyint value is evaluated as-is without
the cast) and correct results with it.

Patch 13 is attached with the fix and a regression test case based
on your example.

By the way, thank you for joining the TDE hooks discussion when
I was just getting started as a contributor =E2=80=94 that meant a lot.
Great work on pg_tde at Percona, and rooting for the extensible
SMGR effort as well. Hope it's all going well!

Tatsuo, please review when you get a chance.

Regards,
Henson

--000000000000a8858b064cc85390
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Zsolt, Tatsuo,<br></div><br><div class=
=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:sol=
id;border-left-color:rgb(204,204,204);padding-left:1ex">+ foreach_ptr(Targe=
tEntry, te, defineClause)<br>
+ (void) coerce_to_boolean(pstate, (Node *) te-&gt;expr, &quot;DEFINE&quot;=
);<br>
<br>
Isn&#39;t this incorrect? I think it should update te-&gt;expr, as currentl=
y<br>
it is possible to construct queries where this produces unexpected<br>
results.</blockquote><div><br></div>Good catch, Zsolt. You&#39;re right =E2=
=80=94 the return value of<br>coerce_to_boolean() must be assigned back to =
te-&gt;expr, otherwise<br>any implicit cast (e.g., a user-defined type with=
 an assignment<br>cast to boolean) is silently discarded.<br><br>The fix is=
 straightforward:<br><br>=C2=A0 =C2=A0 foreach_ptr(TargetEntry, te, defineC=
lause)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 te-&gt;expr =3D (Expr *) coerce_to_bo=
olean(pstate, (Node *) te-&gt;expr, &quot;DEFINE&quot;);<br><br>I&#39;ve co=
nfirmed that your example query produces incorrect results<br>without the f=
ix (the truthyint value is evaluated as-is without<br>the cast) and correct=
 results with it.<br><br>Patch 13 is attached with the fix and a regression=
 test case based<br>on your example.<br><br>By the way, thank you for joini=
ng the TDE hooks discussion when<br>I was just getting started as a contrib=
utor =E2=80=94 that meant a lot.<br>Great work on pg_tde at Percona, and ro=
oting for the extensible<br>SMGR effort as well. Hope it&#39;s all going we=
ll!<br><br>Tatsuo, please review when you get a chance.<br><br>Regards,<br>=
Henson<br><div>=C2=A0</div></div></div>

--000000000000a8858b064cc85390--

--000000000000a8858c064cc85392
Content-Type: text/plain; charset="US-ASCII";
 name="0013-fix-define-boolean-coercion.txt"
Content-Disposition: attachment;
	filename="0013-fix-define-boolean-coercion.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mmmoy4ii0>
X-Attachment-Id: f_mmmoy4ii0

RnJvbSBlNDdmYjhhMTE5Y2IyMzU2NjVhOWUxMjhjOGMxODcxODM2YWZmN2I4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5zb24gQ2hvaSA8YXNzYW0yNThAZ21haWwuY29tPgpEYXRl
OiBUaHUsIDEyIE1hciAyMDI2IDA4OjQxOjIxICswOTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGNv
ZXJjZV90b19ib29sZWFuIHJlc3VsdCBub3QgYXBwbGllZCBpbiBERUZJTkUgY2xhdXNlCgotLS0K
IHNyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9ycHIuYyAgICAgICAgIHwgIDIgKy0KIHNyYy90ZXN0
L3JlZ3Jlc3MvZXhwZWN0ZWQvcnByX2Jhc2Uub3V0IHwgMzMgKysrKysrKysrKysrKysrKysrKysr
KysrKysKIHNyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3Jwcl9iYXNlLnNxbCAgICAgIHwgMjkgKysrKysr
KysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAxIGRl
bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3Jwci5jIGIv
c3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3Jwci5jCmluZGV4IGRmZjkxZTQzOWQyLi5lNTc0YjY5
ZDliNSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3Jwci5jCisrKyBiL3Ny
Yy9iYWNrZW5kL3BhcnNlci9wYXJzZV9ycHIuYwpAQCAtMzkyLDcgKzM5Miw3IEBAIHRyYW5zZm9y
bURlZmluZUNsYXVzZShQYXJzZVN0YXRlICpwc3RhdGUsIFdpbmRvd0NsYXVzZSAqd2MsIFdpbmRv
d0RlZiAqd2luZGVmLAogCSAqIGV4cHJlc3Npb24uCiAJICovCiAJZm9yZWFjaF9wdHIoVGFyZ2V0
RW50cnksIHRlLCBkZWZpbmVDbGF1c2UpCi0JCSh2b2lkKSBjb2VyY2VfdG9fYm9vbGVhbihwc3Rh
dGUsIChOb2RlICopIHRlLT5leHByLCAiREVGSU5FIik7CisJCXRlLT5leHByID0gKEV4cHIgKikg
Y29lcmNlX3RvX2Jvb2xlYW4ocHN0YXRlLCAoTm9kZSAqKSB0ZS0+ZXhwciwgIkRFRklORSIpOwog
CiAJLyogbWFyayBjb2x1bW4gb3JpZ2lucyAqLwogCW1hcmtUYXJnZXRMaXN0T3JpZ2lucyhwc3Rh
dGUsIGRlZmluZUNsYXVzZSk7CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVk
L3Jwcl9iYXNlLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnByX2Jhc2Uub3V0Cmlu
ZGV4IGZmZDBmOGVkOWYxLi43OTMxYWQwN2Q3ZCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVz
cy9leHBlY3RlZC9ycHJfYmFzZS5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9y
cHJfYmFzZS5vdXQKQEAgLTI4NSw2ICsyODUsMzkgQEAgT1JERVIgQlkgaWQ7CiAgIDIgfCAgIDAK
ICgyIHJvd3MpCiAKKy0tIEltcGxpY2l0IGNhc3QgdG8gYm9vbGVhbiB2aWEgY3VzdG9tIHR5cGUK
K0NSRUFURSBUWVBFIHRydXRoeWludCBBUyAodiBpbnQpOworQ1JFQVRFIEZVTkNUSU9OIHRydXRo
eWludF90b19ib29sKHRydXRoeWludCkgUkVUVVJOUyBib29sZWFuIEFTICQkCisgIFNFTEVDVCAo
JDEpLnYgPD4gMDsKKyQkIExBTkdVQUdFIFNRTCBJTU1VVEFCTEUgU1RSSUNUOworQ1JFQVRFIENB
U1QgKHRydXRoeWludCBBUyBib29sZWFuKQorICBXSVRIIEZVTkNUSU9OIHRydXRoeWludF90b19i
b29sKHRydXRoeWludCkKKyAgQVMgQVNTSUdOTUVOVDsKK0NSRUFURSBUQUJMRSBycHJfY29lcmNl
IChpZCBpbnQsIHZhbCB0cnV0aHlpbnQpOworSU5TRVJUIElOVE8gcnByX2NvZXJjZSBWQUxVRVMg
KDEsIFJPVygxKSksICgyLCBST1coMCkpLCAoMywgUk9XKDUpKSwgKDQsIFJPVygwKSk7CitTRUxF
Q1QgaWQsIHZhbCwgY250CitGUk9NIChTRUxFQ1QgaWQsIHZhbCwKKyAgICAgICAgICAgICBDT1VO
VCgqKSBPVkVSIHcgQVMgY250CisgICAgICBGUk9NIHJwcl9jb2VyY2UKKyAgICAgIFdJTkRPVyB3
IEFTICgKKyAgICAgICAgICBPUkRFUiBCWSBpZAorICAgICAgICAgIFJPV1MgQkVUV0VFTiBDVVJS
RU5UIFJPVyBBTkQgVU5CT1VOREVEIEZPTExPV0lORworICAgICAgICAgIFBBVFRFUk4gKEErKQor
ICAgICAgICAgIERFRklORSBBIEFTIHZhbAorICAgICAgKQorKSBzIE9SREVSIEJZIGlkOworIGlk
IHwgdmFsIHwgY250IAorLS0tLSstLS0tLSstLS0tLQorICAxIHwgKDEpIHwgICAxCisgIDIgfCAo
MCkgfCAgIDAKKyAgMyB8ICg1KSB8ICAgMQorICA0IHwgKDApIHwgICAwCisoNCByb3dzKQorCitE
Uk9QIFRBQkxFIHJwcl9jb2VyY2U7CitEUk9QIENBU1QgKHRydXRoeWludCBBUyBib29sZWFuKTsK
K0RST1AgRlVOQ1RJT04gdHJ1dGh5aW50X3RvX2Jvb2wodHJ1dGh5aW50KTsKK0RST1AgVFlQRSB0
cnV0aHlpbnQ7CiBEUk9QIFRBQkxFIHJwcl9ib29sOwogLS0gQ29tcGxleCBleHByZXNzaW9ucwog
Q1JFQVRFIFRBQkxFIHJwcl9jb21wbGV4IChpZCBJTlQsIHZhbDEgSU5ULCB2YWwyIElOVCk7CmRp
ZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9ycHJfYmFzZS5zcWwgYi9zcmMvdGVzdC9y
ZWdyZXNzL3NxbC9ycHJfYmFzZS5zcWwKaW5kZXggM2Q2Y2EyYmMyYTIuLmY4ODE1YzczNzZhIDEw
MDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9ycHJfYmFzZS5zcWwKKysrIGIvc3JjL3Rl
c3QvcmVncmVzcy9zcWwvcnByX2Jhc2Uuc3FsCkBAIC0yMzEsNiArMjMxLDM1IEBAIFdJTkRPVyB3
IEFTICgKICkKIE9SREVSIEJZIGlkOwogCistLSBJbXBsaWNpdCBjYXN0IHRvIGJvb2xlYW4gdmlh
IGN1c3RvbSB0eXBlCitDUkVBVEUgVFlQRSB0cnV0aHlpbnQgQVMgKHYgaW50KTsKK0NSRUFURSBG
VU5DVElPTiB0cnV0aHlpbnRfdG9fYm9vbCh0cnV0aHlpbnQpIFJFVFVSTlMgYm9vbGVhbiBBUyAk
JAorICBTRUxFQ1QgKCQxKS52IDw+IDA7CiskJCBMQU5HVUFHRSBTUUwgSU1NVVRBQkxFIFNUUklD
VDsKK0NSRUFURSBDQVNUICh0cnV0aHlpbnQgQVMgYm9vbGVhbikKKyAgV0lUSCBGVU5DVElPTiB0
cnV0aHlpbnRfdG9fYm9vbCh0cnV0aHlpbnQpCisgIEFTIEFTU0lHTk1FTlQ7CisKK0NSRUFURSBU
QUJMRSBycHJfY29lcmNlIChpZCBpbnQsIHZhbCB0cnV0aHlpbnQpOworSU5TRVJUIElOVE8gcnBy
X2NvZXJjZSBWQUxVRVMgKDEsIFJPVygxKSksICgyLCBST1coMCkpLCAoMywgUk9XKDUpKSwgKDQs
IFJPVygwKSk7CisKK1NFTEVDVCBpZCwgdmFsLCBjbnQKK0ZST00gKFNFTEVDVCBpZCwgdmFsLAor
ICAgICAgICAgICAgIENPVU5UKCopIE9WRVIgdyBBUyBjbnQKKyAgICAgIEZST00gcnByX2NvZXJj
ZQorICAgICAgV0lORE9XIHcgQVMgKAorICAgICAgICAgIE9SREVSIEJZIGlkCisgICAgICAgICAg
Uk9XUyBCRVRXRUVOIENVUlJFTlQgUk9XIEFORCBVTkJPVU5ERUQgRk9MTE9XSU5HCisgICAgICAg
ICAgUEFUVEVSTiAoQSspCisgICAgICAgICAgREVGSU5FIEEgQVMgdmFsCisgICAgICApCispIHMg
T1JERVIgQlkgaWQ7CisKK0RST1AgVEFCTEUgcnByX2NvZXJjZTsKK0RST1AgQ0FTVCAodHJ1dGh5
aW50IEFTIGJvb2xlYW4pOworRFJPUCBGVU5DVElPTiB0cnV0aHlpbnRfdG9fYm9vbCh0cnV0aHlp
bnQpOworRFJPUCBUWVBFIHRydXRoeWludDsKKwogRFJPUCBUQUJMRSBycHJfYm9vbDsKIAogLS0g
Q29tcGxleCBleHByZXNzaW9ucwotLSAKMi41MC4xIChBcHBsZSBHaXQtMTU1KQoK
--000000000000a8858c064cc85392--