MIME-Version: 1.0
References: <20260502.140304.670813149418899420.ishii@postgresql.org>
 <20260505.090124.365339750969814137.ishii@postgresql.org>
 <CACJufxEWL_ZnC-bs_yrg-Ys6ZUD3Ut_p1Ebj0bAcbzj67+HDAQ@mail.gmail.com>
 <20260505.170845.1271951360939093763.ishii@postgresql.org>
In-Reply-To: <20260505.170845.1271951360939093763.ishii@postgresql.org>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Tue, 5 May 2026 18:15:29 +0900
Message-ID: 
 <CAAAe_zAhXuBTRiNVU1RrJKOiKoyeu-pgYaYb8HaqbhSsC=sGUg@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Tatsuo Ishii <ishii@postgresql.org>, jian.universality@gmail.com
Cc: zsolt.parragi@percona.com, sjjang112233@gmail.com,
 vik@postgresfriends.org,
	er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com,
	peter@eisentraut.org, li.evan.chao@gmail.com, pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000dda66106510e7d1a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAAe_zAhXuBTRiNVU1RrJKOiKoyeu-pgYaYb8HaqbhSsC%3DsGUg%40mail.gmail.com>
Precedence: bulk

--000000000000dda66106510e7d1a
Content-Type: text/plain; charset="UTF-8"

Hi Tatsuo, Jian,

Both coding-style items from Jian's review will be addressed and
included in the next patch series.

> 1. We need to add trailing commas to enum definitions. See
> >
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=611806cd726fc92989ac918eac48fd8d684869c7
>
> I forgot that. Thanks for reminding.
>

Three enum types introduced by the patch lack a trailing comma on the
last enumerator: RPRNavKind, RPRNavOffsetKind, and RPRPatternNodeType.
All three will be corrected in the next series.


> > + (errcode(ERRCODE_SYNTAX_ERROR),
> > The leading parenthesis is optional and can be removed, fewer
> > parentheses are always better.
> > See related discussion:
> > https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsql
>
> Right. I will review all other patches.


The outer-parentheses pattern appears in 17 ereport() calls in
parse_rpr.c and 2 in optimizer/plan/rpr.c.  All 19 sites will be
cleaned up in the next series.

Jian, I will review your other patches as well.

Best,
Henson

--000000000000dda66106510e7d1a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Tatsuo, Jian,<br><br>Both coding-style=
 items from Jian&#39;s review will be addressed and<br>included in the next=
 patch series.<br></div><br><div class=3D"gmail_quote gmail_quote_container=
"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex">&gt; 1. We need to add =
trailing commas to enum definitions. See<br>
&gt; <a href=3D"https://git.postgresql.org/cgit/postgresql.git/commit/?id=
=3D611806cd726fc92989ac918eac48fd8d684869c7" rel=3D"noreferrer" target=3D"_=
blank">https://git.postgresql.org/cgit/postgresql.git/commit/?id=3D611806cd=
726fc92989ac918eac48fd8d684869c7</a><br>
<br>
I forgot that. Thanks for reminding.<br></blockquote><div><br></div>Three e=
num types introduced by the patch lack a trailing comma on the<br>last enum=
erator: RPRNavKind, RPRNavOffsetKind, and RPRPatternNodeType.<br><div>All t=
hree will be corrected in the next series.</div><div>=C2=A0<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">&gt; + (errcode(ERRCODE_SYNTAX_=
ERROR),<br>
&gt; The leading parenthesis is optional and can be removed, fewer<br>
&gt; parentheses are always better.<br>
&gt; See related discussion:<br>
&gt; <a href=3D"https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsq=
l" rel=3D"noreferrer" target=3D"_blank">https://postgr.es/m/202510100916.s2=
e6n3xiwvyc@alvherre.pgsql</a><br>
<br>
Right. I will review all other patches.</blockquote><div><br>The outer-pare=
ntheses pattern appears in 17 ereport() calls in<br>parse_rpr.c and 2 in op=
timizer/plan/rpr.c.=C2=A0 All 19 sites will be<br>cleaned up in the next se=
ries.<br><br>Jian, I will review your other patches as well.<br><br></div><=
div>Best,<br>Henson<br></div></div></div>

--000000000000dda66106510e7d1a--