public inbox for [email protected]  

help / color / mirror / Atom feed

From: Henson Choi <[email protected]>
To: jian he <[email protected]>
Cc: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Wed, 24 Jun 2026 16:45:13 +0900
Message-ID: <CAAAe_zAjkjUZHMqu5DjgZH9ZZ6D5v4bBJy60ziwhHRoohnB7Zg@mail.gmail.com> (raw)
In-Reply-To: <CACJufxE80E13g575_ywVjDat-Lmmx3WkukzqRvb936P0jA4h6w@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAAAe_zCsaf=WedELLjqLe3BV_8dWiO1DPDGA9sXj4qhe+=-XXw@mail.gmail.com>
	<[email protected]>
	<CAAAe_zChW=nM9J18wdF2wMa2KesFO53fkbVRudkJ_bstdxzfOQ@mail.gmail.com>
	<CAAAe_zADXbf9aGu-54RTRJPhxYmA1gb_8GV94Q0gAftfv79pjA@mail.gmail.com>
	<CAAAe_zDR8XqOfYL1ay5o6Y2OogJNed3oR+aG=Hm1Ja=t=v6=bw@mail.gmail.com>
	<CACJufxHJG_FWo2e+jyG9ynfE0+65eEWA_6qq1mEJO1z3G2V8Hg@mail.gmail.com>
	<CACJufxE80E13g575_ywVjDat-Lmmx3WkukzqRvb936P0jA4h6w@mail.gmail.com>

Hi jian,

Thanks -- this is a clean improvement, no objections. Honestly this part of
the
parser is an area where you read it better than I do, so I'm glad to defer
to
you here. Quick notes inline.

> The above comments can be deleted, ParseRPRNavCall, ParseFuncOrColumn
> already have lots of comments.
> Also the error check and its message are quite intuitive in
ParseRPRNavCall.

Agreed.

> So, I tended to use coerce_to_target_type.

Agreed.

> ParseRPRNavCall ending can be simplified because coerce_to_target_type
> can handle the same data type.
> Therefore, `if (offtype != INT8OID)` is not necessary.

Agreed.

> Drop the extra parentheses around ereport() argument lists, fewer
> parentheses are always better for new code.

Agreed.

Tatsuo, this one looks good to take whenever you like.

Best,
Henson

view thread (181+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <CAAAe_zAjkjUZHMqu5DjgZH9ZZ6D5v4bBJy60ziwhHRoohnB7Zg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox