public inbox for [email protected]  

help / color / mirror / Atom feed

From: Henson Choi <[email protected]>
To: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Fri, 5 Jun 2026 08:24:05 +0900
Message-ID: <CAAAe_zBdR_23drKa38cyejE1YZ+4PtasVXGJ++uSeqpvXgJeOQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAAAe_zBi1dOtWb2vnwSvGwuU0-bqAOm_7dOM4u-CmukA8xaV5Q@mail.gmail.com>
	<CAAAe_zAuHwqUfqJOD4PDUkWsxTfTytNaandq11Kddw2bfCcpvQ@mail.gmail.com>
	<p7r5bekdbl2zcazid7agvfo2nfnq5bim2a5jkckqygld32n325@fctfp6ou6qnb>
	<[email protected]>

> Henson,
> Do you have any idea?

Let me be honest about this one.

I think the root issue is that none of us working on the patch has
enough confidence -- enough real control -- over the tuple slot and JIT
side of it. I wrote the code, it ran fine for me, and I assumed that
meant it was fine; but I have never felt that I fully understand and
control that area. So I cannot point to a specific cause with confidence
yet, and I would rather say that plainly than guess.

One practical note: there have been no tuple slot or JIT changes in the
patch since v47, and none are planned. So that part has been stable, and
reviewing the tuple slot / JIT code against v47 is perfectly viable --
there is no need to wait for a newer revision to look at that area.

What I think would genuinely harden the patch is for someone who knows
tuple slots and JIT well to review -- or rewrite -- that part. I would
very much welcome that, and I am happy to provide the design direction
behind the current code, or any other information a reviewer would need.

To be fair, the same caveat applies to the existing planner code the
patch builds on. I feel I have a reasonable grip on the rest of the
patch, but not on those two areas.

I will keep digging on my side (trying to reproduce the JIT crash with
JIT forced on against the current versions), and report back with
anything concrete I find.

Regards,
Henson

view thread (109+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <CAAAe_zBdR_23drKa38cyejE1YZ+4PtasVXGJ++uSeqpvXgJeOQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox