MIME-Version: 1.0
References: <20260417.171022.397021509290810631.ishii@postgresql.org>
 <20260417.191303.359804214243525887.ishii@postgresql.org>
 <CAAAe_zAkzx7bq-nM8YVg0ukzOnWoB-dNhfjDnRcvoOEFbnV+Vg@mail.gmail.com>
 <CAAAe_zB7rAEJtT6hXgF85=_Tj8Nti45ZHbQw26gxTF2DBs3hJw@mail.gmail.com>
 <20260417.224708.424973995260396036.ishii@postgresql.org>
In-Reply-To: <20260417.224708.424973995260396036.ishii@postgresql.org>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Fri, 17 Apr 2026 23:24:37 +0900
Message-ID: 
 <CAAAe_zBju06XD97Yj30zmZJ+HL-E3U9J5Ok+Oir8D0cJU_+9ag@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: zsolt.parragi@percona.com, sjjang112233@gmail.com,
 vik@postgresfriends.org,
	er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com,
	peter@eisentraut.org, pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="0000000000002b4d39064fa8b667"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAAe_zBju06XD97Yj30zmZJ%2BHL-E3U9J5Ok%2BOir8D0cJU_%2B9ag%40mail.gmail.com>
Precedence: bulk

--0000000000002b4d39064fa8b667
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Tatsuo,

You are right. I checked and found the 0006 patch I applied was wrong
> one.
>
> Sorry for confusion.
>

No worries. Having 31 patches in the series is bound to cause
confusion =E2=80=94 that is on me for sending such a large set at once.

t-ishii$ git log --oneline -10|cat
> 6dd0765463a Row pattern recognition patch (typedefs.list).
> c71940f9e21 Row pattern recognition patch for raw parser.
> 322bab79744 Move declarations related to locktags from lock.h to new
> locktag.h
>

Thank you for the log. I can see that your base is the original v46
application, while mine is the cfbot rebase from April 1
(732acf9b7c6).

No, the commit is not in my working tree.
>
> So I guess I should have rebased v46 tree so that the commit is in the
> work tree before applying your patches. Am I correct?
>

Since the root cause was the patch file mix-up, a rebase would not
have been necessary in this case. That said, the related fix that
went into master ("Fix integer overflow in nodeWindowAgg.c") touches
the same file as several of my patches, so it may cause conflicts
when applying v47. Please let me know if anything is difficult to
resolve.

Let me check the crash first. Since apparently the crash was caused by
> my mis operation.
>

Once confirmed, I will send the corrected patches first.

Regarding the README.rpr suggestion from the 0008 review: the
documentation in execRPR.c has dependencies spread across the patch
series, so separating it mid-review would be disruptive. I plan to
split it out as part of the final patch list once all 31 patches have
been reviewed.

I prefer this way.


Good =E2=80=94 I will continue folding review feedback into the relevant
existing patches. Patch numbers and subjects will stay stable across
revisions.

Regards,
Henson

--0000000000002b4d39064fa8b667
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Tatsuo,</div><div dir=3D"ltr"><br></di=
v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">
You are right. I checked and found the 0006 patch I applied was wrong<br>
one.<br><br>
Sorry for confusion.<br></blockquote><div><br></div><div>No worries. Having=
 31 patches in the series is bound to cause<br>confusion =E2=80=94 that is =
on me for sending such a large set at once.<br></div></div><div class=3D"gm=
ail_quote gmail_quote_container"><br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex">
t-ishii$ git log --oneline -10|cat<br>
6dd0765463a Row pattern recognition patch (typedefs.list).<br>c71940f9e21 R=
ow pattern recognition patch for raw parser.<br>
322bab79744 Move declarations related to locktags from lock.h to new lockta=
g.h<br></blockquote><div><br></div><div>Thank you for the log. I can see th=
at your base is the original v46<br>application, while mine is the cfbot re=
base from April 1<br>(732acf9b7c6).<br></div><div><br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">
No, the commit is not in my working tree.<br>
<br>
So I guess I should have rebased v46 tree so that the commit is in the<br>
work tree before applying your patches. Am I correct?<br></blockquote><div>=
<br></div>Since the root cause was the patch file mix-up, a rebase would no=
t<br>have been necessary in this case. That said, the related fix that<br>w=
ent into master (&quot;Fix integer overflow in nodeWindowAgg.c&quot;) touch=
es<br>the same file as several of my patches, so it may cause conflicts<br>=
when applying v47. Please let me know if anything is difficult to<br><div>r=
esolve.=C2=A0</div><div><br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Let me check the crash first. Since apparently the crash was cau=
sed by<br>
my mis operation.<br></blockquote><div><br></div><div>Once confirmed, I wil=
l send the corrected patches first.<br><br>Regarding the README.rpr suggest=
ion from the 0008 review: the<br>documentation in execRPR.c has dependencie=
s spread across the patch<br>series, so separating it mid-review would be d=
isruptive. I plan to<br>split it out as part of the final patch list once a=
ll 31 patches have<br>been reviewed.<br></div><div><br></div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex">I prefer this way.</blockquote><div><br=
></div>Good =E2=80=94 I will continue folding review feedback into the rele=
vant<br>existing patches. Patch numbers and subjects will stay stable acros=
s<br>revisions.<br><br>Regards,<br><div>Henson</div></div></div>

--0000000000002b4d39064fa8b667--