MIME-Version: 1.0
References: <20260302.141823.129040280886273031.ishii@postgresql.org>
 <CAN4CZFOEpz6vXitAkcCGixzAzp4uRRahyScWixKQZU=K4tngtQ@mail.gmail.com>
 <CAAAe_zAFv0E_EhFxZueJ1n9pZpPaTVChMhDmndzugzovgz0o2Q@mail.gmail.com>
 <20260312.092125.2016894123875469735.ishii@postgresql.org>
In-Reply-To: <20260312.092125.2016894123875469735.ishii@postgresql.org>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Thu, 12 Mar 2026 09:39:57 +0900
Message-ID: 
 <CAAAe_zDAQWje=SK65hstqEwMgbQGRH4P1=5yOmvgT7m2Mz8Qbw@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: zsolt.parragi@percona.com, vik@postgresfriends.org, er@xs4all.nl,
	jacob.champion@enterprisedb.com, david.g.johnston@gmail.com,
	peter@eisentraut.org, pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="0000000000009e922e064cc8fe6e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAAe_zDAQWje%3DSK65hstqEwMgbQGRH4P1%3D5yOmvgT7m2Mz8Qbw%40mail.gmail.com>
Precedence: bulk

--0000000000009e922e064cc8fe6e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2026=EB=85=84 3=EC=9B=94 12=EC=9D=BC (=EB=AA=A9) AM 9:21, Tatsuo Ishii <ish=
ii@postgresql.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:

> Hi Zsolt,
>
> Thanks for the report and the test case!
>
> > Good catch, Zsolt. You're right =E2=80=95 the return value of
> > coerce_to_boolean() must be assigned back to te->expr, otherwise
> > any implicit cast (e.g., a user-defined type with an assignment
> > cast to boolean) is silently discarded.
> >
> > The fix is straightforward:
> >
> >     foreach_ptr(TargetEntry, te, defineClause)
> >         te->expr =3D (Expr *) coerce_to_boolean(pstate, (Node *) te->ex=
pr,
> > "DEFINE");
> >
> > I've confirmed that your example query produces incorrect results
> > without the fix (the truthyint value is evaluated as-is without
> > the cast) and correct results with it.
> >
> > Patch 13 is attached with the fix and a regression test case based
> > on your example.
>
> Yeah, current patch needs to be fixed. Question is, the output of the
> expression of DEFINE clause must be a strict boolean or, it is allowed
> to accept an expression coercive to boolean?
>
> If we prefer the former, we should use exprType() instead.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>

--0000000000009e922e064cc8fe6e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote gmail_quote_contai=
ner"><div dir=3D"ltr" class=3D"gmail_attr">2026=EB=85=84 3=EC=9B=94 12=EC=
=9D=BC (=EB=AA=A9) AM 9:21, Tatsuo Ishii &lt;<a href=3D"mailto:ishii@postgr=
esql.org">ishii@postgresql.org</a>&gt;=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1=
:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.=
8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204=
,204,204);padding-left:1ex">Hi Zsolt,<br>
<br>
Thanks for the report and the test case!<br>
<br>
&gt; Good catch, Zsolt. You&#39;re right =E2=80=95 the return value of<br>
&gt; coerce_to_boolean() must be assigned back to te-&gt;expr, otherwise<br=
>
&gt; any implicit cast (e.g., a user-defined type with an assignment<br>
&gt; cast to boolean) is silently discarded.<br>
&gt; <br>
&gt; The fix is straightforward:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0foreach_ptr(TargetEntry, te, defineClause)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0te-&gt;expr =3D (Expr *) coerce_to_bo=
olean(pstate, (Node *) te-&gt;expr,<br>
&gt; &quot;DEFINE&quot;);<br>
&gt; <br>
&gt; I&#39;ve confirmed that your example query produces incorrect results<=
br>
&gt; without the fix (the truthyint value is evaluated as-is without<br>
&gt; the cast) and correct results with it.<br>
&gt; <br>
&gt; Patch 13 is attached with the fix and a regression test case based<br>
&gt; on your example.<br>
<br>
Yeah, current patch needs to be fixed. Question is, the output of the<br>
expression of DEFINE clause must be a strict boolean or, it is allowed<br>
to accept an expression coercive to boolean?<br>
<br>
If we prefer the former, we should use exprType() instead.<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS K.K.<br>
English: <a href=3D"http://www.sraoss.co.jp/index_en/" rel=3D"noreferrer" t=
arget=3D"_blank">http://www.sraoss.co.jp/index_en/</a><br>
Japanese:<a href=3D"http://www.sraoss.co.jp" rel=3D"noreferrer" target=3D"_=
blank">http://www.sraoss.co.jp</a><br>
</blockquote></div>

--0000000000009e922e064cc8fe6e--