Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5DRi-00319b-1m for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Mar 2026 01:54:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w5DRg-00AJQt-2s for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Mar 2026 01:54:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5DRg-00AJQk-1Y for pgsql-hackers@lists.postgresql.org; Wed, 25 Mar 2026 01:54:09 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w5DRf-00000000t0f-0SIy for pgsql-hackers@lists.postgresql.org; Wed, 25 Mar 2026 01:54:08 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2addb31945aso45088795ad.1 for ; Tue, 24 Mar 2026 18:54:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774403646; cv=none; d=google.com; s=arc-20240605; b=k9Vw+9I6i1k3igmGwyoRSpDHsb+/2iSP4O7vpGOGpEcK1xd3/CBFoknJEpYo6IwUh9 ZdmUFX2DrBpN2dd37niPvqqu9MDLnIYdPfT95Ac4GRzFBB3Ne0SbN6baf5JuXbdGyW/r K1rP2QTfjMkTctveX9xRMNRnDJreO4Imb4ziulI+F8iywE6WFuHc8HietBindpNjocE3 CBUhrs2WRYDztKJVhK8IufmNLawdT+Y7iUyEldbFbNppzRsBL5F5HgVuhft/VqGpkwOQ uVYtD1Ga9XhCjtFIpZNXMAIirg+jEeTK3XelJ8gWnznOjfO/1EhOx5kZmJU2J44QJwpa UQIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:dkim-signature; bh=ioUemXlQ/c0Xj/EJu2L9ddBgGptLefaVKa+EGfKvRO8=; fh=ASSukbW8z3l5TI56kM6TPIZeqorlGpfKejxKZasA10o=; b=HDO6kjqYm/7mIls8fBDPYBd7W0W2cVcW7LFKftLkJA9SgOC25SKr6gAdpS5wycytHh Ina0uq7biP7E8oi7Cp/95FA/d5csWELn+vu2haIM6qVoAnZxdjSgtc04/+z4cJuj5VV3 2peKLV3x1uQlkDwSsw/iSxnYem0KcfYQ4SUXX1FoU9Vl8ZbM5JMtjUTZfYuO2tAaiARn X5NgOKDGmUcr87eo+GuvpzTfVfjLSfJAgA3N9s3M1x3lhq1HJMM8f4b1wZZklIo2PYpw YNS5R8uiR/ISeMAUQDQGgJge2yGl87GrUK/FVjXR6uHgmTOvJSl6LdO+HhuVv8Q51xF2 T5Yw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774403646; x=1775008446; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ioUemXlQ/c0Xj/EJu2L9ddBgGptLefaVKa+EGfKvRO8=; b=JTKLz0fKNt7kHgSNyOrwFkREijizYfCszIuMqX7TL+LmXxurxrICr9Iib8MxGyz5+Z ZD/yi4rshlXLjunpExTeHnlb5bAOx5lKnnUzn8oVhMsIwNS85Aeyg3g4B/13NRPKnXO8 GIPp5L7uSoVgHcJ2lfNvGYzoKCJbO8VfGBLQZ5LjQG9CbVHHk4Yb6xIh5CXi/onc/hC2 za/UivNgyxcZ2KZFw0qllfH5ZKrDRbBFEl1WzKWw9EBy002wc+q3181uADDj4gTkL8fh s8KAyvTqOkwHvt+NwCBMV3efd8BQiIvCjeuqskb4i/IgCtwgigBpcnORGMP+jAMCwDfa 7pTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774403646; x=1775008446; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ioUemXlQ/c0Xj/EJu2L9ddBgGptLefaVKa+EGfKvRO8=; b=qZ6NRzxblK+TXqXgjB8sX+kIFAo+gOzUyqrp7CBhrYA/whM7PjxyI7dVlXBdE6Qqfq 2pCNuJCTjjecnub+kIFwkAOJMAQXvDxtPH8h5v/6m1k34N/ek7wQ2OljejBBP7NIPvMm Z/Hg7p82vtd50uMgwe5hud5tyZ/eO8Q5JVFqXB+FBF2acXjazhE5my0bZ8Bz133ywcTQ KywYPDFruyX/NukqxruBT9+4z/fqzRyY/ktbOoYa/NJ+RkLnQtllCnw9WuXs4PzFo/QQ AKKUb8EgG2IsnxPhjwufKXmnlpLujPKJM8CBk8u81zwfkETrH7WD4FVkZbEvBs+XtpH3 EA9A== X-Gm-Message-State: AOJu0Yw95/DXaqg6MVz+LwZPHt4TyFBHJOvMfE7IwFlUmyuCWnOwpCue wHx7sJdHzWYIWhhXvJCLRPxYnpbinDZFq9Zo58KkC79fGXidrHri+RzW8bHLr50KcikOlGt5g4y s61/5vbM7NhSgA862qxWdVBYxlFA8/Y4= X-Gm-Gg: ATEYQzxGM3IwA1Me4XI5EdaHAhvZqxF2ZqF/uPRjoiCVGKLicKPm5yrnQk7lUnS66nm dp8rY7vioFdbbtP8eyX/ygM0cEnjsaqNk5UnRrJkqgCdPOzZdLt1LpA2qDojHqNgKlCy5vdxd2U RuTSTCASzbJCpjBGCmxYelFiEKwK4iktiG4uVTvC/xF+xkY49hmrinnmvnVFWxRGgFRd1VXhG2U aobLv2WcWE4TGNe6KW9b2y6KB9WEWoDkaz8uHEvBDXZAI9TPQOmefpXP1AEq1SDR/+Crlw4AsOp 5sE50cbuyfGLgI3J3qA7OSqJVwSn1ZzLFsUpwE4FUUsntI+7aw== X-Received: by 2002:a17:902:c40f:b0:2b0:571f:6f07 with SMTP id d9443c01a7336-2b0b0b00b77mr18859665ad.39.1774403646304; Tue, 24 Mar 2026 18:54:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Reply-To: assam258@gmail.com From: Henson Choi Date: Wed, 25 Mar 2026 10:53:55 +0900 X-Gm-Features: AaiRm51BLcd-vKLob4Eq19pzduVsJZN0Moc-lZ818AQPqTt6ZDR0AOFitbRwJng Message-ID: Subject: Re: Minor refactor of the code in ExecScanExtended() To: Aditya Gollamudi , cca5507 Cc: pgsql-hackers Content-Type: multipart/alternative; boundary="00000000000006b3ae064dcf8b48" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000006b3ae064dcf8b48 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi hackers, 2026=EB=85=84 1=EC=9B=94 19=EC=9D=BC (=EC=9B=94) PM 1:51, Aditya Gollamudi = =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > On Sun, Jan 18, 2026 at 7:31=E2=80=AFPM cca5507 wrote: > >> Hi, >> >> The current code: >> >> if (!qual && !projInfo) >> { >> ResetExprContext(econtext); >> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd); >> } >> >> ResetExprContext(econtext); >> >> The following format might be simpler: >> >> ResetExprContext(econtext); >> >> if (!qual && !projInfo) >> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd); >> >> Attach a patch to do this. >> >> -- >> Regards, >> ChangAo Chen >> >> Hi, > > +1, seems like a simple refactor. > Tests are passing locally for me! > > - Adi Gollamudi > +1, agreed. The refactored version is cleaner and easier to read by moving ResetExprContext() before the early return, eliminating the duplicated logic. Best regards, Henson --00000000000006b3ae064dcf8b48 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi hackers,

2026=EB=85=84 = 1=EC=9B=94 19=EC=9D=BC (=EC=9B=94) PM 1:51, Aditya Gollamudi <adigollamudi@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
Hi,

The= current code:

=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82if (!qual &&= amp; !projInfo)
=E2=80=82=E2=80=82=E2=80=82= =E2=80=82=E2=80=82=E2=80=82{
=E2=80=82=E2=80= =82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82= =E2=80=82=E2=80=82ResetExprContext(econtext);
=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82= =E2=80=82=E2=80=82=E2=80=82=E2=80=82return ExecScanFetch(node, epqstate, ac= cessMtd, recheckMtd);
=E2=80=82=E2=80=82=E2= =80=82=E2=80=82=E2=80=82=E2=80=82}

=
=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82ResetExprContext(econtext);

<= div style=3D"line-height:1.43;font-family:-apple-system,system-ui;font-size= :14px;color:rgb(0,0,0)">The following format might be simpler:

=E2=80=82=E2=80=82=E2= =80=82=E2=80=82=E2=80=82=E2=80=82ResetExprContext(econtext);

=E2=80=82=E2=80=82=E2=80= =82=E2=80=82=E2=80=82=E2=80=82if (!qual && !projInfo)
=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82return ExecScanFetch(nod= e, epqstate, accessMtd, recheckMtd);

Attach a patch to do this.

--
ChangAo Chen

Hi,=C2=A0

+1,= seems like a simple refactor.=C2=A0
Tests are passing locally fo= r me!

- Adi Gollamudi=C2=A0


The refactored version is cle= aner and easier to read by moving
ResetExprContext() before the e= arly return,
eliminating the duplicated logic.

Best regards,
Henson
--00000000000006b3ae064dcf8b48--