MIME-Version: 1.0
From: Amul Sul <sulamul@gmail.com>
Date: Fri, 17 Apr 2026 18:24:58 +0530
Message-ID: 
 <CAAJ_b95-xMvUN1PEqxv8y6g-A-8k+fSgyv20kSZc9eF1wZAUPg@mail.gmail.com>
Subject: Cleanup: Use modern macro for text-to-CString conversion in
 plsample.c
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000001debe4064fa77721"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAJ_b95-xMvUN1PEqxv8y6g-A-8k%2BfSgyv20kSZc9eF1wZAUPg%40mail.gmail.com>
Precedence: bulk

--0000000000001debe4064fa77721
Content-Type: text/plain; charset="UTF-8"

Hi,

I noticed that plsample.c uses an outdated method to convert text data
to a C string. This old method calls the textout function manually,
which adds unnecessary overhead.

The attached patch replaces this with the TextDatumGetCString() macro.
This macro is more efficient and automatically handles "detoasting"
(decompressing/fetching) the data.

Since plsample serves as a template for developers writing new
extensions, it should follow current best practices. This patch
updates the code in both the function and trigger handlers.

--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

--0000000000001debe4064fa77721
Content-Type: application/x-patch;
	name="0001-plsample-Use-TextDatumGetCString-for-text-to-CString.patch"
Content-Disposition: attachment;
	filename="0001-plsample-Use-TextDatumGetCString-for-text-to-CString.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo2wof0k0>
X-Attachment-Id: f_mo2wof0k0

RnJvbSAzMjkwYzk0ZDY4MzljMWUwZTI1ZjJiNmY1NTI5MWI5ZDBkMjY2MzI3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbXVsIFN1bCA8c3VsYW11bEBnbWFpbC5jb20+CkRhdGU6IEZy
aSwgMTcgQXByIDIwMjYgMTg6MTI6NDEgKzA1MzAKU3ViamVjdDogW1BBVENIXSBwbHNhbXBsZTog
VXNlIFRleHREYXR1bUdldENTdHJpbmcoKSBmb3IgdGV4dC10by1DU3RyaW5nCiBjb252ZXJzaW9u
LgoKUmVwbGFjZSB0aGUgb3V0ZGF0ZWQgRGF0dW1HZXRDU3RyaW5nKERpcmVjdEZ1bmN0aW9uQ2Fs
bDEodGV4dG91dCwgLi4uKSkKcGF0dGVybiB3aXRoIFRleHREYXR1bUdldENTdHJpbmcoKS4gVGhl
IG1hY3JvIGlzIHRoZSBtb2Rlcm4sIG1vcmUKZWZmaWNpZW50IHdheSB0byBjb252ZXJ0IGEgdGV4
dCBEYXR1bSB0byBhIEMgc3RyaW5nIGFzIGl0IGF2b2lkcwp1bm5lY2Vzc2FyeSBmdW5jdGlvbiBj
YWxsIG1hY2hpbmVyeSBhbmQgaGFuZGxlcyBkZXRvYXN0aW5nIGludGVybmFsbHkuCgpTaW5jZSBw
bHNhbXBsZSBzZXJ2ZXMgYXMgcmVmZXJlbmNlIGNvZGUgZm9yIGV4dGVuc2lvbiBhdXRob3JzLCBp
dApzaG91bGQgZm9sbG93IGN1cnJlbnQgaWRpb21hdGljIHByYWN0aWNlcy4KLS0tCiBzcmMvdGVz
dC9tb2R1bGVzL3Bsc2FtcGxlL3Bsc2FtcGxlLmMgfCA1ICsrKy0tCiAxIGZpbGUgY2hhbmdlZCwg
MyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21v
ZHVsZXMvcGxzYW1wbGUvcGxzYW1wbGUuYyBiL3NyYy90ZXN0L21vZHVsZXMvcGxzYW1wbGUvcGxz
YW1wbGUuYwppbmRleCAyOTI0OGJkNzBlYi4uZjI5NGY1Y2E0YWQgMTAwNjQ0Ci0tLSBhL3NyYy90
ZXN0L21vZHVsZXMvcGxzYW1wbGUvcGxzYW1wbGUuYworKysgYi9zcmMvdGVzdC9tb2R1bGVzL3Bs
c2FtcGxlL3Bsc2FtcGxlLmMKQEAgLTIxLDYgKzIxLDcgQEAKICNpbmNsdWRlICJjb21tYW5kcy90
cmlnZ2VyLmgiCiAjaW5jbHVkZSAiZXhlY3V0b3Ivc3BpLmgiCiAjaW5jbHVkZSAiZnVuY2FwaS5o
IgorI2luY2x1ZGUgInV0aWxzL2J1aWx0aW5zLmgiCiAjaW5jbHVkZSAidXRpbHMvZm1ncnByb3Rv
cy5oIgogI2luY2x1ZGUgInV0aWxzL2xzeXNjYWNoZS5oIgogI2luY2x1ZGUgInV0aWxzL3N5c2Nh
Y2hlLmgiCkBAIC0xMjgsNyArMTI5LDcgQEAgcGxzYW1wbGVfZnVuY19oYW5kbGVyKFBHX0ZVTkNU
SU9OX0FSR1MpCiAJaWYgKGlzbnVsbCkKIAkJZWxvZyhFUlJPUiwgImNvdWxkIG5vdCBmaW5kIHNv
dXJjZSB0ZXh0IG9mIGZ1bmN0aW9uIFwiJXNcIiIsCiAJCQkgcHJvbmFtZSk7Ci0Jc291cmNlID0g
RGF0dW1HZXRDU3RyaW5nKERpcmVjdEZ1bmN0aW9uQ2FsbDEodGV4dG91dCwgcmV0KSk7CisJc291
cmNlID0gVGV4dERhdHVtR2V0Q1N0cmluZyhyZXQpOwogCWVyZXBvcnQoTk9USUNFLAogCQkJKGVy
cm1zZygic291cmNlIHRleHQgb2YgZnVuY3Rpb24gXCIlc1wiOiAlcyIsCiAJCQkJCXByb25hbWUs
IHNvdXJjZSkpKTsKQEAgLTI0NCw3ICsyNDUsNyBAQCBwbHNhbXBsZV90cmlnZ2VyX2hhbmRsZXIo
UEdfRlVOQ1RJT05fQVJHUykKIAlpZiAoaXNudWxsKQogCQllbG9nKEVSUk9SLCAiY291bGQgbm90
IGZpbmQgc291cmNlIHRleHQgb2YgZnVuY3Rpb24gXCIlc1wiIiwKIAkJCSBwcm9uYW1lKTsKLQlz
b3VyY2UgPSBEYXR1bUdldENTdHJpbmcoRGlyZWN0RnVuY3Rpb25DYWxsMSh0ZXh0b3V0LCByZXQp
KTsKKwlzb3VyY2UgPSBUZXh0RGF0dW1HZXRDU3RyaW5nKHJldCk7CiAJZXJlcG9ydChOT1RJQ0Us
CiAJCQkoZXJybXNnKCJzb3VyY2UgdGV4dCBvZiBmdW5jdGlvbiBcIiVzXCI6ICVzIiwKIAkJCQkJ
cHJvbmFtZSwgc291cmNlKSkpOwotLSAKMi40Ny4xCgo=
--0000000000001debe4064fa77721--