MIME-Version: 1.0
References: 
 <CAAJ_b97mG=6ybUYE8nQyDfKkhaxTCD8rE8s6L8efNmqHaUYNWQ@mail.gmail.com>
 <DIA0EJH2KL60.29M1F14V8I9V7@partin.io>
In-Reply-To: <DIA0EJH2KL60.29M1F14V8I9V7@partin.io>
From: Amul Sul <sulamul@gmail.com>
Date: Tue, 5 May 2026 12:53:33 +0530
Message-ID: 
 <CAAJ_b974KcAQ=XMBfw-iy2tnbwNk9YnSA5XcQctf7N0GUSDRQA@mail.gmail.com>
Subject: Re: Cleanup: Replace sscanf with strtol/strtoul in snapmgr
To: Tristan Partin <tristan@partin.io>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000fe4d7a06510cee0b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAJ_b974KcAQ%3DXMBfw-iy2tnbwNk9YnSA5XcQctf7N0GUSDRQA%40mail.gmail.com>
Precedence: bulk

--000000000000fe4d7a06510cee0b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 4, 2026 at 9:19=E2=80=AFPM Tristan Partin <tristan@partin.io> w=
rote:
>
> On Mon Apr 20, 2026 at 12:07 AM CDT, Amul Sul wrote:
> The patch generally looks good. One comment:
>
> > @@ -1359,17 +1365,36 @@ parseVxidFromText(const char *prefix, char **s,=
 const char *filename,
> >  {
> >         char       *ptr =3D *s;
> >         int                     prefixlen =3D strlen(prefix);
> > +       long            lval;
> > +       unsigned long ulval;
>
> Perhaps better variable names would be procNumber and
> localTransactionId.
>

Thanks, Andreas and Tristan, for the review !

I have renamed the variables as suggested but used the shorter forms
procno and xid instead of procNumber and localTransactionId. I also
applied similar changes to parseXidFromText (changing val to xid), but
kept val in parseIntFromText since it seems to be more appropriate for
a generic integer value.

Updated patch attached.

Regards,
Amul

--000000000000fe4d7a06510cee0b
Content-Type: application/octet-stream;
	name="v2-0001-snapmgr-replace-sscanf-with-strtol-strtoul-in-sna.patch"
Content-Disposition: attachment;
	filename="v2-0001-snapmgr-replace-sscanf-with-strtol-strtoul-in-sna.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mosatdvi0>
X-Attachment-Id: f_mosatdvi0

RnJvbSA1ODNkYzM2NDI2NTA4YjczMzY0YTY4MWJlNmVkMjllMWE0ZDg3ODA4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbXVsIFN1bCA8c3VsYW11bEBnbWFpbC5jb20+CkRhdGU6IE1v
biwgMjAgQXByIDIwMjYgMTA6MjE6MjggKzA1MzAKU3ViamVjdDogW1BBVENIIHYyXSBzbmFwbWdy
OiByZXBsYWNlIHNzY2FuZiB3aXRoIHN0cnRvbC9zdHJ0b3VsIGluIHNuYXBzaG90CiBwYXJzZSBo
ZWxwZXJzCgpwYXJzZUludEZyb21UZXh0LCBwYXJzZVhpZEZyb21UZXh0LCBhbmQgcGFyc2VWeGlk
RnJvbVRleHQgdXNlZCBzc2NhbmYKdG8gY29udmVydCBkaWdpdCBzdHJpbmdzIHRvIGludGVnZXJz
LiAgUmVwbGFjZSB3aXRoIHN0cnRvbC9zdHJ0b3VsLAp3aGljaCBwcm92aWRlIGV4cGxpY2l0IG92
ZXJmbG93IGRldGVjdGlvbiBhbmQgYWR2YW5jZSB0aGUgZW5kLXBvaW50ZXIKZGlyZWN0bHksIGF2
b2lkaW5nIGEgcmVkdW5kYW50IHN0cmNociBzY2FuIG92ZXIgdGhlIGFscmVhZHktcGFyc2VkCmRp
Z2l0cy4KLS0tCiBzcmMvYmFja2VuZC91dGlscy90aW1lL3NuYXBtZ3IuYyB8IDQ3ICsrKysrKysr
KysrKysrKysrKysrKysrKystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygr
KSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvdGltZS9z
bmFwbWdyLmMgYi9zcmMvYmFja2VuZC91dGlscy90aW1lL3NuYXBtZ3IuYwppbmRleCAxMGZlMThk
ZjJlNy4uMjdhMGVjODM1ZTggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL3RpbWUvc25h
cG1nci5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL3RpbWUvc25hcG1nci5jCkBAIC0xMzA4LDI0
ICsxMzA4LDI4IEBAIHBhcnNlSW50RnJvbVRleHQoY29uc3QgY2hhciAqcHJlZml4LCBjaGFyICoq
cywgY29uc3QgY2hhciAqZmlsZW5hbWUpCiB7CiAJY2hhcgkgICAqcHRyID0gKnM7CiAJaW50CQkJ
cHJlZml4bGVuID0gc3RybGVuKHByZWZpeCk7Ci0JaW50CQkJdmFsOworCWxvbmcJCXZhbDsKKwlj
aGFyCSAgICplbmRwdHI7CiAKIAlpZiAoc3RybmNtcChwdHIsIHByZWZpeCwgcHJlZml4bGVuKSAh
PSAwKQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9URVhU
X1JFUFJFU0VOVEFUSU9OKSwKIAkJCQkgZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGRhdGEgaW4g
ZmlsZSBcIiVzXCIiLCBmaWxlbmFtZSkpKTsKIAlwdHIgKz0gcHJlZml4bGVuOwotCWlmIChzc2Nh
bmYocHRyLCAiJWQiLCAmdmFsKSAhPSAxKQorCWVycm5vID0gMDsKKwl2YWwgPSBzdHJ0b2wocHRy
LCAmZW5kcHRyLCAxMCk7CisJaWYgKGVuZHB0ciA9PSBwdHIgfHwgZXJybm8gIT0gMCB8fAorCQl2
YWwgPCBJTlRfTUlOIHx8IHZhbCA+IElOVF9NQVgpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVy
cmNvZGUoRVJSQ09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAogCQkJCSBlcnJtc2co
ImludmFsaWQgc25hcHNob3QgZGF0YSBpbiBmaWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkpOwotCXB0
ciA9IHN0cmNocihwdHIsICdcbicpOworCXB0ciA9IHN0cmNocihlbmRwdHIsICdcbicpOwogCWlm
ICghcHRyKQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9U
RVhUX1JFUFJFU0VOVEFUSU9OKSwKIAkJCQkgZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGRhdGEg
aW4gZmlsZSBcIiVzXCIiLCBmaWxlbmFtZSkpKTsKIAkqcyA9IHB0ciArIDE7Ci0JcmV0dXJuIHZh
bDsKKwlyZXR1cm4gKGludCkgdmFsOwogfQogCiBzdGF0aWMgVHJhbnNhY3Rpb25JZApAQCAtMTMz
MywyNCArMTMzNywyNyBAQCBwYXJzZVhpZEZyb21UZXh0KGNvbnN0IGNoYXIgKnByZWZpeCwgY2hh
ciAqKnMsIGNvbnN0IGNoYXIgKmZpbGVuYW1lKQogewogCWNoYXIJICAgKnB0ciA9ICpzOwogCWlu
dAkJCXByZWZpeGxlbiA9IHN0cmxlbihwcmVmaXgpOwotCVRyYW5zYWN0aW9uSWQgdmFsOworCXVu
c2lnbmVkIGxvbmcgeGlkOworCWNoYXIJICAgKmVuZHB0cjsKIAogCWlmIChzdHJuY21wKHB0ciwg
cHJlZml4LCBwcmVmaXhsZW4pICE9IDApCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVycmNvZGUo
RVJSQ09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAogCQkJCSBlcnJtc2coImludmFs
aWQgc25hcHNob3QgZGF0YSBpbiBmaWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkpOwogCXB0ciArPSBw
cmVmaXhsZW47Ci0JaWYgKHNzY2FuZihwdHIsICIldSIsICZ2YWwpICE9IDEpCisJZXJybm8gPSAw
OworCXhpZCA9IHN0cnRvdWwocHRyLCAmZW5kcHRyLCAxMCk7CisJaWYgKGVuZHB0ciA9PSBwdHIg
fHwgZXJybm8gIT0gMCB8fCB4aWQgPiBVSU5UX01BWCkKIAkJZXJlcG9ydChFUlJPUiwKIAkJCQko
ZXJyY29kZShFUlJDT0RFX0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCiAJCQkJIGVycm1z
ZygiaW52YWxpZCBzbmFwc2hvdCBkYXRhIGluIGZpbGUgXCIlc1wiIiwgZmlsZW5hbWUpKSk7Ci0J
cHRyID0gc3RyY2hyKHB0ciwgJ1xuJyk7CisJcHRyID0gc3RyY2hyKGVuZHB0ciwgJ1xuJyk7CiAJ
aWYgKCFwdHIpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9JTlZBTElE
X1RFWFRfUkVQUkVTRU5UQVRJT04pLAogCQkJCSBlcnJtc2coImludmFsaWQgc25hcHNob3QgZGF0
YSBpbiBmaWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkpOwogCSpzID0gcHRyICsgMTsKLQlyZXR1cm4g
dmFsOworCXJldHVybiAoVHJhbnNhY3Rpb25JZCkgeGlkOwogfQogCiBzdGF0aWMgdm9pZApAQCAt
MTM1OSwxNyArMTM2NiwzNyBAQCBwYXJzZVZ4aWRGcm9tVGV4dChjb25zdCBjaGFyICpwcmVmaXgs
IGNoYXIgKipzLCBjb25zdCBjaGFyICpmaWxlbmFtZSwKIHsKIAljaGFyCSAgICpwdHIgPSAqczsK
IAlpbnQJCQlwcmVmaXhsZW4gPSBzdHJsZW4ocHJlZml4KTsKKwlsb25nCQlwcm9jbm87CisJdW5z
aWduZWQgbG9uZyB4aWQ7CisJY2hhcgkgICAqZW5kcHRyOwogCiAJaWYgKHN0cm5jbXAocHRyLCBw
cmVmaXgsIHByZWZpeGxlbikgIT0gMCkKIAkJZXJlcG9ydChFUlJPUiwKIAkJCQkoZXJyY29kZShF
UlJDT0RFX0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCiAJCQkJIGVycm1zZygiaW52YWxp
ZCBzbmFwc2hvdCBkYXRhIGluIGZpbGUgXCIlc1wiIiwgZmlsZW5hbWUpKSk7CiAJcHRyICs9IHBy
ZWZpeGxlbjsKLQlpZiAoc3NjYW5mKHB0ciwgIiVkLyV1IiwgJnZ4aWQtPnByb2NOdW1iZXIsICZ2
eGlkLT5sb2NhbFRyYW5zYWN0aW9uSWQpICE9IDIpCisKKwkvKiBQYXJzZSBwcm9jTnVtYmVyICh0
aGUgc2lnbmVkIGludGVnZXIgYmVmb3JlICcvJykgKi8KKwllcnJubyA9IDA7CisJcHJvY25vID0g
c3RydG9sKHB0ciwgJmVuZHB0ciwgMTApOworCWlmIChlbmRwdHIgPT0gcHRyIHx8IGVycm5vICE9
IDAgfHwKKwkJcHJvY25vIDwgSU5UX01JTiB8fCBwcm9jbm8gPiBJTlRfTUFYIHx8CisJCSplbmRw
dHIgIT0gJy8nKQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJ
RF9URVhUX1JFUFJFU0VOVEFUSU9OKSwKIAkJCQkgZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGRh
dGEgaW4gZmlsZSBcIiVzXCIiLCBmaWxlbmFtZSkpKTsKLQlwdHIgPSBzdHJjaHIocHRyLCAnXG4n
KTsKKwl2eGlkLT5wcm9jTnVtYmVyID0gKFByb2NOdW1iZXIpIHByb2NubzsKKwlwdHIgPSBlbmRw
dHIgKyAxOwkJCS8qIHNraXAgdGhlICcvJyBzZXBhcmF0b3IgKi8KKworCS8qIFBhcnNlIGxvY2Fs
VHJhbnNhY3Rpb25JZCAodGhlIHVuc2lnbmVkIGludGVnZXIgYWZ0ZXIgJy8nKSAqLworCWVycm5v
ID0gMDsKKwl4aWQgPSBzdHJ0b3VsKHB0ciwgJmVuZHB0ciwgMTApOworCWlmIChlbmRwdHIgPT0g
cHRyIHx8IGVycm5vICE9IDAgfHwgeGlkID4gVUlOVF9NQVgpCisJCWVyZXBvcnQoRVJST1IsCisJ
CQkJKGVycmNvZGUoRVJSQ09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAorCQkJCSBl
cnJtc2coImludmFsaWQgc25hcHNob3QgZGF0YSBpbiBmaWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkp
OworCXZ4aWQtPmxvY2FsVHJhbnNhY3Rpb25JZCA9IChMb2NhbFRyYW5zYWN0aW9uSWQpIHhpZDsK
KwlwdHIgPSBzdHJjaHIoZW5kcHRyLCAnXG4nKTsKIAlpZiAoIXB0cikKIAkJZXJlcG9ydChFUlJP
UiwKIAkJCQkoZXJyY29kZShFUlJDT0RFX0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCi0t
IAoyLjQ3LjEKCg==
--000000000000fe4d7a06510cee0b--