MIME-Version: 1.0
References: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
 <CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
 <CALDaNm0zJuUon52OEx5SpMoP8LEGJh+=PyYqwmcD7Zh97_dnJg@mail.gmail.com>
 <CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
 <CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com>
In-Reply-To: 
 <CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com>
From: Amul Sul <sulamul@gmail.com>
Date: Thu, 16 Apr 2026 18:00:38 +0530
Message-ID: 
 <CAAJ_b975xBx_No+i69F5EAcRgDaT-G0h=XPFrqL1n_zBSwKSRQ@mail.gmail.com>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
To: vignesh C <vignesh21@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAAJ_b975xBx_No%2Bi69F5EAcRgDaT-G0h%3DXPFrqL1n_zBSwKSRQ%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 16, 2026 at 4:25=E2=80=AFPM vignesh C <vignesh21@gmail.com> wro=
te:
>
> On Thu, 16 Apr 2026 at 09:42, Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Mon, Apr 13, 2026 at 4:10=E2=80=AFPM vignesh C <vignesh21@gmail.com>=
 wrote:
> > > I felt these also should be updated, the attached v2 version patch
> > > includes the changes for the same.
> >
> > Thanks for updating the patch!
> >
> > -       applyPtr =3D (latestApplyPtr =3D=3D InvalidXLogRecPtr) ?
> > +       applyPtr =3D (XLogRecPtrIsInvalid(latestApplyPtr)) ?
> >
> > XLogRecPtrIsValid() should be used here, instead?

The outer parentheses do not seem to be needed, as
XLogRecPtrIsInvalid() already includes them.

Other than that, the v3 patch looks good to me.

Regards,
Amul