MIME-Version: 1.0
From: Amul Sul <sulamul@gmail.com>
Date: Mon, 20 Apr 2026 10:36:21 +0530
Message-ID: 
 <CAAJ_b97mG=6ybUYE8nQyDfKkhaxTCD8rE8s6L8efNmqHaUYNWQ@mail.gmail.com>
Subject: Cleanup: Replace sscanf with strtol/strtoul in snapmgr
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000b711e1064fdd44fa"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAJ_b97mG%3D6ybUYE8nQyDfKkhaxTCD8rE8s6L8efNmqHaUYNWQ%40mail.gmail.com>
Precedence: bulk

--000000000000b711e1064fdd44fa
Content-Type: text/plain; charset="UTF-8"

Hi,

The attached patch replaces sscanf with strtol and strtoul in the
ImportSnapshot helpers (parseIntFromText, parseXidFromText, and
parseVxidFromText) to improve reliability and efficiency. By utilizing
the end pointer, we can locate the next line without re-scanning the
entire string.

Additionally, this change aligns the snapshot code with the rest of
the Postgres backend, which already favors these functions for safer
parsing.

--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

--000000000000b711e1064fdd44fa
Content-Type: application/x-patch;
	name="0001-snapmgr-replace-sscanf-with-strtol-strtoul-in-snapsh.patch"
Content-Disposition: attachment;
	filename="0001-snapmgr-replace-sscanf-with-strtol-strtoul-in-snapsh.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo6pxjfl0>
X-Attachment-Id: f_mo6pxjfl0

RnJvbSA5ODY5YjlmMTk3NzVkZTdkMTNmMWJhZGE1ZGI1ZDhmMTRiZjIwODU5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbXVsIFN1bCA8c3VsYW11bEBnbWFpbC5jb20+CkRhdGU6IE1v
biwgMjAgQXByIDIwMjYgMTA6MjE6MjggKzA1MzAKU3ViamVjdDogW1BBVENIXSBzbmFwbWdyOiBy
ZXBsYWNlIHNzY2FuZiB3aXRoIHN0cnRvbC9zdHJ0b3VsIGluIHNuYXBzaG90IHBhcnNlCiBoZWxw
ZXJzCgpwYXJzZUludEZyb21UZXh0LCBwYXJzZVhpZEZyb21UZXh0LCBhbmQgcGFyc2VWeGlkRnJv
bVRleHQgdXNlZCBzc2NhbmYKdG8gY29udmVydCBkaWdpdCBzdHJpbmdzIHRvIGludGVnZXJzLiAg
UmVwbGFjZSB3aXRoIHN0cnRvbC9zdHJ0b3VsLAp3aGljaCBwcm92aWRlIGV4cGxpY2l0IG92ZXJm
bG93IGRldGVjdGlvbiBhbmQgYWR2YW5jZSB0aGUgZW5kLXBvaW50ZXIKZGlyZWN0bHksIGF2b2lk
aW5nIGEgcmVkdW5kYW50IHN0cmNociBzY2FuIG92ZXIgdGhlIGFscmVhZHktcGFyc2VkCmRpZ2l0
cy4KLS0tCiBzcmMvYmFja2VuZC91dGlscy90aW1lL3NuYXBtZ3IuYyB8IDQ1ICsrKysrKysrKysr
KysrKysrKysrKysrKystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwg
MTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvdGltZS9zbmFw
bWdyLmMgYi9zcmMvYmFja2VuZC91dGlscy90aW1lL3NuYXBtZ3IuYwppbmRleCAxMGZlMThkZjJl
Ny4uMjBiODQyMWI4ODEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL3RpbWUvc25hcG1n
ci5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL3RpbWUvc25hcG1nci5jCkBAIC0xMzA4LDI0ICsx
MzA4LDI3IEBAIHBhcnNlSW50RnJvbVRleHQoY29uc3QgY2hhciAqcHJlZml4LCBjaGFyICoqcywg
Y29uc3QgY2hhciAqZmlsZW5hbWUpCiB7CiAJY2hhcgkgICAqcHRyID0gKnM7CiAJaW50CQkJcHJl
Zml4bGVuID0gc3RybGVuKHByZWZpeCk7Ci0JaW50CQkJdmFsOworCWxvbmcJCXZhbDsKKwljaGFy
CSAgICplbmRwdHI7CiAKIAlpZiAoc3RybmNtcChwdHIsIHByZWZpeCwgcHJlZml4bGVuKSAhPSAw
KQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9URVhUX1JF
UFJFU0VOVEFUSU9OKSwKIAkJCQkgZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGRhdGEgaW4gZmls
ZSBcIiVzXCIiLCBmaWxlbmFtZSkpKTsKIAlwdHIgKz0gcHJlZml4bGVuOwotCWlmIChzc2NhbmYo
cHRyLCAiJWQiLCAmdmFsKSAhPSAxKQorCWVycm5vID0gMDsKKwl2YWwgPSBzdHJ0b2wocHRyLCAm
ZW5kcHRyLCAxMCk7CisJaWYgKGVuZHB0ciA9PSBwdHIgfHwgZXJybm8gIT0gMCB8fCB2YWwgPCBJ
TlRfTUlOIHx8IHZhbCA+IElOVF9NQVgpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVycmNvZGUo
RVJSQ09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAogCQkJCSBlcnJtc2coImludmFs
aWQgc25hcHNob3QgZGF0YSBpbiBmaWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkpOwotCXB0ciA9IHN0
cmNocihwdHIsICdcbicpOworCXB0ciA9IHN0cmNocihlbmRwdHIsICdcbicpOwogCWlmICghcHRy
KQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9URVhUX1JF
UFJFU0VOVEFUSU9OKSwKIAkJCQkgZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGRhdGEgaW4gZmls
ZSBcIiVzXCIiLCBmaWxlbmFtZSkpKTsKIAkqcyA9IHB0ciArIDE7Ci0JcmV0dXJuIHZhbDsKKwly
ZXR1cm4gKGludCkgdmFsOwogfQogCiBzdGF0aWMgVHJhbnNhY3Rpb25JZApAQCAtMTMzMywyNCAr
MTMzNiwyNyBAQCBwYXJzZVhpZEZyb21UZXh0KGNvbnN0IGNoYXIgKnByZWZpeCwgY2hhciAqKnMs
IGNvbnN0IGNoYXIgKmZpbGVuYW1lKQogewogCWNoYXIJICAgKnB0ciA9ICpzOwogCWludAkJCXBy
ZWZpeGxlbiA9IHN0cmxlbihwcmVmaXgpOwotCVRyYW5zYWN0aW9uSWQgdmFsOworCXVuc2lnbmVk
IGxvbmcgdmFsOworCWNoYXIJICAgKmVuZHB0cjsKIAogCWlmIChzdHJuY21wKHB0ciwgcHJlZml4
LCBwcmVmaXhsZW4pICE9IDApCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVycmNvZGUoRVJSQ09E
RV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAogCQkJCSBlcnJtc2coImludmFsaWQgc25h
cHNob3QgZGF0YSBpbiBmaWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkpOwogCXB0ciArPSBwcmVmaXhs
ZW47Ci0JaWYgKHNzY2FuZihwdHIsICIldSIsICZ2YWwpICE9IDEpCisJZXJybm8gPSAwOworCXZh
bCA9IHN0cnRvdWwocHRyLCAmZW5kcHRyLCAxMCk7CisJaWYgKGVuZHB0ciA9PSBwdHIgfHwgZXJy
bm8gIT0gMCB8fCB2YWwgPiBVSU5UX01BWCkKIAkJZXJlcG9ydChFUlJPUiwKIAkJCQkoZXJyY29k
ZShFUlJDT0RFX0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCiAJCQkJIGVycm1zZygiaW52
YWxpZCBzbmFwc2hvdCBkYXRhIGluIGZpbGUgXCIlc1wiIiwgZmlsZW5hbWUpKSk7Ci0JcHRyID0g
c3RyY2hyKHB0ciwgJ1xuJyk7CisJcHRyID0gc3RyY2hyKGVuZHB0ciwgJ1xuJyk7CiAJaWYgKCFw
dHIpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9JTlZBTElEX1RFWFRf
UkVQUkVTRU5UQVRJT04pLAogCQkJCSBlcnJtc2coImludmFsaWQgc25hcHNob3QgZGF0YSBpbiBm
aWxlIFwiJXNcIiIsIGZpbGVuYW1lKSkpOwogCSpzID0gcHRyICsgMTsKLQlyZXR1cm4gdmFsOwor
CXJldHVybiAoVHJhbnNhY3Rpb25JZCkgdmFsOwogfQogCiBzdGF0aWMgdm9pZApAQCAtMTM1OSwx
NyArMTM2NSwzNiBAQCBwYXJzZVZ4aWRGcm9tVGV4dChjb25zdCBjaGFyICpwcmVmaXgsIGNoYXIg
KipzLCBjb25zdCBjaGFyICpmaWxlbmFtZSwKIHsKIAljaGFyCSAgICpwdHIgPSAqczsKIAlpbnQJ
CQlwcmVmaXhsZW4gPSBzdHJsZW4ocHJlZml4KTsKKwlsb25nCQlsdmFsOworCXVuc2lnbmVkIGxv
bmcgdWx2YWw7CisJY2hhcgkgICAqZW5kcHRyOwogCiAJaWYgKHN0cm5jbXAocHRyLCBwcmVmaXgs
IHByZWZpeGxlbikgIT0gMCkKIAkJZXJlcG9ydChFUlJPUiwKIAkJCQkoZXJyY29kZShFUlJDT0RF
X0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCiAJCQkJIGVycm1zZygiaW52YWxpZCBzbmFw
c2hvdCBkYXRhIGluIGZpbGUgXCIlc1wiIiwgZmlsZW5hbWUpKSk7CiAJcHRyICs9IHByZWZpeGxl
bjsKLQlpZiAoc3NjYW5mKHB0ciwgIiVkLyV1IiwgJnZ4aWQtPnByb2NOdW1iZXIsICZ2eGlkLT5s
b2NhbFRyYW5zYWN0aW9uSWQpICE9IDIpCisKKwkvKiBQYXJzZSBwcm9jTnVtYmVyICh0aGUgc2ln
bmVkIGludGVnZXIgYmVmb3JlICcvJykgKi8KKwllcnJubyA9IDA7CisJbHZhbCA9IHN0cnRvbChw
dHIsICZlbmRwdHIsIDEwKTsKKwlpZiAoZW5kcHRyID09IHB0ciB8fCBlcnJubyAhPSAwIHx8IGx2
YWwgPCBJTlRfTUlOIHx8IGx2YWwgPiBJTlRfTUFYIHx8CisJCSplbmRwdHIgIT0gJy8nKQogCQll
cmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9URVhUX1JFUFJFU0VO
VEFUSU9OKSwKIAkJCQkgZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGRhdGEgaW4gZmlsZSBcIiVz
XCIiLCBmaWxlbmFtZSkpKTsKLQlwdHIgPSBzdHJjaHIocHRyLCAnXG4nKTsKKwl2eGlkLT5wcm9j
TnVtYmVyID0gKFByb2NOdW1iZXIpIGx2YWw7CisJcHRyID0gZW5kcHRyICsgMTsJCQkvKiBza2lw
IHRoZSAnLycgc2VwYXJhdG9yICovCisKKwkvKiBQYXJzZSBsb2NhbFRyYW5zYWN0aW9uSWQgKHRo
ZSB1bnNpZ25lZCBpbnRlZ2VyIGFmdGVyICcvJykgKi8KKwllcnJubyA9IDA7CisJdWx2YWwgPSBz
dHJ0b3VsKHB0ciwgJmVuZHB0ciwgMTApOworCWlmIChlbmRwdHIgPT0gcHRyIHx8IGVycm5vICE9
IDAgfHwgdWx2YWwgPiBVSU5UX01BWCkKKwkJZXJlcG9ydChFUlJPUiwKKwkJCQkoZXJyY29kZShF
UlJDT0RFX0lOVkFMSURfVEVYVF9SRVBSRVNFTlRBVElPTiksCisJCQkJIGVycm1zZygiaW52YWxp
ZCBzbmFwc2hvdCBkYXRhIGluIGZpbGUgXCIlc1wiIiwgZmlsZW5hbWUpKSk7CisJdnhpZC0+bG9j
YWxUcmFuc2FjdGlvbklkID0gKExvY2FsVHJhbnNhY3Rpb25JZCkgdWx2YWw7CisJcHRyID0gc3Ry
Y2hyKGVuZHB0ciwgJ1xuJyk7CiAJaWYgKCFwdHIpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVy
cmNvZGUoRVJSQ09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAotLSAKMi40Ny4xCgo=
--000000000000b711e1064fdd44fa--