Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7I4o-0059Us-1d for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Mar 2026 19:15:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7I4m-005qdK-3A for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Mar 2026 19:15:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7I4m-005qcz-22 for pgsql-hackers@lists.postgresql.org; Mon, 30 Mar 2026 19:15:05 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7I4l-00000001qyf-1Trk for pgsql-hackers@postgresql.org; Mon, 30 Mar 2026 19:15:04 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-b982d56dac4so844679766b.3 for ; Mon, 30 Mar 2026 12:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774898102; cv=none; d=google.com; s=arc-20240605; b=eSo+cRSc89tah27+iXFr/4Qn+9tQOFHldpyrIsZ8VmhlcViDAPv069JsiyLPvHLCUA YqPoKyDfOWQXvJKIpnBTdNI4IcCOpjdUbAMhxuDheDDgzDV2TJK8HGoCa0UPtGPFMSY3 Z7rJlQPhnu4TcKlba3oFBmtnYV+iV/JapEWxLttrKztqqTm0vkyglI53UgtqbhEU15aG 1MptWmc9U45/GoTMNSZvaYhNMNRA0PqHAD4+kyYTPsIqvSHd38cTJvGwAA4nu/LLcSBK WeH1a31R/0BJ+isxt46GcaB/B+okR1DxoQxNHE9psv73EkiJ2hH4mgUfZ53Z0x9Q0VlE wUFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dNK/T4tjJAjT7oYPS73cg0tHEUUIH3dxYXyQK6JJEd0=; fh=dX2kKF+uLpAiKxn2wQ/BDMgl/Vhv7QXSTDMouj9Y4Qo=; b=Rz4QhypxzWj2XzLn0kCYRK9rbbJKV3ztAvq4ss9Wq/Qy9xtd1B+3rX+SNQT/XR0wUj ueETMxMdbBbGqeuJWvYOg7/wRh+weu2pvDlZNSuykWGVUbOGpD/Blx0fl3gMutBfNVJg El6W1HPTKAnYg42YVpe5FeVdDsYrXNuP4a5Tmow18y3EiUXaeR9TRX3UqHO5UKndKyRE YSNjZPTgC//CSbKIhc5JfxCeX///hzhi24NN+G0T9YLzft1yeKz7SpcVYJccmHCDoK+2 OevTarpY9pI+g1M4wCO51stnHwGXQifNtJh1as5k++Jl81eP7hrBd0Qh4MIC/+GRR+gD 8Gxw==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774898102; x=1775502902; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dNK/T4tjJAjT7oYPS73cg0tHEUUIH3dxYXyQK6JJEd0=; b=JWred2V13TDjbPL6rhAQvZbQBKoIr+DoT+BHwm95tr6ujcajHJovHTvkNAG/Lv+121 Z6FSGmio2p/6+FwjN0Kz2SbWBYDOogNT3hxjZmsZkXawvPqa9k9Mp2SOj34TgZsA09Yz v4LcUowJOIlUpV3Dh4j0IW0E37sC7qVDU0eTJr5C2BtwawWLTSbMIRhv/Q1Dkn1Mj59b djn2q/zvmByhUH4U7UAPmZLOGPJHLM1VvgR6eAZlbc4LYFSAv0DGZ1CcQ9dDYGDsRPC8 GnbToMtakGbUXkbA91zee3W2VmPyuGxJG2vsfDMgKZedjczgBtcUxYLB1ssQj0EO7jXD IZRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774898102; x=1775502902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dNK/T4tjJAjT7oYPS73cg0tHEUUIH3dxYXyQK6JJEd0=; b=lcV9hu6dGhF87cWhxurS2Y8UGeLPKSPR39kbZPFaSP5hIV62DMRYnS3GIi4jNQxmYZ qw4svicX2HHTpxTyJjiGcdSXNtuY1MG/eeFxhAHmx1lnUVD0uuzDcYuh2Kb34B3jmxKO WmWm8H4ohW3En+PNoV4clCE190F+JXahyFRoWaZyAHW2ZGiYzR7u2oN7Jrtuu9THVtO9 O5c4yTph0J2i+UQYzu01oeU6JMDGHLt0avOk6u6fvzIgM55Iid0cIDcUBQ0rPbb5Grdr FV3bx8s1xhVYVpLj7hQ763mxNDe9Kc5jto9qa3x/lLw/xeSHzYV3hQunXi8roUOyJFzz jW1A== X-Forwarded-Encrypted: i=1; AJvYcCXys6EM6p1OSnFycVr1q52DF1ob2Z0TU5+rrieIePa1ZitDlPjPKNHcnsENJJmWATVkbZWHzlKKz9dC03dZ@postgresql.org X-Gm-Message-State: AOJu0YyLmS3wXX/Fm86xbHsbhHfZJORjyx8h1jHhSo6eAXkW2Xrsfn/H z6H3D2DquKlNtVQ35I0qQjA7suNz0tlbIpQekjXAdyPaZ0gmpDGkGkWKGHw531nCvUP/3lNxZU/ 3cXiJfKXvaVKIWJU/WyPnIU9oQzmtDrk= X-Gm-Gg: ATEYQzyEGqcNiNZg8eKr3x4WHA1NACDWoCh1RX1JRaGjdfh39yOdk6fae+Sn7Snoy9I +21QGhGg2q9ZmlHthJL9Cejr5SYFOJ4tWrtDWexAHBqF65hVVxXkAdiQvjTmUz/IyNeTd9NmGic 2a94ChwVplOTEc7qRouglpbVWBM1ibPqaZH2Zbbhx0+qOTtc8QJPM/kkN7IB5uCN8pYZUq9sC7P I3JC0t1T1AUQDmitvkY326OKS6VlHuxGbE3RNIN3c4mmqSBCBtZSytPqGDsIrXsQ3QnEraud/D7 mlzPOIX1KpbJt6JSONbNhTM6DLf8vfRuke6GnFtVjA77IF9W5EI+bql13p28SmnaNBmsFOZswT/ n28FdAsqk X-Received: by 2002:a17:907:a28d:b0:b98:22e7:72b with SMTP id a640c23a62f3a-b9b507a7bf9mr796755066b.30.1774898101676; Mon, 30 Mar 2026 12:15:01 -0700 (PDT) MIME-Version: 1.0 References: <42rdu4q44kvsq53fz5qgzuawqpaytvnemsnquynlfch5mqhc2m@6ytnlgivtzro> <9ce8f5d8-8ab2-4aa2-b062-c5d74161069c@gmail.com> In-Reply-To: <9ce8f5d8-8ab2-4aa2-b062-c5d74161069c@gmail.com> From: Melanie Plageman Date: Mon, 30 Mar 2026 15:14:49 -0400 X-Gm-Features: AQROBzCecOz6xOIKOdadzIZqaxd1UKTEznx3hSBpc-xq_rtvj63D8VQS_dFGPnQ Message-ID: Subject: Re: Don't synchronously wait for already-in-progress IO in read stream To: Alexander Lakhin Cc: Andres Freund , Nazir Bilal Yavuz , Thomas Munro , pgsql-hackers@postgresql.org, Peter Geoghegan , Tomas Vondra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Mar 30, 2026 at 3:00=E2=80=AFPM Alexander Lakhin wrote: > > As copperhead showed [1], tests added in 020c02bd9 fail when postgres is > built without --enable-cassert. I've reproduced the failure locally with: Yes, it's because read_buffers() (in test_aio.c) uses operation->nblocks and that's only intialized for buffer hits in assert builds. The test code could just use the correctly initialized nblocks out parameter. - Melanie