Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7dn0-005YJo-2N for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 18:26:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7dmx-00CJDf-2T for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 18:26:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7dmx-00CJDX-1X for pgsql-hackers@lists.postgresql.org; Tue, 31 Mar 2026 18:26:07 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7dms-000000020jH-3ukO for pgsql-hackers@postgresql.org; Tue, 31 Mar 2026 18:26:07 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-66c43d3ba7eso1529338a12.0 for ; Tue, 31 Mar 2026 11:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774981561; cv=none; d=google.com; s=arc-20240605; b=PP8tJeP9K7l+GO2Ii3bCz4EWZsp/WN4MFpC1nWYIiPHKxT9ZJJGWQcUw5vmr0WBn5O 3HuQefnCIs6jW3Ym8waWp+2mc2x/U2rNaDvI5A+lMV/A5KtfhSxf+9zeuQr0HwBg2DmO Aremh3Y+INszmp2khvmrv1dhv5SJxlq3FucjQE8ew0/rblr5wMXGaEX+IuDjUivPAKy/ sb3h64VJipODA1+POWNdVL/rF0M0hye3MfWGyD36m5C/9suKwl6yrnIa8Ex/VH/qPaqY cdHkh+Q3AN4g/gRZP+vhFNluVpqu7tvsV2CSlKvVLAdjPBBlRatIvun5VFHA9I6WVxRX EikQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=E/AUyFVHE2UTJV6QFoM0PFfpFaRO4JfPMZn/9CX5pvU=; fh=p7woflbJfGl5yt1X5vpBqsJnJ886v86kQPf8AtV1pwc=; b=aEC3nVgavb3fTEjK1VTYQVRzG9VtAJzMimgwGaTxoHlztx8CzMphGGkW96i5wa2U3N i66LESlGLYfl11Q6Tj1/0crw21Fgn9qnY2GtG37nCuJXtemaeWCCFZ6bAQtwOIEs0fIz lZtY5s20w7hOT0393DHQws6Qy7OLvpjCvIxg/MUe66K0+eZOvWZcPHRNPVkW0ZboIoOx OeutFHgJp2rqGweAmo0fd3ucwLugZws3cKGUx/ntHqctHsvi/orYiyGt/0eokqVGk2Af B2Yt/05JefAz8vqtpu71phD5ivtZd2uao9zZLtCBrXBbthypo+pdwNcP5UMEGqPmFVgv hXVQ==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774981561; x=1775586361; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E/AUyFVHE2UTJV6QFoM0PFfpFaRO4JfPMZn/9CX5pvU=; b=n3LV7RPv6ReRd7Z1TE+v0AkJw8qIB7UEJ2RA+yfrOWg5jxD/nldWtSvxtBaYvaT8qD AGGIuUrJ7LeGyhe78UDABjLWZaur2aoRVivqy2e7781YhIIUuqDJwbl0Ql+uOeNuIMU/ IHUU09/6ipJlZyaPGVcH/YxPKE88All724KiIK1nK8OsrXYa3gn6EMykmABTLGRgiEMM 8GhcI+bcPHqKF1iL1sCLzXVBesjRbpemHICyxUwsnJOCt2AF2xSwOFcx3rc7cRxNUTBI zgx1IZXkWlBbDUK7lQ1YMLdLqWO/oL3rGtSD2nlcBDNEuCH0vEaptlHBEzv0CqK5AKUJ h54A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774981561; x=1775586361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E/AUyFVHE2UTJV6QFoM0PFfpFaRO4JfPMZn/9CX5pvU=; b=pYvEBtEJidfY9H5HCesI+0ldQeKFmMoftN6D2bSiBwUnRvyqFGpTRgmR11oFiCbfCB slpAxsobAdFkgkE9HMxa6gFp/y14cl4jy6+Du4Fa+a4laO8U2DtSZLMrZTog4sG3uOcH /OjnsR2npp30bbz4iFJ/hfV4djAooinEzu65Tyu08m7mR2Bk0O/0BSzM0D6qnvAanSOF rTANAeu+lPZiM3FEYMl/tdRja+xZqu9yBAplfxhTHtGWCRxJzXo/gPgwRNbOCwHqPpJi 77b3b9l35uJE85zKEWjaTXJLmhLpEkHOqyvEwdQPVWpRDJcksxScF/8uxtBkgsP6X13V BBpA== X-Forwarded-Encrypted: i=1; AJvYcCV0ol/4haSXipmx7HB8n4hXhAEs+OoOZzQUenjxCK+kPmn7pSsgps3QdkoyAGqivkFM00x/rOLyASnbeQ6O@postgresql.org X-Gm-Message-State: AOJu0Yyemqh2rOdiOMJBkANbN/0hOOCG5EH/nTNR/hInFHD2ukRjuEzW EBsZFfTNNWXcohoLVcrV5pTlFTYd9mXpLNlutgEEfPtD9hU0gLgHhw78Y7NtCz+xG9mrFU6FYaG 7pX8PEydMN3XQSElRnJIagBfMR+9HjdA= X-Gm-Gg: ATEYQzxn1X4QiiaY8zAjaO1oyZcfosC7DVJ2Clf1cMrPIi3DWd1KTaZasq49D+UMHrQ Y8mlVWpC6qOcEpdW16PUGBAvaXKEyTfHj8QucBD8ASXgnYOP3R1a5orMMo+oyfl4P7nTgEDcPt0 Gk4ra00C8GDU42LPjcwUUScelV/lNGocEETK6pOoMXUBMZdFlr0Pcya6f7+c3M1NUpcaqaUI8xH lpuVBiHDRNeg6BLUI8+AIfy8h30/kGgh+BKZmbDA9xrLcOYbIf0CDZ+L0CLjsI1PkuW9gG65eG5 ntS38xgFFqHscNqHQes+jZQaNjKiUpY0MHQCL4VC8ix8bXTmPu9rtu85MyNlDAxuo2EKK4BOjgh Q2dt/G1jQ X-Received: by 2002:a05:6402:5250:b0:66b:f13:2ba9 with SMTP id 4fb4d7f45d1cf-66db0bef775mr353706a12.22.1774981561217; Tue, 31 Mar 2026 11:26:01 -0700 (PDT) MIME-Version: 1.0 References: <9ce8f5d8-8ab2-4aa2-b062-c5d74161069c@gmail.com> <6yhrh2q7tb2fxszsyjg34uzt66ejbbk4j6tmwov6xaezunzvxx@ghohuopucefv> In-Reply-To: <6yhrh2q7tb2fxszsyjg34uzt66ejbbk4j6tmwov6xaezunzvxx@ghohuopucefv> From: Melanie Plageman Date: Tue, 31 Mar 2026 14:25:49 -0400 X-Gm-Features: AQROBzDRwiIwfEFhF-0ee5PNwsDTEnGj67fpq9uTAS-ogVs9gnXIcvH3aqqYHi0 Message-ID: Subject: Re: Don't synchronously wait for already-in-progress IO in read stream To: Andres Freund Cc: Alexander Lakhin , Nazir Bilal Yavuz , Thomas Munro , pgsql-hackers@postgresql.org, Peter Geoghegan , Tomas Vondra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 31, 2026 at 8:43=E2=80=AFAM Andres Freund = wrote: > > Looks good to me. > > Will you push? I was going to push but then Bilal asked me off-list if there was some reason not to set the members of ReadBuffersOperation outside of assert builds. I agree with him that it seems like a future user of StartReadBuffersImpl() could make this same mistake. Both of us vaguely recall this being done for performance reasons. Before committing this test change, I wanted to confirm that we don't want to modify the actual prod code the way he does in [1]. - Melanie [1] https://www.postgresql.org/message-id/CAN55FZ2-bKNKmMSRDx1xH3SyqwBVMZ8H= FG2YNipQ7LCdKm7eKA%40mail.gmail.com