MIME-Version: 1.0
References: 
 <CAAKRu_Z8Ry_ynNBPAzs_Ry3MQi9NaBgt1ccLgwRsDbxWpocaBg@mail.gmail.com>
 <CAAKRu_ZbOp52rnkjf63h5mf94raEKBH7AAbz6QTx-xdH9yLfmQ@mail.gmail.com>
 <CAAKRu_b8m+iuupm4ZX+2_V5Xj5u4jCTrU=Tv=epg6p4H2SMkFQ@mail.gmail.com>
 <CALdSSPh9hVXNiPwdntWqbMzu5upKy0jBDDe7Un0_Nf2A54R2VQ@mail.gmail.com>
 <CAAKRu_a6Cd7JnxhY4A=b_Paxc3UDUDOPeqV3GbzMh=R2KkD-uQ@mail.gmail.com>
 <jlsvov4o5xswxjvjhvuchz6y55ncvoc457grvxct7cub5gcxuj@4e2toesujnpr>
 <CAAKRu_bsHbvt+VqbjHXsdphKf8fqwBEutRhH3fmo+qUVe=yBKw@mail.gmail.com>
 <CAAKRu_ZhHtEaucO--SdYrCjq0zgqk_LPztUD+-QS74A2htXgKw@mail.gmail.com>
 <CAAKRu_Zj8G4T=HN3QSY7iQvkKSQk-k1fq+eJkjCBNqoSg63z+Q@mail.gmail.com>
 <CAAKRu_bgP-DMZs=D2j2N0+U9+uWU5cVagw-yZLOuhYbWj_KwnA@mail.gmail.com>
 <itvgqc6vncbjsjfmrptfvkkeg5vqzhalaguya2z77t6c6ctpc3@wsdrgbn4bxaa>
 <CAAKRu_aWMyGB=zg5W7+RUtor6TqsiOwHXSL7Dg4TUUiTSzzcpw@mail.gmail.com>
 <2be31f17-5405-4de9-8d73-90ebc322f7d8@vondra.me>
 <CAAKRu_Ypa7-JGVR+fstDxU5Cfitk_rf5ijdaqwtoPkztursufA@mail.gmail.com>
 <CAAKRu_ZrDadxmGepBwPZ03yAKnMxwsHYn8SK9Gg7VqigLLVUWg@mail.gmail.com>
 <CAApHDvqAOeOwCKh9g0gfxWa040=Hyc7_oA=C59rjod8kXJDWyw@mail.gmail.com>
 <CAAKRu_Yt76_HdfR6DtK_wtkSNSj9=VxSV_npt+6T2R=zTzp1Pg@mail.gmail.com>
 <CAAKRu_atv6zA274m8Ysgbfn49c0NbdvHT7nXvd9kroZKnFq8Dg@mail.gmail.com>
 <CAApHDvq_R-gNXu+06GQW6w_HaEMh1pezsyiCh7GNhgh+h0UqMw@mail.gmail.com>
In-Reply-To: 
 <CAApHDvq_R-gNXu+06GQW6w_HaEMh1pezsyiCh7GNhgh+h0UqMw@mail.gmail.com>
From: Melanie Plageman <melanieplageman@gmail.com>
Date: Tue, 31 Mar 2026 12:19:20 -0400
Message-ID: 
 <CAAKRu_YfoGTHNn0XxA+dCPj9hyO96vO4Eb+awRR6T8m22qC6ww@mail.gmail.com>
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM
 on-access)
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tomas Vondra <tomas@vondra.me>, Andres Freund <andres@anarazel.de>,
	Kirill Reshke <reshkekirill@gmail.com>, Chao Li <li.evan.chao@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>, Xuneng Zhou <xunengzhou@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Heikki Linnakangas <hlinnaka@iki.fi>
Content-Type: multipart/mixed; boundary="0000000000001c41f9064e54554e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAKRu_YfoGTHNn0XxA%2BdCPj9hyO96vO4Eb%2BawRR6T8m22qC6ww%40mail.gmail.com>
Precedence: bulk

--0000000000001c41f9064e54554e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for the reply! I have committed the patches in this thread and
marked the CF entry accordingly.

On Mon, Mar 30, 2026 at 10:17=E2=80=AFPM David Rowley <dgrowleyml@gmail.com=
> wrote:
>
> I looked at v48-0001 and it looks fine to me. I've only minor quibbles
> about you using foreach() instead of foreach_int() and foreach_node()
> for populating the new Bitmapsets in standard_planner().

Good point. I forgot about those. Attached patch fixes that (since the
code was already committed).

- Melanie

--0000000000001c41f9064e54554e
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Use-foreach_int-foreach_node-for-resultRelationRe.patch"
Content-Disposition: attachment;
	filename="v1-0001-Use-foreach_int-foreach_node-for-resultRelationRe.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnetnmqj0>
X-Attachment-Id: f_mnetnmqj0

RnJvbSBjZDliYTdjY2U3NTZhZDg3MGEwMGNlODJmYWFlNDFiNTU2NDk4MGI3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNZWxhbmllIFBsYWdlbWFuIDxtZWxhbmllcGxhZ2VtYW5AZ21h
aWwuY29tPgpEYXRlOiBUdWUsIDMxIE1hciAyMDI2IDEyOjA2OjM5IC0wNDAwClN1YmplY3Q6IFtQ
QVRDSCB2MV0gVXNlIGZvcmVhY2hfaW50L2ZvcmVhY2hfbm9kZSBmb3IgcmVzdWx0UmVsYXRpb25S
ZWxpZHMgYW5kCiByb3dNYXJrUmVsaWRzCgowZjRjMTcwY2YzYjg1ZSBpdGVyYXRlZCB0aHJvdWdo
IFBsYW5uZXJHbG9iYWwtPnJlc3VsdFJlbGF0aW9ucyBhbmQKUGxhbm5lckdsb2JhbC0+ZmluYWxy
b3dtYXJrcyBhZGRpbmcgdGhlaXIgUlRJcyB0byBiaXRtYXBzZXRzIGluIHRoZQpQbGFubmVkU3Rt
dC4gSXQgdXNlZCB0aGUgZ2VuZXJpYyBmb3JlYWNoKCkgaW5zdGVhZCBvZiB0aGUgbW9yZSByZWNl
bnRseQppbnRyb2R1Y2VkLCBwcmVmZXJyZWQsIHR5cGUtc2FmZSBzcGVjaWFsaXplZCB2YXJpYW50
czogZm9yZWFjaF9pbnQoKSBhbmQKZm9yZWFjaF9ub2RlKCkuIERvIHRoYXQgbm93LgoKUmVwb3J0
ZWQtYnk6IERhdmlkIFJvd2xleSA8ZGdyb3dsZXltbEBnbWFpbC5jb20+CkRpc2N1c3Npb246IGh0
dHBzOi8vcG9zdGdyLmVzL20vQ0FBcEhEdnFfUi1nTlh1JTJCMDZHUVc2d19IYUVNaDFwZXpzeWlD
aDdHTmhnaCUyQmgwVXFNdyU0MG1haWwuZ21haWwuY29tCi0tLQogc3JjL2JhY2tlbmQvb3B0aW1p
emVyL3BsYW4vcGxhbm5lci5jIHwgMTEgKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGlu
c2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvb3B0
aW1pemVyL3BsYW4vcGxhbm5lci5jIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BsYW4vcGxhbm5l
ci5jCmluZGV4IDA3OTQ0NjEyNjY4Li4yYjgyNDM2MzVhOSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tl
bmQvb3B0aW1pemVyL3BsYW4vcGxhbm5lci5jCisrKyBiL3NyYy9iYWNrZW5kL29wdGltaXplci9w
bGFuL3BsYW5uZXIuYwpAQCAtMzQxLDggKzM0MSw3IEBAIHN0YW5kYXJkX3BsYW5uZXIoUXVlcnkg
KnBhcnNlLCBjb25zdCBjaGFyICpxdWVyeV9zdHJpbmcsIGludCBjdXJzb3JPcHRpb25zLAogCVBh
dGgJICAgKmJlc3RfcGF0aDsKIAlQbGFuCSAgICp0b3BfcGxhbjsKIAlMaXN0Q2VsbCAgICpscCwK
LQkJCSAgICpsciwKLQkJCSAgICpsYzsKKwkJCSAgICpscjsKIAogCS8qCiAJICogU2V0IHVwIGds
b2JhbCBzdGF0ZSBmb3IgdGhpcyBwbGFubmVyIGludm9jYXRpb24uICBUaGlzIGRhdGEgaXMgbmVl
ZGVkCkBAIC02NjYsMTIgKzY2NSwxMiBAQCBzdGFuZGFyZF9wbGFubmVyKFF1ZXJ5ICpwYXJzZSwg
Y29uc3QgY2hhciAqcXVlcnlfc3RyaW5nLCBpbnQgY3Vyc29yT3B0aW9ucywKIAkgKiBDb21wdXRl
IHJlc3VsdFJlbGF0aW9uUmVsaWRzIGFuZCByb3dNYXJrUmVsaWRzIGZyb20gcmVzdWx0UmVsYXRp
b25zIGFuZAogCSAqIHJvd01hcmtzLiBUaGVzZSBjYW4gYmUgdXNlZCBmb3IgY2hlYXAgbWVtYmVy
c2hpcCBjaGVja3MuCiAJICovCi0JZm9yZWFjaChsYywgZ2xvYi0+cmVzdWx0UmVsYXRpb25zKQor
CWZvcmVhY2hfaW50KHJ0aSwgZ2xvYi0+cmVzdWx0UmVsYXRpb25zKQogCQlyZXN1bHQtPnJlc3Vs
dFJlbGF0aW9uUmVsaWRzID0gYm1zX2FkZF9tZW1iZXIocmVzdWx0LT5yZXN1bHRSZWxhdGlvblJl
bGlkcywKLQkJCQkJCQkJCQkJCQkgIGxmaXJzdF9pbnQobGMpKTsKLQlmb3JlYWNoKGxjLCBnbG9i
LT5maW5hbHJvd21hcmtzKQorCQkJCQkJCQkJCQkJCSAgcnRpKTsKKwlmb3JlYWNoX25vZGUoUGxh
blJvd01hcmssIHJvd21hcmssIGdsb2ItPmZpbmFscm93bWFya3MpCiAJCXJlc3VsdC0+cm93TWFy
a1JlbGlkcyA9IGJtc19hZGRfbWVtYmVyKHJlc3VsdC0+cm93TWFya1JlbGlkcywKLQkJCQkJCQkJ
CQkJICAgKChQbGFuUm93TWFyayAqKSBsZmlyc3QobGMpKS0+cnRpKTsKKwkJCQkJCQkJCQkJICAg
cm93bWFyay0+cnRpKTsKIAogCXJlc3VsdC0+cmVsYXRpb25PaWRzID0gZ2xvYi0+cmVsYXRpb25P
aWRzOwogCXJlc3VsdC0+aW52YWxJdGVtcyA9IGdsb2ItPmludmFsSXRlbXM7Ci0tIAoyLjQzLjAK
Cg==
--0000000000001c41f9064e54554e--