MIME-Version: 1.0
References: <fmkqmyeyy7bdpvcgkheb6yaqewemkik3ls6aaveyi5ibmvtxnd@nu2kvy5rq3a6>
 <CAAKRu_a0w7wVZCysJ1s6tEPkdsGyYR4iBSEUefa3Y2nWLx2vSw@mail.gmail.com>
 <tsoi4ahsvxl7ln3ltmkhi4wn6p5b36uiokll5j2mzsfhpl6i7w@brc33vsxcdum>
 <CAAKRu_b8+MYK1JsppdtUNV-f3UgEg3F7YihiSWvxoHeWgEN7BA@mail.gmail.com>
 <CAAKRu_bwpjonq5ag2EBm2xDRRyfU8PpCFioG1o=8Ed9VKkRBfQ@mail.gmail.com>
In-Reply-To: 
 <CAAKRu_bwpjonq5ag2EBm2xDRRyfU8PpCFioG1o=8Ed9VKkRBfQ@mail.gmail.com>
From: Melanie Plageman <melanieplageman@gmail.com>
Date: Tue, 10 Mar 2026 15:46:00 -0400
Message-ID: 
 <CAAKRu_Ypx4+a3ycAJm276E0F3UiQfo-XeusOmjOzOajHCLNHZA@mail.gmail.com>
Subject: Re: Unlogged rel fake lsn vs GetVictimBuffer()
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>,
	Peter Geoghegan <pg@bowt.ie>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAAKRu_Ypx4%2Ba3ycAJm276E0F3UiQfo-XeusOmjOzOajHCLNHZA%40mail.gmail.com>
Precedence: bulk

On Tue, Mar 10, 2026 at 3:31=E2=80=AFPM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> None of my points above are blockers, so barring any objections I plan
> to push this later today/tomorrow. It hasn't been sitting out long but
> it is pretty trivial and I don't think it has any correctness issues.

Now, I'm thinking that I should allow BufferNeedsWALFlush() to be
called on local buffers. I removed it in v2 because Andres mentioned
it could never happen when called by StrategyRejectBuffer() (because
we don't use strategies on local buffers), but there's no reason
BufferNeedsWALFlush() can't be used more widely in the future.

- Melanie