From 667b2e7c19c70694912223bc35d8f286a439dacd Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Wed, 17 Dec 2025 13:57:16 -0500 Subject: [PATCH v30 09/16] Simplify heap_page_would_be_all_visible visibility check heap_page_would_be_all_visible() doesn't care about the distinction between HEAPTUPLE_RECENTLY_DEAD and HEAPTUPLE_DEAD tuples -- any tuple that is not HEAPTUPLE_LIVE means the page is not all-visible and causes us to return false. Therefore, we don't need to call HeapTupleSatisfiesVacuum(), which includes an extra step to distinguish between dead and recently dead tuples using OldestXmin. Replace it with the more minimal HeapTupleSatisfiesVacuumHorizon(). This has the added benefit of making it easier to replace uses of OldestXmin in heap_page_would_be_all_visible() in the future. Author: Melanie Plageman Reviewed-by: Kirill Reshke Discussion: https://postgr.es/m/CALdSSPjvhGXihT_9f-GJabYU%3D_PjrFDUxYaURuTbfLyQM6TErg%40mail.gmail.com --- src/backend/access/heap/vacuumlazy.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index 93f0f39c5f0..e827ca21c68 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -3537,6 +3537,7 @@ heap_page_would_be_all_visible(Relation rel, Buffer buf, { ItemId itemid; HeapTupleData tuple; + TransactionId dead_after; /* * Set the offset number so that we can display it along with any @@ -3576,12 +3577,14 @@ heap_page_would_be_all_visible(Relation rel, Buffer buf, /* Visibility checks may do IO or allocate memory */ Assert(CritSectionCount == 0); - switch (HeapTupleSatisfiesVacuum(&tuple, OldestXmin, buf)) + switch (HeapTupleSatisfiesVacuumHorizon(&tuple, buf, &dead_after)) { case HEAPTUPLE_LIVE: { TransactionId xmin; + Assert(!TransactionIdIsValid(dead_after)); + /* Check comments in lazy_scan_prune. */ if (!HeapTupleHeaderXminCommitted(tuple.t_data)) { @@ -3614,8 +3617,10 @@ heap_page_would_be_all_visible(Relation rel, Buffer buf, } break; - case HEAPTUPLE_DEAD: case HEAPTUPLE_RECENTLY_DEAD: + Assert(TransactionIdIsValid(dead_after)); + /* FALLTHROUGH */ + case HEAPTUPLE_DEAD: case HEAPTUPLE_INSERT_IN_PROGRESS: case HEAPTUPLE_DELETE_IN_PROGRESS: { -- 2.43.0