MIME-Version: 1.0
References: <BC97546F-5C15-42F2-AD57-CFACDB9657D0@gmail.com>
In-Reply-To: <BC97546F-5C15-42F2-AD57-CFACDB9657D0@gmail.com>
From: Melanie Plageman <melanieplageman@gmail.com>
Date: Tue, 21 Apr 2026 17:52:35 -0400
Message-ID: 
 <CAAKRu_aUfeVKFW34ZvuhY9tBXUKYfn8rs-8cf-aE4YSUFj-xEQ@mail.gmail.com>
Subject: Re: bufmgr: pass through I/O stats context in FlushUnlockedBuffer()
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAAKRu_aUfeVKFW34ZvuhY9tBXUKYfn8rs-8cf-aE4YSUFj-xEQ%40mail.gmail.com>
Precedence: bulk

On Tue, Mar 31, 2026 at 10:15=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> w=
rote:
>
> I noticed that FlushUnlockedBuffer() accepts io_object and io_context, bu=
t then ignores them and hardcodes IOOBJECT_RELATIONand IOCONTEXT_NORMAL ins=
tead:
> ```
> static void
> FlushUnlockedBuffer(BufferDesc *buf, SMgrRelation reln,
>                                         IOObject io_object, IOContext io_=
context)
> {
>         Buffer          buffer =3D BufferDescriptorGetBuffer(buf);
>
>         BufferLockAcquire(buffer, buf, BUFFER_LOCK_SHARE_EXCLUSIVE);
>         FlushBuffer(buf, reln, IOOBJECT_RELATION, IOCONTEXT_NORMAL); // <=
=3D=3D HERE
>         BufferLockUnlock(buffer, buf);
> }
> ```
>
> Unless I am missing something, if a function accepts these parameters, th=
ey should generally be used.

Thanks for the patch. Committed in 31b0544b32b

- Melanie