Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1suGVJ-005UMt-8j for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Sep 2024 19:19:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1suGVI-00DtIK-KL for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Sep 2024 19:19:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1suGVI-00DtIC-7J for pgsql-hackers@lists.postgresql.org; Fri, 27 Sep 2024 19:19:48 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1suGVF-001Mhf-Oe for pgsql-hackers@postgresql.org; Fri, 27 Sep 2024 19:19:47 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5c88370ad7bso1317050a12.3 for ; Fri, 27 Sep 2024 12:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727464783; x=1728069583; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vbtnKsUyRvlUAO7Qa27sdhaFJt0GWGG71jAwFhOXnnU=; b=GXkYRQ7zYzy4WEBSOIkc3RwbpfpNmHpLWpg/uqFmjHtPMYS7MaQnEpkouxDFbLgo4n 2MOvY43WJhPp9AHdfvZBiUiO4qe6ezORHKXrc/28Pc52XkQyPVKks66fZDRggCSfPkGc QHivtWsOCpHGEQ/pPL5riWYVscuIqOdlqpPl+ovM3iQDD7OLm1g2kDtvhNLyL3Jvapyo SrYmRxOrlxsq4ICqKAhwOFNBF/Ft46pX/QoXeiKZvnH4kmxwWVtxXXOaHed4PFrmdvOu 9jZ+w1kWzp+ZugdA8srxYGe0qlCibITQLpPabUvfz7ih4XS57WbffHTd7gvNBk1FOhHc mPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727464783; x=1728069583; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vbtnKsUyRvlUAO7Qa27sdhaFJt0GWGG71jAwFhOXnnU=; b=dSUJwyIvqu9G1bZy7DgW7PzNj9YRECMOpPmPlHSpFFioYQ1VqsZGFWwny1kLzWZ4m1 Sifwk/numqfXTNXNxy1ZgNunTPZDDydOsMSmp4r/VshJwtCDdhH/RDyQej8xE/qAWVzC krE5eZFwVo5lcGvPo7AdvW4LnsJLz/3u6JV/+YK7Vo+NiUQoK7MJ4KQQphHMmq7n4Jiu JOjVQLqSUSFprhUDSrE7rrdOsEC+Y80dUJDBQl1lJ2SGUfveV410VjtLlTHJGoY+PMdd oaiwhX56pPhPL83ZvseuqRkXsZkSxfZbjkKb7I9tZ7HjEbRifel8n/v4HPKNBhw5sKER 2Mnw== X-Forwarded-Encrypted: i=1; AJvYcCWC3auctldQcxEtxU2+tiXi+HatmfkkYNXxrcfFsd1b9SXb2KCjUIyoabF4u6+IVmVrzJKUq7ruC7uHmepi@postgresql.org X-Gm-Message-State: AOJu0Yze6lOUnpnhPpW7tEhZhkXGbw5qqlleCoH6GJ7xiCzCWpbOaban VNcxoZFZM+U07EmhhsUatmj/w4LsEhbAMT+HFl2t1N4/SrRN+s11Z+S7a3vuUs/xugi9RWCGrN5 wGK3DSs4kBrOkknvsGPO3/UlTuF0= X-Google-Smtp-Source: AGHT+IGHmWZtafN1GZlJrmRKjDwb4XMdX8CHDIDhSE1ayb7dApqpPxqw7CiydMNRLM9V10tARB0N2O6lL0xV/2H2NfA= X-Received: by 2002:a05:6402:35c6:b0:5c5:b90a:5b78 with SMTP id 4fb4d7f45d1cf-5c8824cffd5mr3544932a12.5.1727464783196; Fri, 27 Sep 2024 12:19:43 -0700 (PDT) MIME-Version: 1.0 References: <53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com> <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru> <092adec6-4eae-4bd4-bd0d-473a9df1282b@tantorlabs.com> <3deae1bd-ad84-4459-a26e-04c9136b84e9@postgrespro.ru> <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru> In-Reply-To: From: Melanie Plageman Date: Fri, 27 Sep 2024 15:19:31 -0400 Message-ID: Subject: Re: Vacuum statistics To: Masahiko Sawada Cc: Alena Rybakina , jian he , Alexander Korotkov , Ilia Evdokimov , Andrei Zubkov , Alena Rybakina , pgsql-hackers , a.lepikhov@postgrespro.ru Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Sep 27, 2024 at 2:16=E2=80=AFPM Masahiko Sawada wrote: > > Hi, > > On Thu, Sep 5, 2024 at 2:01=E2=80=AFPM Alena Rybakina wrote: > > > > Hi! Thank you for your review! > > > > On 05.09.2024 15:47, jian he wrote: > > > > On Thu, Sep 5, 2024 at 1:23=E2=80=AFAM Alena Rybakina wrote: > > > > Hi, all! > > > > I have attached the new version of the code and the diff files > > (minor-vacuum.no-cbot). > > Thank you for updating the patches. I've reviewed the 0001 patch and > have two comments. I took a very brief look at this and was wondering if it was worth having a way to make the per-table vacuum statistics opt-in (like a table storage parameter) in order to decrease the shared memory footprint of storing the stats. - Melanie