MIME-Version: 1.0
References: <fmkqmyeyy7bdpvcgkheb6yaqewemkik3ls6aaveyi5ibmvtxnd@nu2kvy5rq3a6>
 <CAAKRu_a0w7wVZCysJ1s6tEPkdsGyYR4iBSEUefa3Y2nWLx2vSw@mail.gmail.com>
 <tsoi4ahsvxl7ln3ltmkhi4wn6p5b36uiokll5j2mzsfhpl6i7w@brc33vsxcdum>
 <CAAKRu_b8+MYK1JsppdtUNV-f3UgEg3F7YihiSWvxoHeWgEN7BA@mail.gmail.com>
 <CAAKRu_bwpjonq5ag2EBm2xDRRyfU8PpCFioG1o=8Ed9VKkRBfQ@mail.gmail.com>
 <CAAKRu_Ypx4+a3ycAJm276E0F3UiQfo-XeusOmjOzOajHCLNHZA@mail.gmail.com>
In-Reply-To: 
 <CAAKRu_Ypx4+a3ycAJm276E0F3UiQfo-XeusOmjOzOajHCLNHZA@mail.gmail.com>
From: Melanie Plageman <melanieplageman@gmail.com>
Date: Wed, 11 Mar 2026 14:03:36 -0400
Message-ID: 
 <CAAKRu_b2ujALda3VrGOzoQT7Nm3WRrOEVWPnmHY9qt0R4nYVNA@mail.gmail.com>
Subject: Re: Unlogged rel fake lsn vs GetVictimBuffer()
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>,
	Peter Geoghegan <pg@bowt.ie>
Content-Type: multipart/mixed; boundary="0000000000002457d5064cc37588"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAKRu_b2ujALda3VrGOzoQT7Nm3WRrOEVWPnmHY9qt0R4nYVNA%40mail.gmail.com>
Precedence: bulk

--0000000000002457d5064cc37588
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 10, 2026 at 3:46=E2=80=AFPM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> Now, I'm thinking that I should allow BufferNeedsWALFlush() to be
> called on local buffers. I removed it in v2 because Andres mentioned
> it could never happen when called by StrategyRejectBuffer() (because
> we don't use strategies on local buffers), but there's no reason
> BufferNeedsWALFlush() can't be used more widely in the future.

Well, due to 82467f627bd478569de, this is now a tiny one-liner. Will
push in an hour or so barring objections.

- Melanie

--0000000000002457d5064cc37588
Content-Type: text/x-patch; charset="US-ASCII";
	name="v3-0001-Avoid-WAL-flush-checks-for-unlogged-buffers-in-Ge.patch"
Content-Disposition: attachment;
	filename="v3-0001-Avoid-WAL-flush-checks-for-unlogged-buffers-in-Ge.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmmckw6s0>
X-Attachment-Id: f_mmmckw6s0

RnJvbSAwZTI2YThmNmI1NDEyMTQzMmYyYjVlZjc4NzY0Yzg1ODY1MjFjNzY2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNZWxhbmllIFBsYWdlbWFuIDxtZWxhbmllcGxhZ2VtYW5AZ21h
aWwuY29tPgpEYXRlOiBXZWQsIDExIE1hciAyMDI2IDEzOjU3OjEzIC0wNDAwClN1YmplY3Q6IFtQ
QVRDSCB2M10gQXZvaWQgV0FMLWZsdXNoIGNoZWNrcyBmb3IgdW5sb2dnZWQgYnVmZmVycyBpbgog
R2V0VmljdGltQnVmZmVyKCkKCkdldFZpY3RpbUJ1ZmZlcigpIHJlamVjdHMgYSB2aWN0aW0gYnVm
ZmVyIGlmIGl0IGlzIGZyb20gYSBidWxrcmVhZApzdHJhdGVneSByaW5nIGFuZCByZXVzaW5nIGl0
IHdvdWxkIHJlcXVpcmUgZmx1c2hpbmcgV0FMLiBVbmxvZ2dlZCB0YWJsZQpidWZmZXJzIGNhbiBo
YXZlIGZha2UgTFNOcyAoZS5nLiB1bmxvZ2dlZCBHaVNUIHBhZ2VzKSBhbmQgY2FsbGluZwpYTG9n
TmVlZHNGbHVzaCgpIG9uIGEgZmFrZSBMU04gaXMgbWVhbmluZ2xlc3MuCgpUaGlzIGlzIGEgYml0
IG9mIGZ1dHVyZS1wcm9vZmluZyBiZWNhdXNlIGN1cnJlbnRseSB0aGUgYnVsa3JlYWQgc3RyYXRl
Z3kKaXMgbm90IHVzZWQgZm9yIHJlbGF0aW9ucyB3aXRoIGZha2UgTFNOcy4KCkF1dGhvcjogTWVs
YW5pZSBQbGFnZW1hbiA8bWVsYW5pZXBsYWdlbWFuQGdtYWlsLmNvbT4KUmVwb3J0ZWQtYnk6IEFu
ZHJlcyBGcmV1bmQgPGFuZHJlc0BhbmFyYXplbC5kZT4KUmV2aWV3ZWQtYnk6IEFuZHJlcyBGcmV1
bmQgPGFuZHJlc0BhbmFyYXplbC5kZT4KRWFybGllciB2ZXJzaW9uIHJldmlld2VkLWJ5OiBDaGFv
IExpIDxsaS5ldmFuLmNoYW9AZ21haWwuY29tPgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5l
cy9tL2ZsYXQvZm1rcW15ZXl5N2JkcHZjZ2toZWI2eWFxZXdlbWtpazNsczZhYXZleWk1aWJtdnR4
bmQlNDBudTJrdnk1cnEzYTYKLS0tCiBzcmMvYmFja2VuZC9zdG9yYWdlL2J1ZmZlci9idWZtZ3Iu
YyB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z
KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvYnVmbWdyLmMgYi9z
cmMvYmFja2VuZC9zdG9yYWdlL2J1ZmZlci9idWZtZ3IuYwppbmRleCAwNTQ2ZWUwMTkzYy4uMjZi
MTk1YjUzNTkgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvYnVmZmVyL2J1Zm1nci5j
CisrKyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvYnVmZmVyL2J1Zm1nci5jCkBAIC0yNTI3LDggKzI1
MjcsOSBAQCBhZ2FpbjoKIAkJewogCQkJWExvZ1JlY1B0cglsc24gPSBCdWZmZXJHZXRMU04oYnVm
X2hkcik7CiAKLQkJCWlmIChYTG9nTmVlZHNGbHVzaChsc24pCi0JCQkJJiYgU3RyYXRlZ3lSZWpl
Y3RCdWZmZXIoc3RyYXRlZ3ksIGJ1Zl9oZHIsIGZyb21fcmluZykpCisJCQlpZiAoYnVmX3N0YXRl
ICYgQk1fUEVSTUFORU5UICYmCisJCQkJWExvZ05lZWRzRmx1c2gobHNuKSAmJgorCQkJCVN0cmF0
ZWd5UmVqZWN0QnVmZmVyKHN0cmF0ZWd5LCBidWZfaGRyLCBmcm9tX3JpbmcpKQogCQkJewogCQkJ
CUxvY2tCdWZmZXIoYnVmLCBCVUZGRVJfTE9DS19VTkxPQ0spOwogCQkJCVVucGluQnVmZmVyKGJ1
Zl9oZHIpOwotLSAKMi40My4wCgo=
--0000000000002457d5064cc37588--