public inbox for [email protected]  

help / color / mirror / Atom feed

From: Melanie Plageman <[email protected]>
To: Sergey Tatarintsev <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pgbench with partitioned tables
Date: Fri, 7 Feb 2025 18:15:58 -0500
Message-ID: <CAAKRu_bq3z7oQ4SQRh1EOMFque1xDDO_UdDub+d0XiE4rpGrtw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Mon, Feb 3, 2025 at 7:23 AM Sergey Tatarintsev
<[email protected]> wrote:
>
> 03.02.2025 14:57, Álvaro Herrera пишет:
> > On 2025-Feb-03, Sergey Tatarintsev wrote:
> >
> >> Thanks for the note. I changed the query in the patch (v2 patch attached)
> >>
> >> Btw, an additional benefit from the patch is that we can use foreign tables
> >> (for example, to test postgres_fdw optimizations)
> > Good thought, and maybe it would be better if the new function was
> > "get_table_relkind" which just returns the char, and this check
> >
> >> +    /* Use COPY with FREEZE on v14 and later for all regular tables */
> >> +    if ((PQserverVersion(con) >= 140000) && is_regular_table(con, table))
> >>                      copy_statement_fmt = "copy %s from stdin with (freeze on)";
> > can be "&& get_table_relkind(con, table) == RELKIND_RELATION"
> >
> > which I think is more natural.
> >
> sounds reasonable.
>
> patch v3 attached

Okay, I've stared at this a bit, and it seems basically fine the way
it is (I might add a bit more whitespace, clean up the commit message,
etc). So I'm interested in committing it. I will admit that having
never committed anything to pgbench, I'm a bit nervous. So, give me a
couple days to work up the nerve.

- Melanie

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgbench with partitioned tables
  In-Reply-To: <CAAKRu_bq3z7oQ4SQRh1EOMFque1xDDO_UdDub+d0XiE4rpGrtw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox