MIME-Version: 1.0
References: 
 <CAASxf_P1F75Ck+0qyb10auT+BORupOM4yigXBnm7aWRNx1LYcA@mail.gmail.com>
 <3007317.1765210195@sss.pgh.pa.us>
 <CAASxf_P5f=Frf8S7rN9BzphtCLoeN9vFuh-V7ukotOQZU54g+w@mail.gmail.com>
 <CAHGQGwHAPXexiGaHMkDDRF7cPBr_3fgCNdT4n2+1UjaEU++BAQ@mail.gmail.com>
 <CAASxf_OGWD7PA5TMEh2MdF2YxN8V3ByLhnFJ=uw0hKr33sgqAw@mail.gmail.com>
 <CAKYtNAqjJbzV+ZJDqA-s0fHSLen6msc=A0SfrTS1ub1KKH9haQ@mail.gmail.com>
 <CADrsxdbb2fn1LACQShrQT0bNqSCQ3hSzEojb2tODhD0PmewDiA@mail.gmail.com>
 <CAASxf_OdsJRi17EZ_ZMyQgOwUzn357YyMqJ2Z2qiExPaLRW_Lg@mail.gmail.com>
 <CADrsxdbPw1ZYcuqH1-DTNhAvRN=tRTTY+_dFy8wU2g4DQb67Bg@mail.gmail.com>
 <CAASxf_PtXCsmu5oCvZH4BmLdojG+0XJUH8foHFZv+2vmsSbNwA@mail.gmail.com>
 <CADrsxdZMOc6qkoVcyp67+Ez8cesey3iDVaVm617oSpiDdf=5xQ@mail.gmail.com>
 <CAASxf_OkeXLZy6r7f05-LjwxgHEXJymQgifU27CAvWEYfY7uVA@mail.gmail.com>
 <CADrsxdZhGHj96ZYy9GR6U9yLtTshfOU-3DFd0aoz70C5S3Np5g@mail.gmail.com>
 <CAASxf_O+CN9Pw+XSHCbfHE2DwS1BObAwFZnnQyT+7062ozYGQw@mail.gmail.com>
 <CADrsxdb_7nCwjfoFJ3p3QvOyQtZUkDVm0aqX73bWd+27tOTO7w@mail.gmail.com>
 <CAD5tBcL7rMgeykb2ZRF3t00SaWzOhtVME-fDqvspH88d+rosFw@mail.gmail.com>
 <CAHg+QDe=UwWiKo6Yqc5=sUdhG=jm7jWd42yM8iGmadbnU0YNEw@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDe=UwWiKo6Yqc5=sUdhG=jm7jWd42yM8iGmadbnU0YNEw@mail.gmail.com>
From: Shruthi Gowda <gowdashru@gmail.com>
Date: Mon, 25 May 2026 13:16:20 +0530
Message-ID: 
 <CAASxf_Pd1uXYgjEJW0FftVB560_N7vK_DC6cEhv36vXea186-w@mail.gmail.com>
Subject: Re: [BUG] CRASH: ECPGprepared_statement() and ECPGdeallocate_all()
 when connection is NULL
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 Nishant Sharma <nishant.sharma@enterprisedb.com>,
	Mahendra Singh Thalor <mahi6run@gmail.com>,
 Fujii Masao <masao.fujii@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000bbc5e306529f9363"
Archived-At: 
 <https://www.postgresql.org/message-id/CAASxf_Pd1uXYgjEJW0FftVB560_N7vK_DC6cEhv36vXea186-w%40mail.gmail.com>
Precedence: bulk

--000000000000bbc5e306529f9363
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 24, 2026 at 12:29=E2=80=AFAM SATYANARAYANA NARLAPURAM <
satyanarlapuram@gmail.com> wrote:

> Hi
>
> On Fri, May 1, 2026 at 12:21=E2=80=AFPM Andrew Dunstan <andrew@dunslane.n=
et>
> wrote:
>
>>
>>
>> On Wed, Apr 22, 2026 at 12:27=E2=80=AFAM Nishant Sharma <
>> nishant.sharma@enterprisedb.com> wrote:
>>
>>> Thanks Shruthi!
>>>
>>> v5 code, v4_test and v4_test_15 patches look good to me.
>>>
>>> I checked ECPG regression on master, REL_18, REL_17, REL_16, REL_15,
>>> REL_14 using both make and meson.
>>>
>>> I have finished my review work on the patches. Thank you!
>>>
>>>
>>>
>>>
>> Thanks, everybody, pushed (as combined patches)
>>
>
> Looks like this committed a case, attached a patch to fix this.
>
> Thanks,
> Satya
>
>
Thanks Satya for looking into this. However, we don't need to add the
validation here because the caller ecpg_do_prologue*()* has already taken
care of it. Adding it again would be redundant. What do you think?

Thanks & Regards,

Shruthi K C

EnterpriseDB: http://www.enterprisedb.com

--000000000000bbc5e306529f9363
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, May 24,=
 2026 at 12:29=E2=80=AFAM SATYANARAYANA NARLAPURAM &lt;<a href=3D"mailto:sa=
tyanarlapuram@gmail.com">satyanarlapuram@gmail.com</a>&gt; wrote:<br></div>=
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=
=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"g=
mail_attr">On Fri, May 1, 2026 at 12:21=E2=80=AFPM Andrew Dunstan &lt;<a hr=
ef=3D"mailto:andrew@dunslane.net" target=3D"_blank">andrew@dunslane.net</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div=
 dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr 22, 2026 at 12:27=E2=80=AFAM =
Nishant Sharma &lt;<a href=3D"mailto:nishant.sharma@enterprisedb.com" targe=
t=3D"_blank">nishant.sharma@enterprisedb.com</a>&gt; wrote:<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"lt=
r">Thanks Shruthi!<div><br></div><div>v5 code, v4_test and v4_test_15 patch=
es look good to me.</div><div><br></div><div>I checked ECPG regression on m=
aster, REL_18, REL_17, REL_16, REL_15, REL_14 using both make and meson.</d=
iv><div><br></div><div>I have finished my review work on the patches. Thank=
 you!</div><div><br></div><div><br></div><br></div></div></blockquote><div>=
<br></div><div>Thanks, everybody, pushed (as combined patches)</div></div><=
/div></blockquote><div><br></div><div>Looks like this committed a case, att=
ached a patch to fix this.</div><div><br></div><div>Thanks,</div><div>Satya=
</div><div>=C2=A0</div></div></div></blockquote><div>Thanks Satya for looki=
ng into this. However, we don&#39;t need to add the validation here because=
 the caller <code style=3D"">ecpg_do_prologue<b>()</b></code> has already t=
aken care of it. Adding it again would be redundant. What do you think?</di=
v><div><br></div><div><p>Thanks &amp; Regards,</p><p>Shruthi K C</p><p>Ente=
rpriseDB<span style=3D"color:rgb(136,136,136)">:=C2=A0</span><a href=3D"htt=
p://www.enterprisedb.com/" rel=3D"noreferrer" target=3D"_blank">http://www.=
enterprisedb.com</a></p></div></div></div>

--000000000000bbc5e306529f9363--