MIME-Version: 1.0
From: Jacob Champion <jchampion@timescale.com>
Date: Mon, 26 Jun 2023 16:55:47 -0700
Message-ID: <CAAWbhmgHtDH1SGZ+Fw05CsXtE0mzTmjbuUxLB9mY9iPKgM6cUw@mail.gmail.com>
Subject: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000898c0f05ff111771"
Archived-At: <https://www.postgresql.org/message-id/CAAWbhmgHtDH1SGZ%2BFw05CsXtE0mzTmjbuUxLB9mY9iPKgM6cUw%40mail.gmail.com>
Precedence: bulk

--000000000000898c0f05ff111771
Content-Type: text/plain; charset="UTF-8"

Hello,

I was running the test_pg_dump extension suite, and I got annoyed that
I couldn't keep it from deleting its dump artifacts after a successful
run. Here's a patch to make use of PG_TEST_NOCLEAN (which currently
covers the test cluster's base directory) with the Test::Utils
tempdirs too.

(Looks like this idea was also discussed last year [1]; let me know if
I missed any more recent suggestions.)

Thanks,
--Jacob

[1] https://www.postgresql.org/message-id/YyPd9unV14SX2bLF@paquier.xyz

--000000000000898c0f05ff111771
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="Test-Utils-honor-PG_TEST_NOCLEAN-for-tempdirs.patch"
Content-Disposition: attachment; 
	filename="Test-Utils-honor-PG_TEST_NOCLEAN-for-tempdirs.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_ljdiib750>
X-Attachment-Id: f_ljdiib750

RnJvbSA0ZTAwOTQ3YjY2ZWRjODNhYjY2YTA2YWE4YTlmNGMxNTkxYTI3MzRjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNvYiBDaGFtcGlvbiA8amNoYW1waW9uQHRpbWVzY2FsZS5j
b20+CkRhdGU6IEZyaSwgMjMgSnVuIDIwMjMgMTM6MzA6MjAgLTA3MDAKU3ViamVjdDogW1BBVENI
XSBUZXN0OjpVdGlsczogaG9ub3IgUEdfVEVTVF9OT0NMRUFOIGZvciB0ZW1wZGlycwoKLS0tCiBz
cmMvdGVzdC9wZXJsL1Bvc3RncmVTUUwvVGVzdC9VdGlscy5wbSB8IDYgKysrLS0tCiAxIGZpbGUg
Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Ny
Yy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L1V0aWxzLnBtIGIvc3JjL3Rlc3QvcGVybC9Qb3N0
Z3JlU1FML1Rlc3QvVXRpbHMucG0KaW5kZXggYTI3ZmFjODNkMi4uZTVhMDhkN2IxYSAxMDA2NDQK
LS0tIGEvc3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvVXRpbHMucG0KKysrIGIvc3JjL3Rl
c3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvVXRpbHMucG0KQEAgLTI3Miw3ICsyNzIsNyBAQCBzdWIg
YWxsX3Rlc3RzX3Bhc3NpbmcKIAogU2VjdXJlbHkgY3JlYXRlIGEgdGVtcG9yYXJ5IGRpcmVjdG9y
eSBpbnNpZGUgQzwkdG1wX2NoZWNrPiwgbGlrZSBDPG1rZHRlbXA+LAogYW5kIHJldHVybiBpdHMg
bmFtZS4gIFRoZSBkaXJlY3Rvcnkgd2lsbCBiZSByZW1vdmVkIGF1dG9tYXRpY2FsbHkgYXQgdGhl
Ci1lbmQgb2YgdGhlIHRlc3RzLgorZW5kIG9mIHRoZSB0ZXN0cywgdW5sZXNzIHRoZSBQR19URVNU
X05PQ0xFQU4gZW52dmFyIGlzIHByb3ZpZGVkLgogCiBJZiBDPHByZWZpeD4gaXMgZ2l2ZW4sIHRo
ZSBuZXcgZGlyZWN0b3J5IGlzIHRlbXBsYXRlZCBhcyBDPCR7cHJlZml4fV9YWFhYPi4KIE90aGVy
d2lzZSB0aGUgdGVtcGxhdGUgaXMgQzx0bXBfdGVzdF9YWFhYPi4KQEAgLTI4Niw3ICsyODYsNyBA
QCBzdWIgdGVtcGRpcgogCXJldHVybiBGaWxlOjpUZW1wOjp0ZW1wZGlyKAogCQkkcHJlZml4IC4g
J19YWFhYJywKIAkJRElSID0+ICR0bXBfY2hlY2ssCi0JCUNMRUFOVVAgPT4gMSk7CisJCUNMRUFO
VVAgPT4gbm90IGRlZmluZWQgJEVOVnsnUEdfVEVTVF9OT0NMRUFOJ30pOwogfQogCiA9cG9kCkBA
IC0zMDEsNyArMzAxLDcgQEAgbmFtZSwgdG8gYXZvaWQgcGF0aCBsZW5ndGggaXNzdWVzLgogc3Vi
IHRlbXBkaXJfc2hvcnQKIHsKIAotCXJldHVybiBGaWxlOjpUZW1wOjp0ZW1wZGlyKENMRUFOVVAg
PT4gMSk7CisJcmV0dXJuIEZpbGU6OlRlbXA6OnRlbXBkaXIoQ0xFQU5VUCA9PiBub3QgZGVmaW5l
ZCAkRU5WeydQR19URVNUX05PQ0xFQU4nfSk7CiB9CiAKID1wb2QKLS0gCjIuMjUuMQoK
--000000000000898c0f05ff111771--