Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ov2Es-0003JK-Og for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Nov 2022 20:08:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ov2Er-0006mx-BP for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Nov 2022 20:08:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ov2Eq-0006mf-UA for pgsql-hackers@lists.postgresql.org; Tue, 15 Nov 2022 20:08:57 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ov2Eo-0003Na-7t for pgsql-hackers@postgresql.org; Tue, 15 Nov 2022 20:08:55 +0000 Received: by mail-lf1-x12c.google.com with SMTP id be13so26233963lfb.4 for ; Tue, 15 Nov 2022 12:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timescale.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Kr6+HLox3PxkiJZelhzmq0jR4B8TLXlenT/4xfhDQiE=; b=kGhhSMTpXukYUgVEKoCmAi2I3uq3g5AhOvjCczPH6C5H8tYsnII5v/hDShDIvDqdIZ U7oXF2K+IrvcQH5K7yLMkIAcR2miOhVZyqylBDPWYbFhyNwjqswa2BTch2eTF6KBDvGz BRLR/4ubGPuohI+BYr/7sv0OPifgn/sp1dFnMslsFFvIUa03eB+FEoMiGFQ/QlFIlo6o xJinpTdPIFs5MWFssIKP9mp2VgsqI65+vP+L8o1iCpwDptHvWodtOrF613aztSe8c7DO e7BDcOk8khqP5hPN920rxoXcMtPnvtFJFR2g3ZOAYMuUEL//taZPVfvqGf2qOa876i9D 2qfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kr6+HLox3PxkiJZelhzmq0jR4B8TLXlenT/4xfhDQiE=; b=7PBsY/WaKqVGsoS4/7r5c0N4k8WX3DmNKAypnABcl4Jg3S90XWP3MswU+bt1lJ2gtx BIf3OLrk8NeH7IiajZzr2DLa+jZsJC++YI2pXFg/E9aypAh3U4KM6XcDHkcY/n9bCRem NEMg2WVCOAX4H8niTivnpKh9TGnA1eDOHNn44DimV/GLqDJ4NFRsIwRbzuwZIOVOCsD+ 0XcBqCzX8pWBZUTQnfnQp0iF5PSyBwjVArDocJhJEyJkm5M0invdTVIOjvjWN3I5t/lw qkVwKZelSdm+FNwG57vajOwRucaHLAvMNJJ0wXFmRm3pdLJzBMBHJwu+hNG1fRB3ml9z 4zbQ== X-Gm-Message-State: ANoB5pkixw3czS4iFbYEMNLHnpi0Wh8y8/xw1SumdCWuiPagi0rEI+zb MU8ELnraUN4IgfIAqpkKD4YLUA18xUQCG2w+Klvxhjrz1uhvdQ== X-Google-Smtp-Source: AA0mqf5pnMT2bUWcNorCthe4enZPfCfv2xShoEuDvho7goUVTWHWN1YfzvqrI6O2FtZIUqGINADuxdpOsylrRqKfL5Y= X-Received: by 2002:a05:6512:456:b0:4b1:5bf0:df51 with SMTP id y22-20020a056512045600b004b15bf0df51mr7093230lfk.674.1668542932663; Tue, 15 Nov 2022 12:08:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jacob Champion Date: Tue, 15 Nov 2022 12:08:40 -0800 Message-ID: Subject: Re: Moving forward with TDE To: David Christensen Cc: PostgreSQL-development , Stephen Frost Content-Type: multipart/mixed; boundary="000000000000cb963a05ed87ec22" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000cb963a05ed87ec22 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 15, 2022 at 11:39 AM David Christensen wrote: > Good to know about the next steps, thanks. You're welcome! > This was just a refresh of the old patches on the wiki to work as written on HEAD. If there are known TODOs here this then that work is still needing to be done. > > I was going to take 2) and Stephen was going to work on 3); I am not sure about the other two but will review the thread you pointed to. Thanks for pointing that out. I've attached the diffs I'm carrying to build this under meson (as well as -Wshadow; my removal of the two variables probably needs some scrutiny). It looks like the testcrypto executable will need substantial changes after the common/hex.h revert. --Jacob --000000000000cb963a05ed87ec22 Content-Type: text/plain; charset="US-ASCII"; name="fix-meson.patch.txt" Content-Disposition: attachment; filename="fix-meson.patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lainbgkw0 RnJvbSBlYjRiNTVmNWQwM2UzNjJjZjM0MGYzMjJjMGNlZmJmOTVmNTM2NTdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNvYiBDaGFtcGlvbiA8amNoYW1waW9uQHRpbWVzY2FsZS5j b20+CkRhdGU6IE1vbiwgMTQgTm92IDIwMjIgMTY6MDI6NTcgLTA4MDAKU3ViamVjdDogW1BBVENI XSBXSVA6IGZpeCBtZXNvbgoKTm90ZSB0aGF0IHRoZSB0ZXN0Y3J5cHRvIGV4ZWN1dGFibGUgbmVl ZHMgdG8gYmUgcmV3cml0dGVuLgotLS0KIHNyYy9iYWNrZW5kL2Jvb3RzdHJhcC9ib290c3RyYXAu YyB8ICAyIC0tCiBzcmMvYmFja2VuZC9jcnlwdG8va21nci5jICAgICAgICAgfCAgMSAtCiBzcmMv YmFja2VuZC9jcnlwdG8vbWVzb24uYnVpbGQgICAgfCAxNCArKysrKysrKysrKysrKwogc3JjL2Jh Y2tlbmQvbWVzb24uYnVpbGQgICAgICAgICAgIHwgIDEgKwogc3JjL2Jpbi9tZXNvbi5idWlsZCAg ICAgICAgICAgICAgIHwgIDEgKwogc3JjL2Jpbi9wZ19hbHRlcmNrZXkvbWVzb24uYnVpbGQgIHwg MTYgKysrKysrKysrKysrKysrKwogc3JjL2NvbW1vbi9tZXNvbi5idWlsZCAgICAgICAgICAgIHwg IDMgKysrCiA3IGZpbGVzIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p CiBjcmVhdGUgbW9kZSAxMDA2NDQgc3JjL2JhY2tlbmQvY3J5cHRvL21lc29uLmJ1aWxkCiBjcmVh dGUgbW9kZSAxMDA2NDQgc3JjL2Jpbi9wZ19hbHRlcmNrZXkvbWVzb24uYnVpbGQKCmRpZmYgLS1n aXQgYS9zcmMvYmFja2VuZC9ib290c3RyYXAvYm9vdHN0cmFwLmMgYi9zcmMvYmFja2VuZC9ib290 c3RyYXAvYm9vdHN0cmFwLmMKaW5kZXggZmZhZjljN2NjNC4uMDdiMmYxNTM0MyAxMDA2NDQKLS0t IGEvc3JjL2JhY2tlbmQvYm9vdHN0cmFwL2Jvb3RzdHJhcC5jCisrKyBiL3NyYy9iYWNrZW5kL2Jv b3RzdHJhcC9ib290c3RyYXAuYwpAQCAtMjU2LDggKzI1Niw2IEBAIEJvb3RzdHJhcE1vZGVNYWlu KGludCBhcmdjLCBjaGFyICphcmd2W10sIGJvb2wgY2hlY2tfb25seSkKIAkJCQlicmVhazsKICAJ CQljYXNlICdLJzoKICAJCQkJewotIAkJCQkJaW50IGk7Ci0gCiAgCQkJCQkvKiBtZXRob2QgMC9k aXNhYmxlZCBjYW5ub3QgYmUgc3BlY2lmaWVkICovCiAgCQkJCQlmb3IgKGkgPSBESVNBQkxFRF9F TkNSWVBUSU9OX01FVEhPRCArIDE7CiAgCQkJCQkJIGkgPCBOVU1fRU5DUllQVElPTl9NRVRIT0RT OyBpKyspCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jcnlwdG8va21nci5jIGIvc3JjL2JhY2tl bmQvY3J5cHRvL2ttZ3IuYwppbmRleCBhODNlZmZiY2E4Li5iNDI0ODk2NWY4IDEwMDY0NAotLS0g YS9zcmMvYmFja2VuZC9jcnlwdG8va21nci5jCisrKyBiL3NyYy9iYWNrZW5kL2NyeXB0by9rbWdy LmMKQEAgLTE0MSw3ICsxNDEsNiBAQCBCb290U3RyYXBLbWdyKHZvaWQpCiAJaWYgKGJvb3RzdHJh cF9vbGRfa2V5X2RhdGFkaXIgPT0gTlVMTCkKIAl7CiAJCXVuc2lnbmVkIGNoYXIgKmJvb3RzdHJh cF9rZXlzX3dyYXBbS01HUl9OVU1fREFUQV9LRVlTXTsKLQkJaW50CQkJa2V5X2xlbnNbS01HUl9O VU1fREFUQV9LRVlTXTsKIAkJUGdDaXBoZXJDdHggKmNsdXN0ZXJfa2V5X2N0eDsKIAogCQkvKiBD cmVhdGUgS0VLIGVuY3J5cHRpb24gY29udGV4dCAqLwpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQv Y3J5cHRvL21lc29uLmJ1aWxkIGIvc3JjL2JhY2tlbmQvY3J5cHRvL21lc29uLmJ1aWxkCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjJiNzJiMjZlYmYKLS0tIC9kZXYvbnVs bAorKysgYi9zcmMvYmFja2VuZC9jcnlwdG8vbWVzb24uYnVpbGQKQEAgLTAsMCArMSwxNCBAQAor YmFja2VuZF9zb3VyY2VzICs9IGZpbGVzKAorICAnYnVmZW5jLmMnLAorICAna21nci5jJywKKykK KworaW5zdGFsbF9kYXRhKAorICAnY2tleV9hd3Muc2guc2FtcGxlJywKKyAgJ2NrZXlfZGlyZWN0 LnNoLnNhbXBsZScsCisgICdja2V5X3Bhc3NwaHJhc2Uuc2guc2FtcGxlJywKKyAgJ2NrZXlfcGl2 X25vcGluLnNoLnNhbXBsZScsCisgICdja2V5X3Bpdl9waW4uc2guc2FtcGxlJywKKyAgJ3NzbF9w YXNzcGhyYXNlLnNoLnNhbXBsZScsCisgIGluc3RhbGxfZGlyOiBkaXJfZGF0YSAvICdhdXRoX2Nv bW1hbmRzJywKKykKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL21lc29uLmJ1aWxkIGIvc3JjL2Jh Y2tlbmQvbWVzb24uYnVpbGQKaW5kZXggMzc1NjJiYWUxMy4uMjE2MmFlZjU1NCAxMDA2NDQKLS0t IGEvc3JjL2JhY2tlbmQvbWVzb24uYnVpbGQKKysrIGIvc3JjL2JhY2tlbmQvbWVzb24uYnVpbGQK QEAgLTksNiArOSw3IEBAIHN1YmRpcignYmFja3VwJykKIHN1YmRpcignYm9vdHN0cmFwJykKIHN1 YmRpcignY2F0YWxvZycpCiBzdWJkaXIoJ2NvbW1hbmRzJykKK3N1YmRpcignY3J5cHRvJykKIHN1 YmRpcignZXhlY3V0b3InKQogc3ViZGlyKCdmb3JlaWduJykKIHN1YmRpcignaml0JykKZGlmZiAt LWdpdCBhL3NyYy9iaW4vbWVzb24uYnVpbGQgYi9zcmMvYmluL21lc29uLmJ1aWxkCmluZGV4IDVm ZDVhOWQyZjkuLjhkZDkxMzMyMTMgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vbWVzb24uYnVpbGQKKysr IGIvc3JjL2Jpbi9tZXNvbi5idWlsZApAQCAtMSw0ICsxLDUgQEAKIHN1YmRpcignaW5pdGRiJykK K3N1YmRpcigncGdfYWx0ZXJja2V5JykKIHN1YmRpcigncGdfYW1jaGVjaycpCiBzdWJkaXIoJ3Bn X2FyY2hpdmVjbGVhbnVwJykKIHN1YmRpcigncGdfYmFzZWJhY2t1cCcpCmRpZmYgLS1naXQgYS9z cmMvYmluL3BnX2FsdGVyY2tleS9tZXNvbi5idWlsZCBiL3NyYy9iaW4vcGdfYWx0ZXJja2V5L21l c29uLmJ1aWxkCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjcyZWM4Mjc0 YzMKLS0tIC9kZXYvbnVsbAorKysgYi9zcmMvYmluL3BnX2FsdGVyY2tleS9tZXNvbi5idWlsZApA QCAtMCwwICsxLDE2IEBACitwZ19hbHRlcmNrZXlfc291cmNlcyA9IGZpbGVzKAorICAncGdfYWx0 ZXJja2V5LmMnLAorKQorCitpZiBob3N0X3N5c3RlbSA9PSAnd2luZG93cycKKyAgcGdfYWx0ZXJj a2V5X3NvdXJjZXMgKz0gcmNfYmluX2dlbi5wcm9jZXNzKHdpbjMydmVyX3JjLCBleHRyYV9hcmdz OiBbCisgICAgJy0tTkFNRScsICdwZ19hbHRlcmNrZXknLAorICAgICctLUZJTEVERVNDJywgJ3Bn X2FsdGVyY2tleSAtIGFsdGVyIHRoZSBjbHVzdGVyIGtleScsXSkKK2VuZGlmCisKK3BnX2FsdGVy Y2tleSA9IGV4ZWN1dGFibGUoJ3BnX2FsdGVyY2tleScsCisgIHBnX2FsdGVyY2tleV9zb3VyY2Vz LAorICBkZXBlbmRlbmNpZXM6IFtmcm9udGVuZF9jb2RlLCBsaWJwcV0sCisgIGt3YXJnczogZGVm YXVsdF9iaW5fYXJncywKKykKK2Jpbl90YXJnZXRzICs9IHBnX2FsdGVyY2tleQpkaWZmIC0tZ2l0 IGEvc3JjL2NvbW1vbi9tZXNvbi5idWlsZCBiL3NyYy9jb21tb24vbWVzb24uYnVpbGQKaW5kZXgg MWM5YjhhM2EwMS4uMTAyYjRkN2IyMyAxMDA2NDQKLS0tIGEvc3JjL2NvbW1vbi9tZXNvbi5idWls ZAorKysgYi9zcmMvY29tbW9uL21lc29uLmJ1aWxkCkBAIC0xMiw2ICsxMiw3IEBAIGNvbW1vbl9z b3VyY2VzID0gZmlsZXMoCiAgICdpcC5jJywKICAgJ2pzb25hcGkuYycsCiAgICdrZXl3b3Jkcy5j JywKKyAgJ2ttZ3JfdXRpbHMuYycsCiAgICdrd2xvb2t1cC5jJywKICAgJ2xpbmstY2FuYXJ5LmMn LAogICAnbWQ1X2NvbW1vbi5jJywKQEAgLTM0LDEyICszNSwxNCBAQCBjb21tb25fc291cmNlcyA9 IGZpbGVzKAogCiBpZiBzc2wuZm91bmQoKQogICBjb21tb25fc291cmNlcyArPSBmaWxlcygKKyAg ICAnY2lwaGVyX29wZW5zc2wuYycsCiAgICAgJ2NyeXB0b2hhc2hfb3BlbnNzbC5jJywKICAgICAn aG1hY19vcGVuc3NsLmMnLAogICAgICdwcm90b2NvbF9vcGVuc3NsLmMnLAogICApCiBlbHNlCiAg IGNvbW1vbl9zb3VyY2VzICs9IGZpbGVzKAorICAgICdjaXBoZXIuYycsCiAgICAgJ2NyeXB0b2hh c2guYycsCiAgICAgJ2htYWMuYycsCiAgICAgJ21kNS5jJywKLS0gCjIuMjUuMQoK --000000000000cb963a05ed87ec22--