public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jacob Champion <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: add timing information to pg_upgrade
Date: Tue, 1 Aug 2023 11:28:27 -0700
Message-ID: <CAAWbhmih90zLbwDkFoGz_bCMuPnmpvskjARBRXuUXJkxOZ04NQ@mail.gmail.com> (raw)
In-Reply-To: <20230801160006.GB723589@nathanxps13>
References: <20230727235134.GA3658499@nathanxps13>
	<[email protected]>
	<[email protected]>
	<20230801160006.GB723589@nathanxps13>

On Tue, Aug 1, 2023 at 9:00 AM Nathan Bossart <[email protected]> wrote:
> >> On 1 Aug 2023, at 09:45, Peter Eisentraut <[email protected]> wrote:
> >> But who would use that, other than, you know, you, right now?

/me raises hand

Or at least, me back when I was hacking on pg_upgrade performance.
This, or something like it, would have been fantastic.

> >> I think the pg_upgrade output is already too full with not-really-actionable information (like most of the above "Checking ..." are not really interesting for a regular user).
>
> Perhaps.  But IMO it's nice to know that it's doing things and making
> progress, even if you don't understand exactly what it's doing all the
> time.

+1. One of our findings at $prevjob was that some users *really* want
some indication, anything at all, that things are progressing and
aren't stuck. There was a lot of anxiety around upgrades.

(There are probably _better_ ways to indicate progress than the
current step divisions... But even poor progress indicators seemed to
lower blood pressures, IIRC.)

> That being said, I wouldn't be opposed to hiding some of this output
> behind a --verbose or --debug option or consolidating some of the steps
> into fewer status messages.

I agree that millisecond-level timing should probably be opt-in.

--Jacob

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: add timing information to pg_upgrade
  In-Reply-To: <CAAWbhmih90zLbwDkFoGz_bCMuPnmpvskjARBRXuUXJkxOZ04NQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox