MIME-Version: 1.0
References: <OS3PR01MB62751414E4DABF144F5E481C9E529@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAHut+PtTN1Udug3x1eZnDdh8Z6PL5VN=xz1b44VbB9T1z_PtcQ@mail.gmail.com>
 <OS3PR01MB6275A9B8C65C381C6828DF9D9E549@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAHut+PvaSDuZ7PhzZOm4c2u-sbN4DUsZr22qyYQ8dncUpqMpXg@mail.gmail.com>
 <OS3PR01MB6275843B2BBE92870F7881C19E299@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAHut+Pt+1PNx6VsZ-xKzAU-18HmNXhjCC1TGakKX46Wg7YNT1Q@mail.gmail.com>
 <OS3PR01MB6275FB5397C6A647F262A3A69E009@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CALDaNm3ZzNJ6Y1iX=PBYCcCU+EPm4=9LVXFin5gvQ9XkEzc8UQ@mail.gmail.com>
 <OS3PR01MB6275C62FF1D1CDE4FCBF61339E079@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <20230207202834.c2ptvco7dv57t3hi@awork3.anarazel.de> <OS3PR01MB62758DFA4FE5BFA7CA0815329ED89@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAA4eK1LCzvPLVHHXn+VcGmFHApKtbpaNF1UFed3qE8=GhPzPGw@mail.gmail.com>
 <OSZPR01MB62783EDCE9DDC21D35B789209EBD9@OSZPR01MB6278.jpnprd01.prod.outlook.com>
 <eb7047d0-6db1-b526-f44a-fad58eda35d4@timescale.com> <CAA4eK1+mzLsECnKzRoof8G2DgH-OBTdjYrP5Ed5QgBBpw2Xe8A@mail.gmail.com>
In-Reply-To: <CAA4eK1+mzLsECnKzRoof8G2DgH-OBTdjYrP5Ed5QgBBpw2Xe8A@mail.gmail.com>
From: Jacob Champion <jchampion@timescale.com>
Date: Mon, 20 Mar 2023 10:52:46 -0700
Message-ID: <CAAWbhmjjJu4eFMC3P-_dJHL=ei5eJ1rvRm2DrYff7kTB6fT+oQ@mail.gmail.com>
Subject: Re: Data is copied twice when specifying both child and parent table
 in publication
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>, Andres Freund <andres@anarazel.de>, 
	vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>, 
	"Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>, 
	"shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, 
	Amit Langote <amitlangote09@gmail.com>, 
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>, 
	Greg Nancarrow <gregn4422@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAAWbhmjjJu4eFMC3P-_dJHL%3Dei5eJ1rvRm2DrYff7kTB6fT%2BoQ%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 17, 2023 at 9:45=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.co=
m> wrote:
> > There are a bunch of moving parts and hidden subtleties here, and I fel=
l
> > into a few traps when I was working on my patch, so it'd be nice to hav=
e
> > additional coverage. I'm happy to contribute effort in that area if it'=
s
> > helpful.
>
> I think it depends on what tests you have in mind.

Just the ones I mentioned, to start with.

> I suggest you can
> propose a patch to cover tests for this are in a separate thread. We
> can then evaluate those separately.

To confirm -- you want me to start a new thread for tests for this
patchset? (Tests written against HEAD would likely be obsoleted by
this change.)

--Jacob