MIME-Version: 1.0
References: <62bbe34d-2315-4b42-b768-56d901aa83e1@gmail.com>
 <1302471.1773940095@sss.pgh.pa.us>
 <CAAZLFmR-S3tyN2xC1K0jZ3T13JZD=_36mYu+0WKCKs1wEROuLw@mail.gmail.com>
 <1305470.1773941734@sss.pgh.pa.us> <1379704.1773944788@sss.pgh.pa.us>
In-Reply-To: <1379704.1773944788@sss.pgh.pa.us>
From: Jianghua Yang <yjhjstz@gmail.com>
Date: Thu, 19 Mar 2026 11:28:49 -0700
Message-ID: 
 <CAAZLFmQEN6zSf32pQRsD5r1prNrVWs5+YAqA6FY++yvvrWgW_w@mail.gmail.com>
Subject: Re: [PATCH] Fix fd leak in pg_dump compression backends when
 dup()+fdopen() fails
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000009404ca064d64bf49"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAZLFmQEN6zSf32pQRsD5r1prNrVWs5%2BYAqA6FY%2B%2ByvvrWgW_w%40mail.gmail.com>
Precedence: bulk

--0000000000009404ca064d64bf49
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for pushing and for the extra scan.

  Regards,
  Jianghua Yang

Tom Lane <tgl@sss.pgh.pa.us> =E4=BA=8E2026=E5=B9=B43=E6=9C=8819=E6=97=A5=E5=
=91=A8=E5=9B=9B 11:26=E5=86=99=E9=81=93=EF=BC=9A

> I wrote:
> > Fair point.  Still, this is such an unlikely edge-case that
> > I don't think it's worth a back-patch.  Let's just do HEAD.
>
> Pushed.  I also looked around for other instances of the same
> pattern, and couldn't find any.
>
>                         regards, tom lane
>

--0000000000009404ca064d64bf49
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks for pushing and for the extra scan.<br><br>=C2=A0 R=
egards,<br>=C2=A0 Jianghua Yang</div><br><div class=3D"gmail_quote gmail_qu=
ote_container"><div dir=3D"ltr" class=3D"gmail_attr">Tom Lane &lt;<a href=
=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt; =E4=BA=8E2026=E5=B9=
=B43=E6=9C=8819=E6=97=A5=E5=91=A8=E5=9B=9B 11:26=E5=86=99=E9=81=93=EF=BC=9A=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I wrote:<br>
&gt; Fair point.=C2=A0 Still, this is such an unlikely edge-case that<br>
&gt; I don&#39;t think it&#39;s worth a back-patch.=C2=A0 Let&#39;s just do=
 HEAD.<br>
<br>
Pushed.=C2=A0 I also looked around for other instances of the same<br>
pattern, and couldn&#39;t find any.<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 regards, tom lane<br>
</blockquote></div>

--0000000000009404ca064d64bf49--