MIME-Version: 1.0
References: 
 <CAAZLFmQNJ0QNArpWEOZXwv=vbumcWKEHz-b1me5gBqRqG67EwQ@mail.gmail.com>
 <ab42G_tMNfBtULhZ@paquier.xyz>
 <CAAZLFmQeS4AFC6mNQNhyZWGUMXEkOmQA11UL28N-6c=CYtqnoA@mail.gmail.com>
 <CAAZLFmQOH+fy6=ybEQ-xGdX9Zee2xkXhfuzCfbWweXxJ_6iD-A@mail.gmail.com>
 <acCJ6C-LHbJWSVEJ@paquier.xyz>
In-Reply-To: <acCJ6C-LHbJWSVEJ@paquier.xyz>
From: Jianghua Yang <yjhjstz@gmail.com>
Date: Sun, 22 Mar 2026 18:36:22 -0700
Message-ID: 
 <CAAZLFmRJ=6OjfrPLLbgMa5yUgSctxagD=3kjdCq_MgKCv0Ohzg@mail.gmail.com>
Subject: Re: basebackup: add missing deflateEnd() in gzip compression sink
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000001b696c064da71225"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAZLFmRJ%3D6OjfrPLLbgMa5yUgSctxagD%3D3kjdCq_MgKCv0Ohzg%40mail.gmail.com>
Precedence: bulk

--0000000000001b696c064da71225
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

 Hi Michael,


  Thank you for reviewing and committing the patch!


  noted on v1-0002 =E2=80=94 understood that the incremental manifest file =
close
isn't an issue there.


  Thanks again.


  Regards,
  Jianghua Yang

Michael Paquier <michael@paquier.xyz> =E4=BA=8E2026=E5=B9=B43=E6=9C=8822=E6=
=97=A5=E5=91=A8=E6=97=A5 17:32=E5=86=99=E9=81=93=EF=BC=9A

> On Sat, Mar 21, 2026 at 02:22:25PM -0700, Jianghua Yang wrote:
> > v1-0001: basebackup: add missing deflateEnd() calls in gzip compression
> > sink
>
> After double-checking the whole code, I agree that this is a good
> practice to have in the tree.  However, the issue is not worth
> bothering in back-branches as the server-side base backup gzip code
> relies on allocation and free callbacks, with zlib internals doing
> nothing with fds or more persistent states as far as I have read its
> code.  For the current use, we'd bloat this data once per tablespace
> in a single base backup, safe even if the connection is persistent
> (missed that in my first message).
>
> What I am more worried about are future callers of this code, though,
> and we care about having a end() call for each matching init[2]() call
> in the tree in all the places that rely on gzip internals.  So that's
> a good practice on consistency ground, at least.  For these reasons,
> applied that on HEAD.
>
> > v1-0002: pg_basebackup: add missing close() for incremental manifest
> > file
>
> This one does not matter.  This resource is for a backup manifest and
> we are talking about a single one for a single invocation of the
> binary.
> --
> Michael
>

--0000000000001b696c064da71225
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: base64

PGRpdiBkaXI9Imx0ciI+wqBIaSBNaWNoYWVsLCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxi
cj7CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxicj7CoCBU
aGFuayB5b3UgZm9yIHJldmlld2luZyBhbmQgY29tbWl0dGluZyB0aGUgcGF0Y2ghIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgPGJyPjxicj7CoCBub3RlZCBvbiB2MS0wMDAyIOKAlCB1bmRlcnN0b29k
IHRoYXQgdGhlIGluY3JlbWVudGFsIG1hbmlmZXN0IGZpbGUgY2xvc2UgaXNuJiMzOTt0IGFuIGlz
c3VlIHRoZXJlLiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCA8YnI+wqAgwqA8YnI+wqAgVGhhbmtzIGFnYWluLiDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoDxicj7CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
oCDCoCDCoCDCoDxicj7CoCBSZWdhcmRzLDxicj7CoCBKaWFuZ2h1YSBZYW5nPC9kaXY+PGJyPjxk
aXYgY2xhc3M9ImdtYWlsX3F1b3RlIGdtYWlsX3F1b3RlX2NvbnRhaW5lciI+PGRpdiBkaXI9Imx0
ciIgY2xhc3M9ImdtYWlsX2F0dHIiPk1pY2hhZWwgUGFxdWllciAmbHQ7PGEgaHJlZj0ibWFpbHRv
Om1pY2hhZWxAcGFxdWllci54eXoiPm1pY2hhZWxAcGFxdWllci54eXo8L2E+Jmd0OyDkuo4yMDI2
5bm0M+aciDIy5pel5ZGo5pelIDE3OjMy5YaZ6YGT77yaPGJyPjwvZGl2PjxibG9ja3F1b3RlIGNs
YXNzPSJnbWFpbF9xdW90ZSIgc3R5bGU9Im1hcmdpbjowcHggMHB4IDBweCAwLjhleDtib3JkZXIt
bGVmdDoxcHggc29saWQgcmdiKDIwNCwyMDQsMjA0KTtwYWRkaW5nLWxlZnQ6MWV4Ij5PbiBTYXQs
IE1hciAyMSwgMjAyNiBhdCAwMjoyMjoyNVBNIC0wNzAwLCBKaWFuZ2h1YSBZYW5nIHdyb3RlOjxi
cj4NCiZndDsgdjEtMDAwMTogYmFzZWJhY2t1cDogYWRkIG1pc3NpbmcgZGVmbGF0ZUVuZCgpIGNh
bGxzIGluIGd6aXAgY29tcHJlc3Npb248YnI+DQomZ3Q7IHNpbms8YnI+DQo8YnI+DQpBZnRlciBk
b3VibGUtY2hlY2tpbmcgdGhlIHdob2xlIGNvZGUsIEkgYWdyZWUgdGhhdCB0aGlzIGlzIGEgZ29v
ZDxicj4NCnByYWN0aWNlIHRvIGhhdmUgaW4gdGhlIHRyZWUuwqAgSG93ZXZlciwgdGhlIGlzc3Vl
IGlzIG5vdCB3b3J0aDxicj4NCmJvdGhlcmluZyBpbiBiYWNrLWJyYW5jaGVzIGFzIHRoZSBzZXJ2
ZXItc2lkZSBiYXNlIGJhY2t1cCBnemlwIGNvZGU8YnI+DQpyZWxpZXMgb24gYWxsb2NhdGlvbiBh
bmQgZnJlZSBjYWxsYmFja3MsIHdpdGggemxpYiBpbnRlcm5hbHMgZG9pbmc8YnI+DQpub3RoaW5n
IHdpdGggZmRzIG9yIG1vcmUgcGVyc2lzdGVudCBzdGF0ZXMgYXMgZmFyIGFzIEkgaGF2ZSByZWFk
IGl0czxicj4NCmNvZGUuwqAgRm9yIHRoZSBjdXJyZW50IHVzZSwgd2UmIzM5O2QgYmxvYXQgdGhp
cyBkYXRhIG9uY2UgcGVyIHRhYmxlc3BhY2U8YnI+DQppbiBhIHNpbmdsZSBiYXNlIGJhY2t1cCwg
c2FmZSBldmVuIGlmIHRoZSBjb25uZWN0aW9uIGlzIHBlcnNpc3RlbnQ8YnI+DQoobWlzc2VkIHRo
YXQgaW4gbXkgZmlyc3QgbWVzc2FnZSkuPGJyPg0KPGJyPg0KV2hhdCBJIGFtIG1vcmUgd29ycmll
ZCBhYm91dCBhcmUgZnV0dXJlIGNhbGxlcnMgb2YgdGhpcyBjb2RlLCB0aG91Z2gsPGJyPg0KYW5k
IHdlIGNhcmUgYWJvdXQgaGF2aW5nIGEgZW5kKCkgY2FsbCBmb3IgZWFjaCBtYXRjaGluZyBpbml0
WzJdKCkgY2FsbDxicj4NCmluIHRoZSB0cmVlIGluIGFsbCB0aGUgcGxhY2VzIHRoYXQgcmVseSBv
biBnemlwIGludGVybmFscy7CoCBTbyB0aGF0JiMzOTtzPGJyPg0KYSBnb29kIHByYWN0aWNlIG9u
IGNvbnNpc3RlbmN5IGdyb3VuZCwgYXQgbGVhc3QuwqAgRm9yIHRoZXNlIHJlYXNvbnMsPGJyPg0K
YXBwbGllZCB0aGF0IG9uIEhFQUQuPGJyPg0KPGJyPg0KJmd0OyB2MS0wMDAyOiBwZ19iYXNlYmFj
a3VwOiBhZGQgbWlzc2luZyBjbG9zZSgpIGZvciBpbmNyZW1lbnRhbCBtYW5pZmVzdDxicj4NCiZn
dDsgZmlsZTxicj4NCjxicj4NClRoaXMgb25lIGRvZXMgbm90IG1hdHRlci7CoCBUaGlzIHJlc291
cmNlIGlzIGZvciBhIGJhY2t1cCBtYW5pZmVzdCBhbmQ8YnI+DQp3ZSBhcmUgdGFsa2luZyBhYm91
dCBhIHNpbmdsZSBvbmUgZm9yIGEgc2luZ2xlIGludm9jYXRpb24gb2YgdGhlPGJyPg0KYmluYXJ5
Ljxicj4NCi0tPGJyPg0KTWljaGFlbDxicj4NCjwvYmxvY2txdW90ZT48L2Rpdj4NCg==
--0000000000001b696c064da71225--