MIME-Version: 1.0
From: Jianghua Yang <yjhjstz@gmail.com>
Date: Tue, 24 Mar 2026 08:44:29 -0700
Message-ID: 
 <CAAZLFmSGti716gWeY=DCZ9TTVOixnHZ4_4V4tDzoeE86D64vOA@mail.gmail.com>
Subject: [PATCH] Fix wrong argument to SOFT_ERROR_OCCURRED in timestamptz_date
To: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000038e510064dc709fb"
Archived-At: 
 <https://www.postgresql.org/message-id/CAAZLFmSGti716gWeY%3DDCZ9TTVOixnHZ4_4V4tDzoeE86D64vOA%40mail.gmail.com>
Precedence: bulk

--00000000000038e510064dc709fb
Content-Type: multipart/alternative; boundary="00000000000038e50f064dc709f9"

--00000000000038e50f064dc709f9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

 Hi hackers,

  I found a small bug in commit e2f289e5b9b ("Make many cast functions
error safe").

  In timestamptz_date(), the SOFT_ERROR_OCCURRED() check mistakenly
  uses fcinfo->args instead of fcinfo->context:

  result =3D timestamptz2date_safe(timestamp, fcinfo->context);
  if (SOFT_ERROR_OCCURRED(fcinfo->args))   /* should be fcinfo->context */
      PG_RETURN_NULL();

  fcinfo->args is a NullableDatum[] array, not a Node *. The
  SOFT_ERROR_OCCURRED macro casts its argument to Node * and reads
  the NodeTag field. When given fcinfo->args, it interprets the first
  argument's Datum value (a TimestampTz) as a NodeTag, which will
  almost never match T_ErrorSaveContext. This causes the soft error
  check to always evaluate to false.

  As a result, when the timestamptz-to-date conversion encounters an
  overflow in error-safe mode, the function returns a wrong date value
  instead of the expected NULL.

  All three sibling functions modified in the same commit (date_timestamp,
  timestamp_date, date_timestamptz) correctly use fcinfo->context.
  This appears to be a copy-paste oversight.

  The fix is a one-line change: fcinfo->args =E2=86=92 fcinfo->context.

--00000000000038e50f064dc709f9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">=C2=A0Hi hackers,<br><br>=C2=A0 I found a small bug in com=
mit e2f289e5b9b (&quot;Make many cast functions error safe&quot;).<br><br>=
=C2=A0 In timestamptz_date(), the SOFT_ERROR_OCCURRED() check mistakenly<br=
>=C2=A0 uses fcinfo-&gt;args instead of fcinfo-&gt;context:<br><br>=C2=A0 r=
esult =3D timestamptz2date_safe(timestamp, fcinfo-&gt;context);<br>=C2=A0 i=
f (SOFT_ERROR_OCCURRED(fcinfo-&gt;args)) =C2=A0 /* should be fcinfo-&gt;con=
text */<br>=C2=A0 =C2=A0 =C2=A0 PG_RETURN_NULL();<br><br>=C2=A0 fcinfo-&gt;=
args is a NullableDatum[] array, not a Node *. The<br>=C2=A0 SOFT_ERROR_OCC=
URRED macro casts its argument to Node * and reads<br>=C2=A0 the NodeTag fi=
eld. When given fcinfo-&gt;args, it interprets the first<br>=C2=A0 argument=
&#39;s Datum value (a TimestampTz) as a NodeTag, which will<br>=C2=A0 almos=
t never match T_ErrorSaveContext. This causes the soft error<br>=C2=A0 chec=
k to always evaluate to false.<br><br>=C2=A0 As a result, when the timestam=
ptz-to-date conversion encounters an<br>=C2=A0 overflow in error-safe mode,=
 the function returns a wrong date value<br>=C2=A0 instead of the expected =
NULL.<br><br>=C2=A0 All three sibling functions modified in the same commit=
 (date_timestamp,<br>=C2=A0 timestamp_date, date_timestamptz) correctly use=
 fcinfo-&gt;context.<br>=C2=A0 This appears to be a copy-paste oversight.<b=
r><br>=C2=A0 The fix is a one-line change: fcinfo-&gt;args =E2=86=92 fcinfo=
-&gt;context.<br><br></div>

--00000000000038e50f064dc709f9--

--00000000000038e510064dc709fb
Content-Type: application/octet-stream;
	name="v1-0001-Fix-wrong-argument-to-SOFT_ERROR_OCCURRED-in-time.patch"
Content-Disposition: attachment;
	filename="v1-0001-Fix-wrong-argument-to-SOFT_ERROR_OCCURRED-in-time.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn4sb22k0>
X-Attachment-Id: f_mn4sb22k0

RnJvbSBmNTUzYWNiYWFmYThjMDZlYjJhMzdjYWRmZjFjODM4YWFkM2NiNzBmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKaWFuZ2h1YSBZYW5nIDx5amhqc3R6QGdtYWlsLmNvbT4KRGF0
ZTogVHVlLCAyNCBNYXIgMjAyNiAwODozNTozMiAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIEZp
eCB3cm9uZyBhcmd1bWVudCB0byBTT0ZUX0VSUk9SX09DQ1VSUkVEIGluCiB0aW1lc3RhbXB0el9k
YXRlCgpJbiBjb21taXQgZTJmMjg5ZTViOWIsIHdoaWNoIG1hZGUgbWFueSBjYXN0IGZ1bmN0aW9u
cyBlcnJvciBzYWZlLAp0aW1lc3RhbXB0el9kYXRlKCkgbWlzdGFrZW5seSBwYXNzZXMgZmNpbmZv
LT5hcmdzIHRvIHRoZQpTT0ZUX0VSUk9SX09DQ1VSUkVEKCkgbWFjcm8gaW5zdGVhZCBvZiBmY2lu
Zm8tPmNvbnRleHQuCgpmY2luZm8tPmFyZ3MgaXMgYSBOdWxsYWJsZURhdHVtW10gYXJyYXksIG5v
dCBhIE5vZGUgcG9pbnRlci4gVGhlIG1hY3JvCmNhc3RzIGl0cyBhcmd1bWVudCB0byBOb2RlKiBh
bmQgY2hlY2tzIHRoZSBOb2RlVGFnIGZpZWxkLiBXaGVuIGdpdmVuCmZjaW5mby0+YXJncywgaXQg
cmVhZHMgdGhlIGZpcnN0IGFyZ3VtZW50J3MgRGF0dW0gdmFsdWUgYXMgYSBOb2RlVGFnLAp3aGlj
aCB3aWxsIGFsbW9zdCBjZXJ0YWlubHkgbm90IG1hdGNoIFRfRXJyb3JTYXZlQ29udGV4dCwgY2F1
c2luZyB0aGUKc29mdCBlcnJvciBjaGVjayB0byBhbHdheXMgZXZhbHVhdGUgdG8gZmFsc2UuCgpB
cyBhIHJlc3VsdCwgd2hlbiB0aGUgdGltZXN0YW1wdHotdG8tZGF0ZSBjb252ZXJzaW9uIGVuY291
bnRlcnMgYW4Kb3ZlcmZsb3cgaW4gZXJyb3Itc2FmZSBtb2RlLCB0aGUgZnVuY3Rpb24gd2lsbCBy
ZXR1cm4gYSBnYXJiYWdlIGRhdGUKdmFsdWUgaW5zdGVhZCBvZiB0aGUgZXhwZWN0ZWQgTlVMTC4K
CkFsbCB0aHJlZSBzaWJsaW5nIGZ1bmN0aW9ucyBtb2RpZmllZCBpbiB0aGUgc2FtZSBjb21taXQK
KGRhdGVfdGltZXN0YW1wLCB0aW1lc3RhbXBfZGF0ZSwgZGF0ZV90aW1lc3RhbXB0eikgY29ycmVj
dGx5IHVzZQpmY2luZm8tPmNvbnRleHQuCgpBdXRob3I6IEppYW5naHVhIFlhbmcgPHlqaGpzdHpA
Z21haWwuY29tPgotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9kYXRlLmMgfCAyICstCiAxIGZp
bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9z
cmMvYmFja2VuZC91dGlscy9hZHQvZGF0ZS5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L2RhdGUu
YwppbmRleCA3MWVhMDQ4ZDI1MS4uYzMzMjc0NDAzODAgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5k
L3V0aWxzL2FkdC9kYXRlLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L2RhdGUuYwpAQCAt
MTQwMiw3ICsxNDAyLDcgQEAgdGltZXN0YW1wdHpfZGF0ZShQR19GVU5DVElPTl9BUkdTKQogCURh
dGVBRFQJCXJlc3VsdDsKIAogCXJlc3VsdCA9IHRpbWVzdGFtcHR6MmRhdGVfc2FmZSh0aW1lc3Rh
bXAsIGZjaW5mby0+Y29udGV4dCk7Ci0JaWYgKFNPRlRfRVJST1JfT0NDVVJSRUQoZmNpbmZvLT5h
cmdzKSkKKwlpZiAoU09GVF9FUlJPUl9PQ0NVUlJFRChmY2luZm8tPmNvbnRleHQpKQogCQlQR19S
RVRVUk5fTlVMTCgpOwogCiAJUEdfUkVUVVJOX0RBVEVBRFQocmVzdWx0KTsKLS0gCjIuNTAuMSAo
QXBwbGUgR2l0LTE1NSkKCg==
--00000000000038e510064dc709fb--