public inbox for [email protected]  
help / color / mirror / Atom feed
From: Hari Krishna Sunder <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Corey Huinker <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: jian he <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Subject: Re: Statistics Import and Export
Date: Mon, 19 May 2025 14:13:45 -0700
Message-ID: <CAAeiqZ38ALsGyDF--qdoDC6wPGfbeOGioZO0EWVH8uJMeHDHAg@mail.gmail.com> (raw)
In-Reply-To: <aCthlMketFE2BnBM@nathan>
References: <Z-9Bx3ml2i7OfHiN@nathan>
	<Z_A5hrD4d8xbsxQB@nathan>
	<Z_A71fHM6Z3ZgfUA@nathan>
	<Z_BIDYMTVksxZpLr@nathan>
	<Z_BcWVMvlUIJ_iuZ@nathan>
	<CADkLM=dMXt_=eeZbe=Kzx1bTNihmOar-1pyBfoe6iOoEWXsU2Q@mail.gmail.com>
	<Z_CQLseJCVRwTXCi@nathan>
	<CAAeiqZ0o2p4SX5_xPcuAbbsmXjg6MJLNuPYSLUjC=Wh-VeW64A@mail.gmail.com>
	<aCS8ZHR_6Py8sMzc@nathan>
	<CAAeiqZ3BPCXziob2-Ldf15h0eS-0C6qbNoT3n5jiXEvMrjEW-w@mail.gmail.com>
	<aCthlMketFE2BnBM@nathan>

Sorry didn't know about the conference.

I think it would be better to revert 9879105 since there can be a
considerable number of true empty tables that we don’t need to process.

---
Hari Krishna Sunder


On Mon, May 19, 2025 at 9:51 AM Nathan Bossart <[email protected]>
wrote:

> On Wed, May 14, 2025 at 01:30:48PM -0700, Hari Krishna Sunder wrote:
> > Here is the patch with a comment.
>
> Thanks.
>
> > On Wed, May 14, 2025 at 8:53 AM Nathan Bossart <[email protected]
> >
> > wrote:
> >> There was a similar report for vacuumdb's new --missing-stats-only
> option.
> >> We fixed that in commit 9879105 by removing the check for reltuples !=
> 0,
> >> which means that --missing-stats-only will process empty tables.
>
> I'm wondering if we should revert commit 9879105 if we take this change,
> which solves the --missing-stats-only problem in a different way.  My
> current thinking is that we should just leave it in place, if for no other
> reason than analyzing some empty tables seems unlikely to cause too much
> trouble.  Thoughts?
>
> --
> nathan
>


view thread (88+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Statistics Import and Export
  In-Reply-To: <CAAeiqZ38ALsGyDF--qdoDC6wPGfbeOGioZO0EWVH8uJMeHDHAg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox