public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Greg Burd <[email protected]>
Cc: Ranier Vilela <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Mon, 20 Apr 2026 10:06:46 +1200
Message-ID: <CAApHDvoKKyzC7DarQb0dwLFtk_4S1UThCtqz9miXjeRmYDZD5w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAEudQAq_zOSA2NUQSWePTGV_=90Uw0WcXxGOWnN-vwF046OOqA@mail.gmail.com>
	<[email protected]>
	<CAApHDvqXdBWMwGuzJBSbq4eiNLDaR738-upd8NJpmhUq3a+XLQ@mail.gmail.com>
	<[email protected]>
	<CAApHDvpn3bshX+_2t0NbJ263r1etcBdmkROjuJw8DvyZkMcXqg@mail.gmail.com>
	<[email protected]>
	<CAApHDvp=pEkO6LKfXKDjRNeQ1LkV7A5fsTn29ahUBXxmjyWPHg@mail.gmail.com>
	<[email protected]>
	<CAApHDvrDW9W72vAr7h7XeCu7+Qz-_Vff02Q+RPPuVeM0Qf0MCw@mail.gmail.com>
	<[email protected]>

On Mon, 20 Apr 2026 at 09:38, Michael Paquier <[email protected]> wrote:
>
> On Sat, Apr 18, 2026 at 09:06:02PM +1200, David Rowley wrote:
> > 2. Doing #1 means the function can't be STRICT. I do think it's wrong
> > that the function is marked as strict. That's normally reserved for
> > functions that we needn't call because NULL input(s) yield a NULL
> > output. That's not the case for this function.
>
> Using the existing HEAD approach where STRICT avoids these extra NULL
> checks, or adding explicit NULL checks without STRICT does not strike
> me as a big difference in this context.

I had to remove STRICT to allow NULL to be passed for the seed. When I
first modified test_bitmapset.c to only choose a random seed when it
received NULL, I thought it was strange that the function appeared to
return NULL. It took me a minute to realise I was getting the STRICT
NULL short-circuiting.

> > I felt it was worth fixing these now as the function I plan to add
> > there does #1, #2, #3 and #4. If I add the new function for v20, the
> > discrepancy seems questionable.
>
> It is a test module, it would be a big issue if new pieces are
> backpatched in this area.  In short I'm fine with these.  Thanks for
> asking.

Did you mean "wouldn't"?

Thanks for looking. I pushed before I saw your reply.

David

view thread (81+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <CAApHDvoKKyzC7DarQb0dwLFtk_4S1UThCtqz9miXjeRmYDZD5w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox