MIME-Version: 1.0
References: <CALdSSPhFyb9qLSHee73XtZm1CBWJNo9+JzFNf-zUEWCRW5yEiQ@mail.gmail.com>
 <2869012.1767023578@sss.pgh.pa.us> <CALdSSPg6UgK+6LJmFQ6G3av4J6dbngN7=QwQEuFZApnpmXgVWQ@mail.gmail.com>
In-Reply-To: <CALdSSPg6UgK+6LJmFQ6G3av4J6dbngN7=QwQEuFZApnpmXgVWQ@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 7 Jan 2026 00:49:59 +1300
Message-ID: <CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe=gTpM0+GfOFh2iDmmw@mail.gmail.com>
Subject: Re: Define DatumGetInt8 function.
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe%3DgTpM0%2BGfOFh2iDmmw%40mail.gmail.com>
Precedence: bulk

On Tue, 30 Dec 2025 at 05:01, Kirill Reshke <reshkekirill@gmail.com> wrote:
> Well, OK. Removal is also fine for me, because it is at least consistent.

Kirill, are you working on this patch?  I've not studied in detail,
but looks like it would require making
char_decrement()/char_increment() and btcharskipsupport() all use
CharGetDatum()/DatumGetChar() and switch to using SCHAR_MIN/SCHAR_MAX
rather than 0/UCHAR_MAX.

If you're not working on it, it would be good if you could withdraw
the patch from the commitfest.

David