MIME-Version: 1.0
References: <3F577953-A29E-4722-98AD-2DA9EFF2CBB8@yesql.se>
 <f6c71f45-8473-482c-a6f7-ed8f0641e11c@iki.fi> <3E020742-206E-4052-83AF-8721190A10E0@yesql.se>
 <CAApHDvpctL0i5Zu2i_vr5FoHG44g+fDshMM0ukQVx7D5kE=K=g@mail.gmail.com>
 <39A535AF-154F-4FFD-B887-3C4EDC362DA4@yesql.se> <CAN55FZ1YsO7e7Wr_49gi=2ne+Ov_YPY6q0EE-OxCJ1kWSJfEwg@mail.gmail.com>
 <D18650AE-65BF-431D-9FE0-6AD118F757A3@yesql.se> <CAApHDvq-2Zdqytm_Hf3RmVf0qg5PS9jTFAJ5QTc9xH9pwvwDTA@mail.gmail.com>
 <CAApHDvr3zgeb+2cQTsbyRcV2ZkjeMiHyDXYSWB5z71WwSyxwDA@mail.gmail.com>
 <ae9f2fcb-4b24-5bb0-4240-efbbbd944ca1@gmail.com> <CAApHDvq7chgw8=7TU4-hLpQNw8e7qN9_oA4ew2UH05RCcihEDQ@mail.gmail.com>
 <c1d63754-cb85-2d8a-8409-bde2c4d2d04b@gmail.com>
In-Reply-To: <c1d63754-cb85-2d8a-8409-bde2c4d2d04b@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Mon, 12 Aug 2024 23:59:31 +1200
Message-ID: <CAApHDvoYsiFkZpjWeLGejibAXi=T3B70MzFr7z-1EiJ4pVX2hA@mail.gmail.com>
Subject: Re: Typos in the code and README
To: Alexander Lakhin <exclusion@gmail.com>, Robert Haas <robertmhaas@gmail.com>, 
	Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Nazir Bilal Yavuz <byavuz81@gmail.com>, 
	Heikki Linnakangas <hlinnaka@iki.fi>, 
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000093524d061f7b3ac1"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvoYsiFkZpjWeLGejibAXi%3DT3B70MzFr7z-1EiJ4pVX2hA%40mail.gmail.com>
Precedence: bulk

--00000000000093524d061f7b3ac1
Content-Type: text/plain; charset="UTF-8"

(I know Daniel mentioned he'd get to these, but the ScanDirection one
was my fault and I needed to clear that off my mind. I did a few
others while on this topic.)

On Fri, 5 Jul 2024 at 05:00, Alexander Lakhin <exclusion@gmail.com> wrote:
> Please look at another bunch of inconsistencies/orphaned entities I found
> in the tree, with the possible substitutions:
> errmsg_buf -> errormsg_buf
> (coined by 6b18b3fe2)

Fixed.

> NoMovementScanDirectionScans -> NoMovementScanDirection
> (introduced with e9aaf0632, discussed in [1], but still seems inaccurate)

Oops. Fixed.

> XLogReadRecordInternal -> XLogReadRecord
> (from 3f1ce9734, align with a comment above: "Start and end point of last
> record returned by XLogReadRecord().")

Fixed.

> BYPASS_ALLOWCONN -> BGWORKER_BYPASS_ROLELOGINCHECK (see 492217301)

Fixed

> xs_ctup.t_self -> xs_heaptid (see c2fe139c2 and 304532421)

Fixed.

> pgStatShmLookupCache -> pgStatLocal.shmem (coined by 5891c7a8e)

Fixed.

> smgr_fsm_nblocks and smgr_vm_nblocks -> smgr_cached_nblocks
> (see the same comment updated by c5315f4f4)

Heikki fixed in 19de089cd.

> XID becomes older than GlobalXmin -> XID becomes visible to everyone
> (in accordance with dc7420c2c9 src/backend/access/gist/gistutil.c)

I'd need to spend more time to understand this.

> gen-rtab - remove (non-existing since db7d1a7b0)

Daniel fixed in cc59f9d0f.

> BARRIER_SHOULD_CHECK - remove (unused since a3ed4d1ef)

I wasn't sure if nothing else external could be using this. The macro
doesn't use any fields that are now gone, so I'm not confident enough
to remove it. Can Robert confirm?

> EXE_EXT - remove (unused since f06b1c598)

Daniel fixed in 88e3da565.

> endterm - remove
> (see 60c90c16c -- Use xreflabel attributes instead of endterm ...)

I read that commit message and I agree it's now unused. I just didn't
get any vibes from the commit message that it shouldn't ever be used
again.  Can Tom confirm?

> xl_commit_ts_set, SizeOfCommitTsSet - remove (unused since 08aa89b32)

I would say it should be removed.  I just didn't because the commit I
had pending fitted into the "typos" category and this didn't quite
fit.

I've attached a patch with the remainder.

David

--00000000000093524d061f7b3ac1
Content-Type: application/octet-stream; name="remaining_typos.patch"
Content-Disposition: attachment; filename="remaining_typos.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lzqxovi30>
X-Attachment-Id: f_lzqxovi30

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9SRUFETUUubGlua3MgYi9kb2Mvc3JjL3NnbWwvUkVB
RE1FLmxpbmtzCmluZGV4IDY1ZGY5YzExMWYuLjkwMGUwMzA4YjYgMTAwNjQ0Ci0tLSBhL2RvYy9z
cmMvc2dtbC9SRUFETUUubGlua3MKKysrIGIvZG9jL3NyYy9zZ21sL1JFQURNRS5saW5rcwpAQCAt
MTUsMTAgKzE1LDYgQEAgSW50cmEtZG9jdW1lbnQgTGlua2luZwogbGlua2VuZD0KIAljb250cm9s
cyB0aGUgdGFyZ2V0IG9mIHRoZSBsaW5rL3hyZWYsIHJlcXVpcmVkCiAKLWVuZHRlcm09Ci0JZm9y
IDx4cmVmPiwgYWxsb3dzIHRoZSB0ZXh0IG9mIHRoZSBsaW5rL3hyZWYgdG8gYmUgdGFrZW4gZnJv
bSBhCi0JZGlmZmVyZW50IGxpbmsgdGFyZ2V0IHRpdGxlCi0KIDxsaW5rPgogCXVzZSB0byBzdXBw
bHkgdGV4dCBmb3IgdGhlIGxpbmssIG9ubHkgdXNlcyBsaW5rZW5kLCByZXF1aXJlcyA8L2xpbms+
CiAJaHR0cDovL3d3dy5vYXNpcy1vcGVuLm9yZy9kb2Nib29rL2RvY3VtZW50YXRpb24vcmVmZXJl
bmNlL2h0bWwvbGluay5odG1sCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvZ2lzdC9n
aXN0dmFjdXVtLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvZ2lzdC9naXN0dmFjdXVtLmMKaW5kZXgg
MjRmYjk0ZjQ3My4uNTkzNzI3ODNkMCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dp
c3QvZ2lzdHZhY3V1bS5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy9naXN0L2dpc3R2YWN1dW0u
YwpAQCAtNjQzLDcgKzY0Myw3IEBAIGdpc3RkZWxldGVwYWdlKEluZGV4VmFjdXVtSW5mbyAqaW5m
bywgSW5kZXhCdWxrRGVsZXRlUmVzdWx0ICpzdGF0cywKIAkgKiBUaGUgcGFnZSBjYW5ub3QgYmUg
aW1tZWRpYXRlbHkgcmVjeWNsZWQsIGJlY2F1c2UgaW4tcHJvZ3Jlc3Mgc2NhbnMgdGhhdAogCSAq
IHNhdyB0aGUgZG93bmxpbmsgbWlnaHQgc3RpbGwgdmlzaXQgaXQuICBNYXJrIHRoZSBwYWdlIHdp
dGggdGhlIGN1cnJlbnQKIAkgKiBuZXh0LVhJRCBjb3VudGVyLCBzbyB0aGF0IHdlIGtub3cgd2hl
biBpdCBjYW4gYmUgcmVjeWNsZWQuICBPbmNlIHRoYXQKLQkgKiBYSUQgYmVjb21lcyBvbGRlciB0
aGFuIEdsb2JhbFhtaW4sIHdlIGtub3cgdGhhdCBhbGwgc2NhbnMgdGhhdCBhcmUKKwkgKiBYSUQg
YmVjb21lcyB2aXNpYmxlIHRvIGV2ZXJ5b25lLCB3ZSBrbm93IHRoYXQgYWxsIHNjYW5zIHRoYXQg
YXJlCiAJICogY3VycmVudGx5IGluIHByb2dyZXNzIG11c3QgaGF2ZSBlbmRlZC4gIChUaGF0J3Mg
bXVjaCBtb3JlIGNvbnNlcnZhdGl2ZQogCSAqIHRoYW4gbmVlZGVkLCBidXQgbGV0J3Mga2VlcCBp
dCBzYWZlIGFuZCBzaW1wbGUuKQogCSAqLwpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFn
ZS9pcGMvcHJvY3NpZ25hbC5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvcHJvY3NpZ25hbC5j
CmluZGV4IDg3MDI3ZjI3ZWIuLmNhYmRkZDc2NTQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0
b3JhZ2UvaXBjL3Byb2NzaWduYWwuYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9wcm9j
c2lnbmFsLmMKQEAgLTkzLDEwICs5Myw2IEBAIHN0cnVjdCBQcm9jU2lnbmFsSGVhZGVyCiAgKi8K
ICNkZWZpbmUgTnVtUHJvY1NpZ25hbFNsb3RzCShNYXhCYWNrZW5kcyArIE5VTV9BVVhJTElBUllf
UFJPQ1MpCiAKLS8qIENoZWNrIHdoZXRoZXIgdGhlIHJlbGV2YW50IHR5cGUgYml0IGlzIHNldCBp
biB0aGUgZmxhZ3MuICovCi0jZGVmaW5lIEJBUlJJRVJfU0hPVUxEX0NIRUNLKGZsYWdzLCB0eXBl
KSBcCi0JKCgoZmxhZ3MpICYgKCgodWludDMyKSAxKSA8PCAodWludDMyKSAodHlwZSkpKSAhPSAw
KQotCiAvKiBDbGVhciB0aGUgcmVsZXZhbnQgdHlwZSBiaXQgZnJvbSB0aGUgZmxhZ3MuICovCiAj
ZGVmaW5lIEJBUlJJRVJfQ0xFQVJfQklUKGZsYWdzLCB0eXBlKSBcCiAJKChmbGFncykgJj0gfigo
KHVpbnQzMikgMSkgPDwgKHVpbnQzMikgKHR5cGUpKSkKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRl
L2FjY2Vzcy9jb21taXRfdHMuaCBiL3NyYy9pbmNsdWRlL2FjY2Vzcy9jb21taXRfdHMuaAppbmRl
eCA4MmQzYWE4NjI3Li5jMThmYWVhNzZkIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9hY2Nlc3Mv
Y29tbWl0X3RzLmgKKysrIGIvc3JjL2luY2x1ZGUvYWNjZXNzL2NvbW1pdF90cy5oCkBAIC00Niwx
NyArNDYsNiBAQCBleHRlcm4gaW50CWNvbW1pdHRzc3luY2ZpbGV0YWcoY29uc3QgRmlsZVRhZyAq
ZnRhZywgY2hhciAqcGF0aCk7CiAjZGVmaW5lIENPTU1JVF9UU19aRVJPUEFHRQkJMHgwMAogI2Rl
ZmluZSBDT01NSVRfVFNfVFJVTkNBVEUJCTB4MTAKIAotdHlwZWRlZiBzdHJ1Y3QgeGxfY29tbWl0
X3RzX3NldAotewotCVRpbWVzdGFtcFR6IHRpbWVzdGFtcDsKLQlSZXBPcmlnaW5JZCBub2RlaWQ7
Ci0JVHJhbnNhY3Rpb25JZCBtYWlueGlkOwotCS8qIHN1YnhhY3QgWGlkcyBmb2xsb3cgKi8KLX0J
CQl4bF9jb21taXRfdHNfc2V0OwotCi0jZGVmaW5lIFNpemVPZkNvbW1pdFRzU2V0CShvZmZzZXRv
Zih4bF9jb21taXRfdHNfc2V0LCBtYWlueGlkKSArIFwKLQkJCQkJCQkgc2l6ZW9mKFRyYW5zYWN0
aW9uSWQpKQotCiB0eXBlZGVmIHN0cnVjdCB4bF9jb21taXRfdHNfdHJ1bmNhdGUKIHsKIAlpbnQ2
NAkJcGFnZW5vOwo=
--00000000000093524d061f7b3ac1--