MIME-Version: 1.0
References: <CAApHDvq-2Zdqytm_Hf3RmVf0qg5PS9jTFAJ5QTc9xH9pwvwDTA@mail.gmail.com>
 <CAApHDvr3zgeb+2cQTsbyRcV2ZkjeMiHyDXYSWB5z71WwSyxwDA@mail.gmail.com>
 <ae9f2fcb-4b24-5bb0-4240-efbbbd944ca1@gmail.com> <CAApHDvq7chgw8=7TU4-hLpQNw8e7qN9_oA4ew2UH05RCcihEDQ@mail.gmail.com>
 <c1d63754-cb85-2d8a-8409-bde2c4d2d04b@gmail.com> <CAApHDvoYsiFkZpjWeLGejibAXi=T3B70MzFr7z-1EiJ4pVX2hA@mail.gmail.com>
 <f7e514cf-2446-21f1-a5d2-8c089a6e2168@gmail.com> <ZtadkEfXje7zvOs4@paquier.xyz>
 <Ztaj7BkN4658OMxF@paquier.xyz> <D240643D-7D6A-49EB-BA69-D6B784B4F237@yesql.se>
 <Zte2_cC1x7IW5_Ez@paquier.xyz> <15512E98-BDB0-44E3-AAB6-217F322AB5F0@yesql.se>
In-Reply-To: <15512E98-BDB0-44E3-AAB6-217F322AB5F0@yesql.se>
From: David Rowley <dgrowleyml@gmail.com>
Date: Thu, 5 Sep 2024 03:34:31 +1200
Message-ID: <CAApHDvohP80M6CLocGM_ycoM2tcTWBQu0i9_eKdgeyRQmn9bKQ@mail.gmail.com>
Subject: Re: Typos in the code and README
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Alexander Lakhin <exclusion@gmail.com>, 
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, 
	Nazir Bilal Yavuz <byavuz81@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, 
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvohP80M6CLocGM_ycoM2tcTWBQu0i9_eKdgeyRQmn9bKQ%40mail.gmail.com>
Precedence: bulk

On Wed, 4 Sept 2024 at 20:24, Daniel Gustafsson <daniel@yesql.se> wrote:
> Not mandatory at all, but since you were prepping a typo backpatch anyways I
> figured these could join to put a small dent in reducing risks for future
> backports.

I think this is pretty good logic.  I think fixing comment typos in
ancient code and backpatching to all supported versions isn't good use
of time, but fixing a typo in "recent" code and backpatching to where
that code was added seems useful. Newer code is more likely to need
bug fixes in the future, so going to a bit more effort to make
backpatching those bug fixes easier seems worth the effort.  I just
don't know what "recent" should be defined as. I'd say if it's in a
version we've not released yet, that's probably recent. By the time .1
is out, there's less chance of bugs in new code. Anyway, I doubt hard
guidelines are warranted here, but maybe some hints about best
practices in https://wiki.postgresql.org/wiki/Committing_checklist ?

David