MIME-Version: 1.0
References: <adt4wpj4FZwR+S7I@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAApHDvqFBWx+Ghdy3_LXq5u+v-HCS0zwh4Pp+qtaSfJxmMhkiA@mail.gmail.com>
In-Reply-To: 
 <CAApHDvqFBWx+Ghdy3_LXq5u+v-HCS0zwh4Pp+qtaSfJxmMhkiA@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Mon, 13 Apr 2026 10:45:37 +1200
Message-ID: 
 <CAApHDvp1d_tN-7ZVESZB9Eih+dGxxsWATC63nKLAjtM5yu_jxQ@mail.gmail.com>
Subject: Re: Use stack allocated StringInfoDatas, where possible (round 2)
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvp1d_tN-7ZVESZB9Eih%2BdGxxsWATC63nKLAjtM5yu_jxQ%40mail.gmail.com>
Precedence: bulk

On Mon, 13 Apr 2026 at 01:34, David Rowley <dgrowleyml@gmail.com> wrote:
> I think the author of copy_sequences() doesn't know what
> resetStringInfo() does. I expect they think that it'll pfree all the
> memory, but that's what destroyStringInfo() is for.

That was poor analysis. The resetStringInfo is there to reset the
StringInfo before the next loop. So nothing is wrong with it.

I've now pushed your patch.

David